Skip to content

Update alpine-3.17 to alpine-3.19-WithNode#18209

Merged
MichaelSimons merged 1 commit into
dotnet:mainfrom
ellahathaway:alpine-container
Jan 11, 2024
Merged

Update alpine-3.17 to alpine-3.19-WithNode#18209
MichaelSimons merged 1 commit into
dotnet:mainfrom
ellahathaway:alpine-container

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

Fixes dotnet/source-build#3920

Note that the alpine-3.19 artifacts will need to be uploaded due to changing the artifacts rid from alpine.3.17-x64 to alpine-3.19-x64.

@ellahathaway ellahathaway requested a review from a team January 10, 2024 23:02
Copy link
Copy Markdown
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What impact is this going to have on the PreviousSourceBuildSdk artifact? Is it now going to start looking for an alpine3.19 artifact in the source-build-artifacts blob storage and fail because right now there is only a alpine3.17 artifact?

@ellahathaway
Copy link
Copy Markdown
Member Author

ellahathaway commented Jan 10, 2024

Is it now going to start looking for an alpine3.19 artifact in the source-build-artifacts blob storage and fail because right now there is only a alpine3.17 artifact?

Yes. The alpine Stage 2 leg will fail until we upload the artifacts from a successful alpine 3.19 Stage 1 build into blob storage. I would have ideally preferred this new container image to be alpine3.17 to avoid this, since this change to 3.19 will ultimately delay a clean build of the VMR.

@mthalman
Copy link
Copy Markdown
Member

So essentially what this means is that we'll need to re-bootstrap after we get a build from these changes.

@MichaelSimons MichaelSimons merged commit 92ebfab into dotnet:main Jan 11, 2024
@ellahathaway
Copy link
Copy Markdown
Member Author

Build fails (as expected) because the alpine-3.19 sdk does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node not installed in Alpine317_Offline_PreviousSourceBuilt VMR Build

3 participants