From ef25356be3aa301973c9ae3c2158d1444a027bec Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Thu, 15 Mar 2018 09:36:20 -0500 Subject: [PATCH] [build] fix for unit tests to run on VSTS To get our desired behavior on VSTS, we have to: - Make sure our call to NUnit returns a failing exit code - Set the "Continue on Error" option in VSTS - Add a step at the end of our build definition in VSTS to fail the build if any issues ocurred To make this work, we have to change our `` task usage to `ContinueOnError="ErrorAndContinue"`. I tested the VSTS behavior upstream in xamarin-android, see a build here: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1478269 Other changes: - Added `Resource.designer.cs` to .gitignore to match xamarin-android --- .gitignore | 3 ++- build-tools/scripts/RunNUnitTests.targets | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 6e129c8d9..06e74a2ed 100644 --- a/.gitignore +++ b/.gitignore @@ -8,4 +8,5 @@ TestResult-*.xml xa-gendarme.html packages .vs/ -*.userprefs \ No newline at end of file +*.userprefs +Resource.designer.cs \ No newline at end of file diff --git a/build-tools/scripts/RunNUnitTests.targets b/build-tools/scripts/RunNUnitTests.targets index 47af834eb..6d30075b9 100644 --- a/build-tools/scripts/RunNUnitTests.targets +++ b/build-tools/scripts/RunNUnitTests.targets @@ -30,7 +30,7 @@ \ No newline at end of file