From 3602011f8e3a83a42266f53a78f6a51f5b877c85 Mon Sep 17 00:00:00 2001 From: "REDMOND\\nakazmi" Date: Thu, 9 May 2019 14:03:11 -0700 Subject: [PATCH 1/3] Fix documentation for LightGbm parameter --- src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs b/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs index bdaca7a1b7..fb6bbeefde 100644 --- a/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs +++ b/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs @@ -187,8 +187,7 @@ private protected OptionsBase() { } public int MinimumExampleCountPerGroup = 100; /// - /// When the number of categories of one feature is smaller than or equal to , - /// one-vs-other split algorithm will be used. + /// Maximum categorical split points to consider when splitting on a categorical feature. /// [Argument(ArgumentType.AtMostOnce, HelpText = "Max number of categorical thresholds.", ShortName = "maxcat")] [TlcModule.Range(Inf = 0, Max = int.MaxValue)] From 822d4d8e7fdc6197c1ca6578768d87dd319a6d4a Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Tue, 14 May 2019 21:46:21 -0700 Subject: [PATCH 2/3] Brew install libomp 7.0.0 only. (#3721) * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. * Brew install libomp 7.0.0 only. --- build/ci/phase-template.yml | 2 +- build/vsts-ci.yml | 2 +- docs/building/unix-instructions.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/build/ci/phase-template.yml b/build/ci/phase-template.yml index f018d9613c..6d70c14bda 100644 --- a/build/ci/phase-template.yml +++ b/build/ci/phase-template.yml @@ -34,7 +34,7 @@ phases: ${{ insert }}: ${{ parameters.queue }} steps: - ${{ if eq(parameters.queue.name, 'Hosted macOS') }}: - - script: brew update && brew install libomp && brew install mono-libgdiplus gettext && brew link gettext --force && brew link libomp --force + - script: brew update && brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb && brew install mono-libgdiplus gettext && brew link gettext --force && brew link libomp --force displayName: Install build dependencies - script: $(_buildScript) -$(_configuration) -buildArch=$(_arch) displayName: Build diff --git a/build/vsts-ci.yml b/build/vsts-ci.yml index 05bfda32b0..c8091ea281 100644 --- a/build/vsts-ci.yml +++ b/build/vsts-ci.yml @@ -48,7 +48,7 @@ phases: demands: - agent.os -equals Darwin steps: - - script: brew update && brew install libomp && brew link libomp --force + - script: brew update && brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb && brew link libomp --force displayName: Install build dependencies # Only build native assets to avoid conflicts. - script: ./build.sh -buildNative -$(BuildConfig) -skipRIDAgnosticAssets diff --git a/docs/building/unix-instructions.md b/docs/building/unix-instructions.md index ec7e27e8d4..f495b2c1bf 100644 --- a/docs/building/unix-instructions.md +++ b/docs/building/unix-instructions.md @@ -43,12 +43,12 @@ macOS 10.12 (Sierra) or higher is needed to build dotnet/machinelearning. On macOS a few components are needed which are not provided by a default developer setup: * cmake 3.10.3 -* libomp +* libomp 7 * libgdiplus * gettext * All the requirements necessary to run .NET Core 2.0 applications. To view macOS prerequisites click [here](https://docs.microsoft.com/en-us/dotnet/core/macos-prerequisites?tabs=netcore2x). One way of obtaining CMake and other required libraries is via [Homebrew](https://brew.sh): ```sh -$ brew install cmake libomp mono-libgdiplus gettext && brew link gettext --force +$ brew install cmake https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb mono-libgdiplus gettext && brew link gettext --force ``` From f36e0a89a667c5ba4c507e7ae571d0678e99bb6b Mon Sep 17 00:00:00 2001 From: "REDMOND\\nakazmi" Date: Thu, 9 May 2019 14:03:11 -0700 Subject: [PATCH 3/3] Fix documentation for LightGbm parameter --- src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs b/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs index bdaca7a1b7..fb6bbeefde 100644 --- a/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs +++ b/src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs @@ -187,8 +187,7 @@ private protected OptionsBase() { } public int MinimumExampleCountPerGroup = 100; /// - /// When the number of categories of one feature is smaller than or equal to , - /// one-vs-other split algorithm will be used. + /// Maximum categorical split points to consider when splitting on a categorical feature. /// [Argument(ArgumentType.AtMostOnce, HelpText = "Max number of categorical thresholds.", ShortName = "maxcat")] [TlcModule.Range(Inf = 0, Max = int.MaxValue)]