From 4a89d4c9aeb9f87552666c93b2c90c12dfa01cab Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Thu, 6 Feb 2020 13:10:29 -0800 Subject: [PATCH] Enable RS1026 (Enable concurrent execution) --- .editorconfig | 3 --- .../Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs | 1 + .../ContractsCheckAnalyzer.cs | 2 ++ .../InstanceInitializerAnalyzer.cs | 2 ++ tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs | 2 ++ .../ParameterVariableNameAnalyzer.cs | 2 ++ .../SingleVariableDeclarationAnalyzer.cs | 2 ++ .../Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs | 2 ++ 8 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.editorconfig b/.editorconfig index e0ebb6888b..6b5fc14e6e 100644 --- a/.editorconfig +++ b/.editorconfig @@ -13,9 +13,6 @@ dotnet_diagnostic.VSTHRD103.severity = none # VSTHRD200: Use "Async" suffix for async methods dotnet_diagnostic.VSTHRD200.severity = none -# RS1026: Enable concurrent execution -dotnet_diagnostic.RS1026.severity = none - [test/**/*.cs] # MSML_GeneralName: This name should be PascalCased diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs index 8d59701dff..309c00a132 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs @@ -40,6 +40,7 @@ public override void Initialize(AnalysisContext context) { // This analyzer reports violations in all code (including generated code) context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics); + context.EnableConcurrentExecution(); context.RegisterSemanticModelAction(Analyze); } diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/ContractsCheckAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/ContractsCheckAnalyzer.cs index efce9ba269..4f888cd069 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/ContractsCheckAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/ContractsCheckAnalyzer.cs @@ -88,6 +88,8 @@ internal static class DecodeMessageWithLoadContextDiagnostic public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.InvocationExpression); } diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/InstanceInitializerAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/InstanceInitializerAnalyzer.cs index c4bd2fe38c..5afc55aab7 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/InstanceInitializerAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/InstanceInitializerAnalyzer.cs @@ -31,6 +31,8 @@ public sealed class InstanceInitializerAnalyzer : DiagnosticAnalyzer public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSymbolAction(AnalyzeField, SymbolKind.Field); context.RegisterSymbolAction(AnalyzeProperty, SymbolKind.Property); } diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs index 578048ad57..cb1755d3ab 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/NameAnalyzer.cs @@ -74,6 +74,8 @@ internal static class GeneralName public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSyntaxNodeAction(AnalyzeField, SyntaxKind.FieldDeclaration); context.RegisterSyntaxNodeAction(AnalyzeField, SyntaxKind.EventFieldDeclaration); context.RegisterSyntaxNodeAction(AnalyzeClass, SyntaxKind.ClassDeclaration); diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/ParameterVariableNameAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/ParameterVariableNameAnalyzer.cs index 04b7373626..db60887534 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/ParameterVariableNameAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/ParameterVariableNameAnalyzer.cs @@ -32,6 +32,8 @@ public sealed class ParameterVariableNameAnalyzer : DiagnosticAnalyzer public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSyntaxNodeAction(AnalyzeParameter, SyntaxKind.Parameter); context.RegisterSyntaxNodeAction(AnalyzeLocal, SyntaxKind.LocalDeclarationStatement); } diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/SingleVariableDeclarationAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/SingleVariableDeclarationAnalyzer.cs index 8b7efb8f53..dc39e2b7b7 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/SingleVariableDeclarationAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/SingleVariableDeclarationAnalyzer.cs @@ -32,6 +32,8 @@ public sealed class SingleVariableDeclarationAnalyzer : DiagnosticAnalyzer public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.VariableDeclaration); } diff --git a/tools-local/Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs b/tools-local/Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs index 8ba7de74b5..8ee7e70a36 100644 --- a/tools-local/Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs +++ b/tools-local/Microsoft.ML.InternalCodeAnalyzer/TypeParamNameAnalyzer.cs @@ -31,6 +31,8 @@ public sealed class TypeParamNameAnalyzer : DiagnosticAnalyzer public override void Initialize(AnalysisContext context) { context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); + context.EnableConcurrentExecution(); + context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.TypeParameter); }