From fa92b38b0e3f4e3e5dfe473c03dd5ca8620bc75c Mon Sep 17 00:00:00 2001 From: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com> Date: Fri, 21 Feb 2020 22:58:34 -0800 Subject: [PATCH 1/2] reenable 2 tests but skip running from x86 --- .../DnnImageFeaturizerTest.cs | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs b/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs index b9f68944c9..f3c981cef4 100644 --- a/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs +++ b/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs @@ -54,10 +54,13 @@ public DnnImageFeaturizerTests(ITestOutputHelper helper) : base(helper) } [OnnxFact] - //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined - [Trait("Category", "SkipInCI")] public void TestDnnImageFeaturizer() { + //skip running for x86 as this test using too much memory (over 2GB limit on x86) + //and very like to hit memory related issue when running on CI + if (!Environment.Is64BitProcess) + return; + var samplevector = GetSampleArrayData(); var dataView = DataViewConstructionUtils.CreateFromList(Env, @@ -125,12 +128,14 @@ public void OnnxFeaturizerWorkout() } } - // Onnx is only supported on x64 Windows [OnnxFact] - //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined - [Trait("Category", "SkipInCI")] public void TestOldSavingAndLoading() { + //skip running for x86 as this test using too much memory (over 2GB limit on x86) + //and very like to hit memory related issue when running on CI + if (!Environment.Is64BitProcess) + return; + var samplevector = GetSampleArrayData(); var dataView = ML.Data.LoadFromEnumerable( From aaa68968b85cefd260086da18228a2964eecafde Mon Sep 17 00:00:00 2001 From: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com> Date: Fri, 21 Feb 2020 23:33:17 -0800 Subject: [PATCH 2/2] add comments so this can be found in task list --- test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs b/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs index f3c981cef4..9e9442e7fa 100644 --- a/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs +++ b/test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs @@ -58,6 +58,7 @@ public void TestDnnImageFeaturizer() { //skip running for x86 as this test using too much memory (over 2GB limit on x86) //and very like to hit memory related issue when running on CI + //TODO: optimized memory usage in related code and enable x86 test run if (!Environment.Is64BitProcess) return; @@ -133,6 +134,7 @@ public void TestOldSavingAndLoading() { //skip running for x86 as this test using too much memory (over 2GB limit on x86) //and very like to hit memory related issue when running on CI + //TODO: optimized memory usage in related code and enable x86 run if (!Environment.Is64BitProcess) return;