From c52de5b78163c625d7cb2a3b1e3b51b2db56c13a Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Mon, 14 Nov 2022 19:54:51 +0000 Subject: [PATCH 1/4] Do not copy files to build server for a Delete. --- msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs index fdd65a213ab1..19b40852ef48 100644 --- a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs +++ b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs @@ -25,5 +25,7 @@ public override bool Execute () return result; } + + public bool ShouldCopyToBuildServer (ITaskItem item) => false; } } From c9932f5937a318481ceb70ecb803d36e45105d53 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Tue, 15 Nov 2022 15:43:25 +0000 Subject: [PATCH 2/4] Implement the ITaskCallback interface --- msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs index 19b40852ef48..354938ba92d6 100644 --- a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs +++ b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs @@ -1,7 +1,7 @@ using Xamarin.Messaging.Build.Client; namespace Microsoft.Build.Tasks { - public class Delete : DeleteBase { + public class Delete : DeleteBase, ITaskCallback { public override bool Execute () { var result = base.Execute (); @@ -27,5 +27,7 @@ public override bool Execute () } public bool ShouldCopyToBuildServer (ITaskItem item) => false; + + public bool ShouldCreateOutputFile (ITaskItem item) => false; } } From 57806de48401b6eebbdb812b46044c619a8c09a8 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Tue, 15 Nov 2022 17:04:08 +0000 Subject: [PATCH 3/4] Add missing GetAdditionalItemsToBeCopied --- msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs index 354938ba92d6..d4b501040929 100644 --- a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs +++ b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs @@ -29,5 +29,7 @@ public override bool Execute () public bool ShouldCopyToBuildServer (ITaskItem item) => false; public bool ShouldCreateOutputFile (ITaskItem item) => false; + + public IEnumerable GetAdditionalItemsToBeCopied () => Enumerable.Empty (); } } From d77386bf054c3e0f565151f2ca6acb32e53ada55 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Wed, 16 Nov 2022 15:05:55 +0000 Subject: [PATCH 4/4] Add Missing namespaces --- msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs index d4b501040929..2885067f25c1 100644 --- a/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs +++ b/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs @@ -1,3 +1,6 @@ +using System.Collections.Generic; +using System.Linq; +using Microsoft.Build.Framework; using Xamarin.Messaging.Build.Client; namespace Microsoft.Build.Tasks {