From e5dca45cfa3eebee54655561eda10b111d8fe247 Mon Sep 17 00:00:00 2001 From: Vincent Dondain Date: Mon, 31 Jul 2017 13:34:51 -0400 Subject: [PATCH] [Don't Link] Update TableViewSourceTest's assert message - Remove obsolete and confusing warning in `UITableViewSource`. See https://github.com/xamarin/maccore/commit/59991815d5467e43505220fc4ebfe8f573849855 where UITableViewController started conforming to UITableViewDataSource, UITableViewDelegate removing the need to add all methods to UITableViewController. --- src/uikit.cs | 2 -- tests/linker-ios/dont link/TableViewSourceTest.cs | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/uikit.cs b/src/uikit.cs index 27c8090ae2bd..98fb4dff5a73 100644 --- a/src/uikit.cs +++ b/src/uikit.cs @@ -11341,8 +11341,6 @@ interface UITableViewSource { [Export ("indexPathForPreferredFocusedViewInTableView:")] [return: NullAllowed] NSIndexPath GetIndexPathForPreferredFocusedView (UITableView tableView); - - // WARNING: If you add more methods here, add them to UITableViewController as well. } [BaseType (typeof (UIView))] diff --git a/tests/linker-ios/dont link/TableViewSourceTest.cs b/tests/linker-ios/dont link/TableViewSourceTest.cs index 571804cd9cea..53803b494c55 100644 --- a/tests/linker-ios/dont link/TableViewSourceTest.cs +++ b/tests/linker-ios/dont link/TableViewSourceTest.cs @@ -28,7 +28,7 @@ namespace DontLink.UIKit { [Preserve (AllMembers = true)] public class TableViewSourceTest { - // UITableViewSource is MonoTouch specific and should include veverything from + // UITableViewSource is Xamarin.iOS specific and should include everything from // UITableViewDelegate and UITableViewDataSource - but it's easy to forget to // update its members (e.g. bug 8298 for iOS6 additions). @@ -52,7 +52,7 @@ public void ValidateMembers () methods.RemoveAll (delegate (string name) { return tvsource.Contains (name); }); - Assert.That (methods.Count, Is.EqualTo (0), "Incomplete bindings! " + String.Join (", ", methods)); + Assert.That (methods.Count, Is.EqualTo (0), "Incomplete bindings! Please add the following members to UITableViewSource: " + String.Join (", ", methods)); } } }