From 20ce177cfeb889a8c345a445862fc503d01f1bd3 Mon Sep 17 00:00:00 2001 From: Vincent Dondain Date: Sun, 22 May 2016 16:48:44 +0200 Subject: [PATCH] [msbuild] Remove empty UIDeviceRequiredCapabilities array Looks like Xcode isn't generating any UIDeviceRequiredCapabilities for watchOS 1 extensions. It used to have UIRequiredDeviceCapabilities = 'watch-companion' but that *might* not be required anymore. Commit 94e35a8570a52c5a927e24830b65a857a7986d8d on xamarin-macios/master comes from those same assumptions. Now regarding bug #41204: User is getting error "ERROR ITMS-90563: "Missing UIRequiredDeviceCapabilities value" when publish WatchKitCatalog sample. (https://bugzilla.xamarin.com/show_bug.cgi?id=41204) This might happen because we're still creating an empty array for the UIDeviceRequiredCapabilities key. In any case there's no need to create it. --- .../Tasks/CompileAppManifestTaskBase.cs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/msbuild/Xamarin.iOS.Tasks.Core/Tasks/CompileAppManifestTaskBase.cs b/msbuild/Xamarin.iOS.Tasks.Core/Tasks/CompileAppManifestTaskBase.cs index 34ee4d952e96..6816f6b3e227 100644 --- a/msbuild/Xamarin.iOS.Tasks.Core/Tasks/CompileAppManifestTaskBase.cs +++ b/msbuild/Xamarin.iOS.Tasks.Core/Tasks/CompileAppManifestTaskBase.cs @@ -177,13 +177,6 @@ bool Compile (PDictionary plist) SetDeviceFamily (plist); - if (IsWatchExtension) { - PObject capabilities; - - if (!plist.TryGetValue (ManifestKeys.UIRequiredDeviceCapabilities, out capabilities)) - plist[ManifestKeys.UIRequiredDeviceCapabilities] = capabilities = new PArray (); - } - plist.SetIfNotPresent (ManifestKeys.MinimumOSVersion, minimumOSVersion.ToString ()); // Remove any Xamarin Studio specific keys