From f234ef312673796d94964bc711dfe17dfb3c7b6c Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Thu, 6 Feb 2020 18:54:19 +0100 Subject: [PATCH] reflect the ConfigurationGroup -> Configuration change from runtime repo in the docs --- docs/benchmarking-workflow-dotnet-runtime.md | 4 ++-- docs/profiling-workflow-dotnet-runtime.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/benchmarking-workflow-dotnet-runtime.md b/docs/benchmarking-workflow-dotnet-runtime.md index f097eb2c531..ef9795411cd 100644 --- a/docs/benchmarking-workflow-dotnet-runtime.md +++ b/docs/benchmarking-workflow-dotnet-runtime.md @@ -122,7 +122,7 @@ dotnet run -c Release -f netcoreapp5.0 --filter $someFilter \ Once you rebuild the part of [dotnet/runtime](https://github.com/dotnet/runtime) you are working on, the appropriate `.dll` gets updated and the next time you run the benchmarks, CoreRun is going to load the updated library. ```cmd -C:\Projects\runtime\src\libraries\System.Text.RegularExpressions\src> dotnet msbuild /p:ConfigurationGroup=Release +C:\Projects\runtime\src\libraries\System.Text.RegularExpressions\src> dotnet msbuild /p:Configuration=Release ``` ## Preventing Regressions @@ -145,7 +145,7 @@ You can also create a **copy** of the folder with CoreRun and all the libraries After you introduce the changes and rebuild the part of [dotnet/runtime](https://github.com/dotnet/runtime) that you are working on **in Release** you should re-run the benchmarks. Remember to store the results in a different folder. ```cmd -C:\Projects\runtime\src\libraries\System.IO.Pipes\src> dotnet msbuild /p:ConfigurationGroup=Release +C:\Projects\runtime\src\libraries\System.IO.Pipes\src> dotnet msbuild /p:Configuration=Release C:\Projects\performance\src\benchmarks\micro> dotnet run -c Release -f netcoreapp5.0 \ --artifacts "C:\results\after" \ diff --git a/docs/profiling-workflow-dotnet-runtime.md b/docs/profiling-workflow-dotnet-runtime.md index d61515c3b40..08cc8fd1307 100644 --- a/docs/profiling-workflow-dotnet-runtime.md +++ b/docs/profiling-workflow-dotnet-runtime.md @@ -76,7 +76,7 @@ C:\Projects\runtime\artifacts\bin\testhost\netcoreapp5.0-Windows_NT-Release-x64\ Once you rebuild the part of [dotnet/runtime](https://github.com/dotnet/runtime) you are working on, the appropriate `.dll` gets updated and the next time you run profiler, dotnet|CoreRun is going to use the updated library. ```cmd -C:\Projects\runtime\src\libraries\System.Text.RegularExpressions\src> dotnet msbuild /p:ConfigurationGroup=Release +C:\Projects\runtime\src\libraries\System.Text.RegularExpressions\src> dotnet msbuild /p:Configuration=Release ``` ## Repro