From 8ee6073c014bc1db860a775788c6f1d5fe93b3da Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Wed, 24 Mar 2021 13:38:57 +0100 Subject: [PATCH 1/2] credentials - the second round --- .config/CredScanSuppressions.json | 31 ++++++++++++++---- .../TestDataCertificates/contoso.com.pfx | Bin 0 -> 5278 bytes .../testclient1_at_contoso.com.pfx | Bin 0 -> 5318 bytes 3 files changed, 24 insertions(+), 7 deletions(-) create mode 100644 src/System.Net.TestData/TestDataCertificates/contoso.com.pfx create mode 100644 src/System.Net.TestData/TestDataCertificates/testclient1_at_contoso.com.pfx diff --git a/.config/CredScanSuppressions.json b/.config/CredScanSuppressions.json index 382bd6d9c9..8f384b7ec7 100644 --- a/.config/CredScanSuppressions.json +++ b/.config/CredScanSuppressions.json @@ -1,9 +1,26 @@ { - "tool": "Credential Scanner", - "suppressions": [ - { - "file": [ "DummyTcpServer.pfx", "testclienteku.contoso.com.pfx", "testnoeku.contoso.com.pfx", "testselfsignedclienteku.contoso.com.pfx", "testselfsignedservereku.contoso.com.pfx", "testservereku.contoso.com.pfx", "DummyTcpServer.pfx", "My.pfx", "test.pfx", "contoso.com.pfx", "testclient1_at_contoso.com.pfx" ], - "_justification": "Testdata certs" - } - ] + "tool": "Credential Scanner", + "suppressions": [ + { + "file": [ + "contoso.com.pfx", + "DummyTcpServer.pfx", + "DummyTcpServer.pfx", + "My.noRC2.pfx", + "My.pfx", + "test.noRC2.pfx", + "test.pfx", + "testclient1_at_contoso.com.pfx", + "testclienteku.contoso.com.noRC2.pfx", + "testclienteku.contoso.com.pfx", + "testnoeku.contoso.com.noRC2.pfx", + "testnoeku.contoso.com.pfx", + "testselfsignedclienteku.contoso.com.pfx", + "testselfsignedservereku.contoso.com.pfx", + "testservereku.contoso.com.noRC2.pfx", + "testservereku.contoso.com.pfx" + ], + "_justification": "Testdata certs" + } + ] } \ No newline at end of file diff --git a/src/System.Net.TestData/TestDataCertificates/contoso.com.pfx b/src/System.Net.TestData/TestDataCertificates/contoso.com.pfx new file mode 100644 index 0000000000000000000000000000000000000000..c2fcf19856ad4ed15043ac6956684a34b6a039a6 GIT binary patch literal 5278 zcmY+GWmFVUx3Fhm92!JAB^^>4q=pVD0j0aUq(N%vE+vNsNf{dHlS$>!U|2#E9RQWb{Rxe>y!2vif=2^W(H!8Dm*4D;V*+Q;}qq6CX z!UT5kcNBlQ|CR04Od*F@Xz=`OznZUWhQP0g9olBK-n_&YNtXIUlEbf!E$>$K6SqrN ztvyP}ky7Qm{1l~B#pTlSc29`|A>7|jc{oZXb|MK{x-GM2Q>sPEHMLvm1&nvC#8VMF zwgTO^%rcSnSYYMrsF7G!Ect|W#oFIFBRt`vrbecdB&{~yh*7QhLJND;)@;!p{-3ep za!uo2xu?D3EI!f3nFK_n*f4&sDVA{q2A*^Q)OGP@ahA`f?k~(1F}@xK*I=k(2@ENw z6}8pp=6`(M?mhatjc&(U(}jF35|8w&^LtY6IJ=iKH^UIP!zlV7{iITtQ;I3bKMI*l zczbX%_ZQpoEuy;IK9;ic`t|j=iCi- zzC+TAMuP*Nft5t+IzHqo2P})dqHP!$(<5-LXGD>)ZU1ur3*zZ}jFNZCh+ELEr*dd) zMb;nSP@csSS!%rULG-$|t^uph`!-#XxL;K2bnXJ13tU+<@&2AIRat?KW3%$*cZXDz zoOnpyb_F;$1=ZgfB{pm~3hlRP`3s~oE}EzQ650g)dfH~YrZ4HYUiCBx)i9hijU=-d z-$}Xwv|ti1v%Cmi82>;vR{e-v{DwI3vH9bpY#zg6O&YYbFx9=z>t!=2qy3(rW7)Jt zbE7$$sIiDlqf5#1=2(xZ_#@S#i`2G{>-f1yrFMBE59=g{b*1)pgFgMnu8l+O;5?_f zq`_J+ncAw)P_h)-tJcR&(peFUU@17iEVqa-(T267Zi^R07d$s4DA@OC=piRki}d#V zq8a0)WMmQUS6FU&PDR*p)8b=QKKIq=%Kw+)m(nZNt~H(8R7EVdQpBXHp+JY&h8b}^?G@FgND|mE&NAlb0II#DamaY?!M(Qjh+YyV ziQ&5ubJ=5@JW>40b7h4gf?p1I1N=dov~Hl6)oMRnokYzoqCRVLln;io;C)pik2liArP(VkX;7w`jkC%fBj`&sUe%{`Ld?FSWcfX6{|v^j{NC0 z6B!rKe&T1wA({l9B&wBhIg{H1jmS>xBbOQRiKz0i7jf&_dkiA~WAZNr2@AXCbfQ^o zx{C&sR%{!))UIBi=E*WDb3 z7B<8yi(%7@V$8JL zN7)v{4~nW2Bc}8xIk~)Ylk<;jf$e%+fxnO!cg0S`^t_hRe`_MXP;aN8Vrxq|tIgP8P3IJ0YbC2A9ORUoktpCG|9 zZ8J^m5RUo@BR_hQ(aUd~|KfUh2Rp?pwYd`I+Ej8pk#Lt!MaZQ~CzIurpFh&TCh>Cg zd3+yq41KLv@y+`v%L@u;HXnn2x#ge+0kiyOC+v1(g`?k}aVQ9kP3HjqXi6)IB1-UN?hdiPY{m+d$2l_v0h7^9pr45C&nmk9!lB5;&x2)@z(pG*+!HUo)0oTW$nyR za*Yu$`xe=!lz;z|_B`s$DS~{AcUMJMCGSu@ZSxdy_`#^4D1>$sp)G`=~CRw8j`AFpE z!y?J0be@iE!Yy;G+xcx)y}cLgtbx|BhZkVR+f0Y%NO=q-c~?hJU(+Dr8AoIV$s*#^ zVd}$-**-l;z+F1_H+;uPTqQzSpL5_Ec^O;M4zZk@?2>UZadg|BDh{*eF(1g)_^4qL;^5IdYRP{Wt2NalCM*!AvADnxWUXtcD8+U< z=WrFI0!EWN7QC!=b^s5-4a~#Psi2^p8GwHk1q05?#v&YNec!jYh$6Bcf_H1MogEe{ zg2hT4k0G7CfpjayUKwo@m{}syltf!gJRkOHXK&8)rW0iKDZvG ziFf%90yw=YBxuRFo-Y&BmZEf)-O*KO)HAUrJ$L^_78qr0a@CBN$=n$z_Al#C<(9~M zVk(x{br~8wJ8vY>N|AU`IOAkfgLEuO6UywnTcl$W$GFP9W58IW4_2$u2Ln?P#bbb+ z;J#X>8kZXT9Ffn2K8Dgb4G4ZsZW8Q=tPeGW^2 z8-NDz@%j7@aRgXBS5nWpH^BLsIX%~(0VdD6^?yy#0960$p2u@#4zK`xeilKJ|9KS+ zoD0K5e?}k_AmG^sAO5!k{6As{{*M@nmS~Zw6FQvzM+^gD7!x;#Vm$J1l)@1@cKa4; zGw6a1ew*LGZz=b4MpSS)sBF28KVhlT-KvRhn(i8xx<2R~aQcdBePPY()OAS-opqZ` zNjZ=?!Ye4`*0*3Hpl=Ar0(4e{Yl|Y1$)}glfroFlFkK`_8TdQNO3dbaz1cjuw|vpo zDqH-PUQT)w;`_wN*JtZgkR+n5-sXBz-?MhfQmQh2Sd2-Ild~eMNdblV(QzKq5lG?F z5vQB*5J#NR6dEo;X=T1K#UY%0=DB(%XQ zC!d=Q_3t+Y$zi^^&ty#qgw8jVmIWkbipHhfOh}c){Ql5SdeT|kb$d6{CpX`+D_HNq z?R|yx@YQI-tzQ|(SQuqrN%HZ-3#3I!-<}{OK*ZQELl&kJKB?+zezcyUmp8u|Js364 zn7;WZNE!U$tbkpAPyOd5o~e3reul6hr0ebo!@iMvH8*}Rx$va~Ph#Hz!&g5G4hF6K zEOWSfMw4ZMPOch9tIHf}V-m#x7Je*n9E2N(JM@(FRg^J&NU+x|S;f2Ws4!mif{*?Y z3!rG?*z|W-%>moThS|4or?Y1eaQO*6P_%97HpKEu;Hd2hoj1F#)iw0ZvOxRdVbQn^ zIXZv&6RSWxL~4%AzY=jC5}CM2)=_VU7Pb|GW}uZvtK1&YQ_eRc(Q(`d3UPg?AcM*= z`dH_q9TXgB>VuLiPx$Ym_O8e*kLK%9AHEWDm{M_xwU7uciN9amsT>aqsoSPG3om$s zTY0r7NM9mM(A6nBOWiO3h6UPpgmv+?f9UgK4@rKwftR&iW0X|(BDx0ZkUEUB82<5` zH)c#DmSE3Ve~M;9`c@j|>>VMYfann35_4fMV7A1(v?ZPdOQDt?xM~Jyre>}3Zuai$ z?>O4jgoVMMWVgg4xD}Ld7}Y)uwM`z8u4!F7PFAsLLbD2+~BtnQq}n+6VC!=DWI=oRE0Nw_ix!oVNuFP zotQztQ3e1bI_8bjrVTumB0`y}g`Oa8d_hO-tZXcy6?30Q|7d|M(oXn)2o>p4iFoI% z?eA+t%Yh70k1Ar6FB%XGT>cV;R+!Z>u_km9j@+F|*db3X3Vlbx{Z#$P#*|h5JJwOE z3YT@F@_Gtn$Hoo8OhhIR)|X75JO_{h&Q$AM4Ec4~N!3aZzFk$|E7}Ap3L2P$j6m|kDIvbb`VC8l8PD?-e+M?c1CxW1 zH-7esPlZDbCS zO6&x&S>0!m!b^sc-mPFZy4B`~@ZRY)YuLM{^kW%Etv`_v)P$}`vrJr5#C?@+<0D>c z-+QwbQw$Dq<8KsE5-aG5-IJ5E(ZzM>gvZ#}ktVbzp?i>Q@!_DvNAN3m6r?&8>0PX| zLi9<)@E?CDTY&zC1(X{Hr9g`emSLnL90?6B|0&vz<@-(*Lss27HFl1ti0bDq3m;YB zgP%rxH|6|9Sdch(b^Aunl>iRb_ozjO)Of2ZJ_X5QWG$(5AFW^luY{q)WT99!~K21bdi zabnlKyS=w=9Sm?% zeb6CFu#0$2qGwjb;6^qXSvSo1YJ&6*+911?Kxh9`!=+ofk5ZLaNTo|J?)W1I;X}@$1bMFb4-?6^9K)!$DQxo9W(9U@$z9Umh z$i892@$AF0eoJWyld$cN+{4q~@|D)vzcV?0=*|Hg%M@%LJDGo);u#AjpygGCdljio}ct-@x@9b5aCgejCdl$>j*JzH-doTel-}n`y{C?c^p0f(dRuc3!rMF=R zrwy@uDy2Q^sBYkfmg;*r^sT@v9Sxq|x&(C~5)MCr=% zBS(y0j44&W4brBqscIFxa7LZsaC3ARku;A(yDuUCUA#aSK*@Pm%Ivsq!Xv_QlvQwn z*pxnoei#N?z`}P&YGGj8X{tElAkG!fGJD*k?y7TjcG;kZ9n<$;kO@WxYNKIA84P=d z6f!3-veq!FR~YT@58j%_k0$mLurT2r;Z_wK?TQJ$^ti->N;RR_{H zFfF{Y@P})i-`6ToU7Z(#cnMR_KW?2ou3|K;lY!?TX%HZ7Y+_(XY7O(A=m5-Z6s1)m zH7zh%cP(gQN9&Hb;rPC$+D>!Bmjo%xBb6{Y3Nf#@h5AHJ3fN9xQ7Es93-w=Q$Y=O9 z!8h+Xg*jhyqJdwq;-aFEg9zo!ze6e;vx)__NrzeqS*uwz(l4lp{}ICf2e%>YoB#j- literal 0 HcmV?d00001 diff --git a/src/System.Net.TestData/TestDataCertificates/testclient1_at_contoso.com.pfx b/src/System.Net.TestData/TestDataCertificates/testclient1_at_contoso.com.pfx new file mode 100644 index 0000000000000000000000000000000000000000..a86fc5dc4b11c62ddf285077d4cf3921391908c2 GIT binary patch literal 5318 zcmY+GbyyV8v#@vR?vQRla_LU#URagx5|E`k7wHfQkp?O0?q=y;N{nK|d*7X%~gM**UOU}V7<*qo87kvI52Okh5Y42lLLb9%=1AQ%qg|7qb6 zqrq_SpE34xpkv_v|1CTmAWA+AI~WAR_6N~o;QTj!ew+Xe>yjmugdfY>9t8z+1`UR7 zkkX9>kFJHAme@&-rO_AF?VRD0qUm8>(M`DYzsfE&bl2+?y#+Z=wg%U9_Me+SHn1Dx zlZ!7lU-+XjFf2OW-uL=^csrHUJBJQ4#IEfiEIO(;#Dx5K_?w-$z=-@~mQStB>-cf7 z-OUI1J8e=YT}=1>qVT7n>O?o!_&*x+flx9uTXPEMIGF64lL2>BP5S-M9q~>|UlQIB z$rqx=Wzp4-UxQf-dng=dS?4yGy>@xjxq<4Ww;tLE?5=sSIdzmHDmH?#My`}vdXnOP z){wuXF7TL1PWs^Vj&j=G%j1%hA+b^mNRqg6#STZ;#ogR-YBZqRnzJH5Aopr~XMv&u(QN>f>%JbGFAUkchmQrj{qamUh< zBEAHs$n0X*R&0Xtsi))BlCz0fpC3zYR*RbD==+~;1HzG+C24-R^@N>QGr!Ki%?%6D zQ!)JP%Kf|fvlSKLH+ziWc9IC7Qn%2*TC`^}_lL>9*Jp6a%rI>fHc|UwPZOiv?es`) z>~@KCNYUsZSS~?IR*NQVv3%{3In9+TYKchdDzLsrM<#c+{tm=waKtghvbyQ&d>dsG zUwjjrs%rWBahmUXk9%XgY( zq3N&(ByydU=9nyz9!|x)EF$+SPmfq=En-V6RhsB9hJ+L^BdHwqN1&K8j!xO<_Qb?k zB0EK_Ihb03O)i5=guVPA(Tj8b5p%e4TdDXoKV{3ul=N>V9)W2tZdLD=HDu!;TFt5L zjlkpn&}iJ|Nqi%l(OYHic59XOYdLWzX3Ig<2W z!zXKmzE_Wg%Iyqv0Nmv1g~n_fpum<~$BW6y`8z4fm+bSc7>uBq!og;98Ig36dgo>` zX2GmFf^CZ){(~po!e5m2Lh^drm@U2_qwI}~kU=EN#QM(t5ZVRw(}9Ix!2t@VzRr(! zyY-x}`yno(k-rMgw`+`khB?<;I7ciaR7lFl^f>=%at5?@s6ss!xpC+{C6TH0xS0H> zbL<{>8GQz&6ae}vaHpHmxQ}pw=2BN%==)FTC@!Xt@YgYG{If2X;@M1H#D}Mv=U8)> z(Rp4&%Nqi>W?F6jdy_F;k);*l^UJ1T*>47b%c>aTWEfU*$KGZaEbm)4hoq#Yu|bBt@>e_7kZY-skHddk)n9du zTL)Br^GTv24V{l45}zgEful?44@EdLJ;(=xhNnGlf(s8QynmPtUr23vvGjPiU5j6I z6SsulI*$0opS@`e!<92E!?wPqzui&gmsuXL6cry#Q;c}UNQfGMnvOPu17BaGrd=ffU|7}v1GK!Z_r+mjX{AhA@m z{_@74x$OyqMdq&2MqNPaZWPg9`>cS=+44*|_3|Zy9$@t|kUl>@J#l)Hu#}6A&(fuqxRo*z-%C5az5m0$3!z4vBeQ+2akIy#tVW5t z-x;BtAbpl`mlFYLMR%Nt&TXLaAd%DRKPVQ6OS79lZQA=??<35x-MLV?gHBU}H$(TC z@%yhoq9lEtbNRtaKSqTN+S$J#)O`Jgt`x5(AkD+}?(d*Gr)UQ(7~#_Pe|T9|_cGE3 z=@e(i_(RN?e#pn7MZ5&zYAsbLu?sW~&P(i6(%$3C_iS|~^}i6da5n&1$u64&vK>Q+ zsZ5W1VT%MR*Ty;$Ih^YvxzY7&(s%ztMk*IutBGU4lAPIHZv%TKLK%_QO?rmklrLoj zcM^rLfNo{=Vos|oHI|`rzOa9u%AMLxbF>1OE8zg&gbZq3Kfi!lI$^%TX0^i3$PB4{ znvgWyOB8Rl#E$SQX^k6sEg8=fyx{rW6rC?m39>!nL#q}gm4PV9&%mj zO!9|f|NU~~T&Sj8_>qV(Pq9CE)hrBG50Hw3KwyN?PdmsOnlkuJkp#9TyH<6N0iAmO zD#?8{w33xJa?Qy3Q0w|#(viHf_!6oxvvJ(yw8Mb6a} zFrM$#!8>JV{`gx|IQF%Mm0e+m0Uoxd`veiCBk9UuZOnKTW*IkwyzepCV5Cpp>|NUg zp4E`uu0{;fJF)n*rpeg7AFUYLb-j>U{iS_ho4TU_!5Zf{WT;>FBz^4cgtCzS_2M>y zRzE&zq!Q}FxcyaoSgR$jyKnLdt=bC16CEEbLminJAulw;p6+QBrnw|dT)-H=Ud+2> z{OcF8Jd$r+!{%a@S51tO4!-D8S=6>;Rqs zMu7hF`5)o}uz#*zKj(e`*JlQOuH6Ba&$+{YZ7~9L|7*_sxv~M+0^FZPQ1*X*#l*;m z;eehIHwqB&e6js+2l#))5aT~$=uR4hYiF4g{2wt4g<;1D;r9Ff)s9wa z!--SlNp3;djw2MqVSf5`{e0qrTLlrb*`sj5(Se zQATMkkQSa!;u=bxLrAOzQ3$)TU&=tMTWGd3RNcyxChW@gqnG?hSH>K0Ns#W6QDy(v zKDIUCGW~6;?X;;W6|= z=k@c2M(9v@s%LST&!GRyqSaZU2k7K_#?#L>^)k_!ivV+w;;0Gxnns=dB&O(a@l74! ziNC;ZDT_KjrG@ApHx%4tPY8pt+P6ohFaq3YQ7ORm#G;yT!?T^ zj<}LYowRIQe=Lo}8{-x1O?KN|d-)wqpxMSR>yaZ&;WJuGMtczy3J04~j+2v$!uV{6 z6Hk=c_c*a{^E|j!Ug;xBpQi5aIpm&XNHp5YJVOZc3I2eSzS*A1UsIYy&q3@YS@24g zISVllzlCsgt9(%lNWqt<84=vks~91Zesk+l1DOiqQeWc;!-`0U6A4uhq0c$a^(G7@ z@`8420t{Di!XVMIK z;dOr6cfVde8ow+ggP6M9gijY*bVgQ0pO8IP=ylPEyMtJiUnobwB5Bw5}vgIr(B%QiQSZ^j8C zm*>BzgKB>8^FgK?3o?G*Dk$zY#?KM~y$zR!7EUsWXX5wrHzoMOn{f8>wD^%Wm|Ndw zF`~t7`??8>U2pxClgx{bi}pUmVc!ir=0qlNtg?;z2Iblkj1~mx^NDO4M>ewmyJmJS ziu>D5IO(DN>bS331~J};b3@v?yHLiaUBpUrV77#_mW#yG0MS=3=6(90Nz8`b8~ub# ze_=q#1dqC&!CiIDwGi8vmr%&7#(C8zQtjz1A$4U+eEYGiO4*fsVH-hGnr(>Ql7Qcd z_Ce=QmTzcV2}$hA39~WoJDpUCpKnmxqakWpzFJ7Az0@E~`u@CQNg1L0p;iGUfI6p> zrvKya0mA0No&LMoS1JKKxJX8WJqb;P!rm>VjAkc#WMMdq=n{Mf(FxRuZJiTxf&*r5^Jd*|9WxDVB zzv&Q;kk0o`!;xO<|3EfhPO-;laMD~^YcS-!qb}O%A>eY&0tY@;U1ztgWIyFEeq6uF zd$SjJE*}_d25jxww|j0PFU*EwO=4U6iCJvjF0kzectQy2miw%}&gwD3i`tlY%0% zSw;(9UfGYj@g|_68)8qH4D&Ei4)=iZcNN5pOvBA+qABD4lJGb;Hh=)goGUogF2wp$ zq-TX7g+j#v@<_m+FPlv)RGkWuScogySD6cxk=3PxD*$(0^cs(_&dJlO)@YsrrcZ86x(X$?H)a206zq* z5V?1sn@iAMdF%Bv_(S`T(i-xS*xf(;=lCL$zMaG^OR{Bw{T@%$Lt$;wLP_Ll)7oaK zj^1kMA*bUUDwjHk_j`?Rhj`P9jpNv5Yi*-^*GzggHghiFYKoqQ^PN5PT0|_{=_WC={YH-d*bR3p|u&wJUV`N(iQVNUjU{3WJ|FJuAKYg> z*l#)UZ4UE_<8ec3W9bl^!Tv~M*2S2GK?mCx!Qc$5_q?>9mOcPzs!|4;a9jcRsse3j ze_tVdhy@Q#xE|{in?WJ@CU0n(%mpy~nlO&tbK`e9zK8>WVe?iLEI7YEl||nbGldP7 zxF>SIQ}?OL+LC0}{7u502YU#19+FA@rRV-HP}FBSZPyQd{BBlFX(_il_$cbd&hM3n zC$)t2cn5_S#Fv6rJ^Gy& Date: Wed, 24 Mar 2021 16:10:17 +0100 Subject: [PATCH 2/2] Change justification --- .config/CredScanSuppressions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.config/CredScanSuppressions.json b/.config/CredScanSuppressions.json index 8f384b7ec7..2f9b538d1e 100644 --- a/.config/CredScanSuppressions.json +++ b/.config/CredScanSuppressions.json @@ -20,7 +20,7 @@ "testservereku.contoso.com.noRC2.pfx", "testservereku.contoso.com.pfx" ], - "_justification": "Testdata certs" + "_justification": "Approved exemptions" } ] } \ No newline at end of file