[mono][debugger] Fix inspect gchandle#102637
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @thaystg |
lewing
reviewed
May 24, 2024
Member
lewing
left a comment
There was a problem hiding this comment.
Is there any chance we need to handle I4 here too for 32 bit runtimes?
Member
Author
I don't think so, we are always sending it as a long value: runtime/src/mono/mono/component/debugger-agent.c Line 5282 in fc5b6e7 Also every PTR we always send as a long value: runtime/src/mono/mono/component/debugger-agent.c Line 5157 in fc5b6e7 |
Member
Author
|
Can I get a review? |
lewing
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are not sending IntPtr as ValueType anymore because it was causing an infinity recursion because IntPtr has a field pointing to itself. So we need support receiving the IntPtr as I8.
Without the PR:


New Debugger Engine:
Old Debugger Engine:
With the PR:


New Debugger Engine:
Old Debugger Engine: