From f53ee469ac446f967d10a6a86d02941fbe71d2d7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 19:24:43 +0000 Subject: [PATCH 1/8] Initial plan From c9a7bf58534d224d06d539c77401c5a37f71ca07 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 19:57:14 +0000 Subject: [PATCH 2/8] Remove parent Directory.Build.props import from test assets These test assets should use SDK defaults instead of repo defaults. - Set ImportDirectoryBuildProps=false to prevent automatic parent import - Define necessary properties locally (NetCoreAppCurrent, paths, etc.) - Keep Directory.Build.targets imports for local runtime targeting Co-authored-by: agocke <515774+agocke@users.noreply.github.com> --- .../Assets/Projects/Directory.Build.props | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/installer/tests/Assets/Projects/Directory.Build.props b/src/installer/tests/Assets/Projects/Directory.Build.props index 2d331dfb98451d..715d4f708be28d 100644 --- a/src/installer/tests/Assets/Projects/Directory.Build.props +++ b/src/installer/tests/Assets/Projects/Directory.Build.props @@ -1,6 +1,26 @@ - + + + false + + + + + + $([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', '..', '..', '..', '..', '..')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'eng')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'artifacts')) + + + + + + 10.0 + net$(NetCoreAppCurrentVersion) + + true true From 8ca13f76cdcefd3bdb05dbef928c0eedd57e5d35 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 20:10:10 +0000 Subject: [PATCH 3/8] Add clarifying comment about intentional hard-coded path Co-authored-by: agocke <515774+agocke@users.noreply.github.com> --- src/installer/tests/Assets/Projects/Directory.Build.props | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/installer/tests/Assets/Projects/Directory.Build.props b/src/installer/tests/Assets/Projects/Directory.Build.props index 715d4f708be28d..1a21a76cc07ea5 100644 --- a/src/installer/tests/Assets/Projects/Directory.Build.props +++ b/src/installer/tests/Assets/Projects/Directory.Build.props @@ -7,7 +7,9 @@ - + $([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', '..', '..', '..', '..', '..')) $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'eng')) $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'artifacts')) From 9dfe47aa950817874d1049a216f498fbba82cc7b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 00:14:02 +0000 Subject: [PATCH 4/8] Define TestTfm property and use it in all test asset projects - Added TestTfm property to Directory.Build.props (set to NetCoreAppCurrent) - Updated all test asset projects to use $(TestTfm) instead of $(NetCoreAppCurrent) or hardcoded target frameworks - This fixes the issue where SelfContained.csproj was using outdated net6.0 target framework Co-authored-by: agocke <515774+agocke@users.noreply.github.com> --- .../AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj | 2 +- .../tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj | 2 +- .../AppWithUnknownLanguageResource.csproj | 2 +- .../tests/Assets/Projects/AppWithWait/AppWithWait.csproj | 2 +- .../tests/Assets/Projects/ComLibrary/ComLibrary.csproj | 2 +- .../ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj | 2 +- .../Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj | 2 +- src/installer/tests/Assets/Projects/Component/Component.csproj | 2 +- src/installer/tests/Assets/Projects/Directory.Build.props | 2 ++ .../Assets/Projects/HammerServicing/HammerServicing.csproj | 2 +- .../tests/Assets/Projects/HelloWorld/HelloWorld.csproj | 2 +- .../HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" | 2 +- .../tests/Assets/Projects/HelloWorld/SelfContained.csproj | 2 +- .../Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj | 2 +- .../tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj | 2 +- .../tests/Assets/Projects/ManagedHost/ManagedHost.csproj | 2 +- .../tests/Assets/Projects/ManagedHost/RegFreeCom.csproj | 2 +- .../Assets/Projects/ServicedLibrary/ServicedLibrary.csproj | 2 +- .../tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj | 2 +- .../Projects/SingleFileApiTests/SingleFileApiTests.csproj | 2 +- .../tests/Assets/Projects/StartupHook/StartupHook.csproj | 2 +- .../StartupHookWithAssemblyResolver.csproj | 2 +- .../Assets/Projects/WindowsSpecific/WindowsSpecific.csproj | 2 +- 23 files changed, 24 insertions(+), 22 deletions(-) diff --git a/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj b/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj index 585d09a13a809e..bbb3d5e6b2ad53 100644 --- a/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj +++ b/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj b/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj index 0bf7fe92f94437..11b9fa3d5a57ea 100644 --- a/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj +++ b/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj b/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj index 4b68943005e42d..a0de933719fa3e 100644 --- a/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj +++ b/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe test.res diff --git a/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj b/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj index e71444bd29bbfe..43fb8fce09c09e 100644 --- a/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj +++ b/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj b/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj index 2e38ad45709bf0..bd699cfc9ab375 100644 --- a/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj +++ b/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) true 1.0.0 diff --git a/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj b/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj index 77439bfe0c2fe6..7af58ddcf31e77 100644 --- a/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj +++ b/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) diff --git a/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj b/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj index 77439bfe0c2fe6..7af58ddcf31e77 100644 --- a/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj +++ b/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) diff --git a/src/installer/tests/Assets/Projects/Component/Component.csproj b/src/installer/tests/Assets/Projects/Component/Component.csproj index d56cb42d7259e5..98d3c6d5b55c8f 100644 --- a/src/installer/tests/Assets/Projects/Component/Component.csproj +++ b/src/installer/tests/Assets/Projects/Component/Component.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) true diff --git a/src/installer/tests/Assets/Projects/Directory.Build.props b/src/installer/tests/Assets/Projects/Directory.Build.props index 1a21a76cc07ea5..16c0d667bef539 100644 --- a/src/installer/tests/Assets/Projects/Directory.Build.props +++ b/src/installer/tests/Assets/Projects/Directory.Build.props @@ -20,6 +20,8 @@ 10.0 net$(NetCoreAppCurrentVersion) + + $(NetCoreAppCurrent) diff --git a/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj b/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj index d3fe43c68503f2..ba972d4a3af536 100644 --- a/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj +++ b/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj index a600aa229c5ec8..572f26a31301d2 100644 --- a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj +++ b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git "a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" "b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" index a600aa229c5ec8..572f26a31301d2 100644 --- "a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" +++ "b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj b/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj index d2014e98987476..838d8034c7747d 100644 --- a/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj +++ b/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj @@ -1,7 +1,7 @@ HelloWorld - net6.0 + $(TestTfm) Exe true true diff --git a/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj b/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj index 83ed0728c93e6e..3a48b01b98fe41 100644 --- a/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj +++ b/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe WINDOWS;$(DefineConstants) true diff --git a/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj b/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj index 220da64fcfd772..c0dde4dd002b49 100644 --- a/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj +++ b/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj b/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj index 1497ab6b853216..dc973603d04817 100644 --- a/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj +++ b/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj @@ -2,7 +2,7 @@ Exe - $(NetCoreAppCurrent) + $(TestTfm) true diff --git a/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj b/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj index 6da1dcc13ccc1e..5006b751e454c7 100644 --- a/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj +++ b/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj @@ -2,7 +2,7 @@ Exe - $(NetCoreAppCurrent) + $(TestTfm) true App.manifest diff --git a/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj b/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj index 3347900cb283cf..666ec5d1bdf0f6 100644 --- a/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj +++ b/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj @@ -2,7 +2,7 @@ SharedLibrary - $(NetCoreAppCurrent) + $(TestTfm) Library diff --git a/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj b/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj index d1faceadaa7e4e..4af67967363bfb 100644 --- a/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj +++ b/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Library diff --git a/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj b/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj index e71444bd29bbfe..43fb8fce09c09e 100644 --- a/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj +++ b/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) Exe diff --git a/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj b/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj index 77439bfe0c2fe6..7af58ddcf31e77 100644 --- a/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj +++ b/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) diff --git a/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj b/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj index 77240eabc1c858..623d9a9b3b49f2 100644 --- a/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj +++ b/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent) + $(TestTfm) - false - - 10.0 - net$(NetCoreAppCurrentVersion) - - $(NetCoreAppCurrent) + net$(NetCoreAppCurrentVersion) + + $(TestTfm) From f6d31632890d9673342a2118031063de9b6d4062 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 04:36:48 +0000 Subject: [PATCH 6/8] Use NetCoreAppCurrent instead of TestTfm in all projects - Removed TestTfm property from Directory.Build.props - NetCoreAppCurrent is now the primary target framework property - Updated all 22 test asset projects to use $(NetCoreAppCurrent) Co-authored-by: agocke <515774+agocke@users.noreply.github.com> --- .../AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj | 2 +- .../Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj | 2 +- .../AppWithUnknownLanguageResource.csproj | 2 +- .../tests/Assets/Projects/AppWithWait/AppWithWait.csproj | 2 +- .../tests/Assets/Projects/ComLibrary/ComLibrary.csproj | 2 +- .../ComLibraryConflictingGuid.csproj | 2 +- .../ComLibraryMissingGuid/ComLibraryMissingGuid.csproj | 2 +- .../tests/Assets/Projects/Component/Component.csproj | 2 +- src/installer/tests/Assets/Projects/Directory.Build.props | 4 +--- .../Assets/Projects/HammerServicing/HammerServicing.csproj | 2 +- .../tests/Assets/Projects/HelloWorld/HelloWorld.csproj | 2 +- .../HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" | 2 +- .../tests/Assets/Projects/HelloWorld/SelfContained.csproj | 2 +- .../Projects/HostApiInvokerApp/HostApiInvokerApp.csproj | 2 +- .../tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj | 2 +- .../tests/Assets/Projects/ManagedHost/ManagedHost.csproj | 2 +- .../tests/Assets/Projects/ManagedHost/RegFreeCom.csproj | 2 +- .../Assets/Projects/ServicedLibrary/ServicedLibrary.csproj | 2 +- .../tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj | 2 +- .../Projects/SingleFileApiTests/SingleFileApiTests.csproj | 2 +- .../tests/Assets/Projects/StartupHook/StartupHook.csproj | 2 +- .../StartupHookWithAssemblyResolver.csproj | 2 +- .../Assets/Projects/WindowsSpecific/WindowsSpecific.csproj | 2 +- 23 files changed, 23 insertions(+), 25 deletions(-) diff --git a/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj b/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj index bbb3d5e6b2ad53..585d09a13a809e 100644 --- a/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj +++ b/src/installer/tests/Assets/Projects/AppWithCustomEntryPoints/AppWithCustomEntryPoints.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj b/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj index 11b9fa3d5a57ea..0bf7fe92f94437 100644 --- a/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj +++ b/src/installer/tests/Assets/Projects/AppWithSubDirs/AppWithSubDirs.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj b/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj index a0de933719fa3e..4b68943005e42d 100644 --- a/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj +++ b/src/installer/tests/Assets/Projects/AppWithUnknownLanguageResource/AppWithUnknownLanguageResource.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe test.res diff --git a/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj b/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj index 43fb8fce09c09e..e71444bd29bbfe 100644 --- a/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj +++ b/src/installer/tests/Assets/Projects/AppWithWait/AppWithWait.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj b/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj index bd699cfc9ab375..2e38ad45709bf0 100644 --- a/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj +++ b/src/installer/tests/Assets/Projects/ComLibrary/ComLibrary.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) true 1.0.0 diff --git a/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj b/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj index 7af58ddcf31e77..77439bfe0c2fe6 100644 --- a/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj +++ b/src/installer/tests/Assets/Projects/ComLibraryConflictingGuid/ComLibraryConflictingGuid.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) diff --git a/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj b/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj index 7af58ddcf31e77..77439bfe0c2fe6 100644 --- a/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj +++ b/src/installer/tests/Assets/Projects/ComLibraryMissingGuid/ComLibraryMissingGuid.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) diff --git a/src/installer/tests/Assets/Projects/Component/Component.csproj b/src/installer/tests/Assets/Projects/Component/Component.csproj index 98d3c6d5b55c8f..d56cb42d7259e5 100644 --- a/src/installer/tests/Assets/Projects/Component/Component.csproj +++ b/src/installer/tests/Assets/Projects/Component/Component.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) true diff --git a/src/installer/tests/Assets/Projects/Directory.Build.props b/src/installer/tests/Assets/Projects/Directory.Build.props index 29d2bf9369e977..dc9dc81d39bae8 100644 --- a/src/installer/tests/Assets/Projects/Directory.Build.props +++ b/src/installer/tests/Assets/Projects/Directory.Build.props @@ -13,9 +13,7 @@ 10.0 - net$(NetCoreAppCurrentVersion) - - $(TestTfm) + net$(NetCoreAppCurrentVersion) diff --git a/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj b/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj index ba972d4a3af536..d3fe43c68503f2 100644 --- a/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj +++ b/src/installer/tests/Assets/Projects/HammerServicing/HammerServicing.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj index 572f26a31301d2..a600aa229c5ec8 100644 --- a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj +++ b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git "a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" "b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" index 572f26a31301d2..a600aa229c5ec8 100644 --- "a/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" +++ "b/src/installer/tests/Assets/Projects/HelloWorld/HelloWorld_\344\270\255\346\226\207.csproj" @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj b/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj index 838d8034c7747d..b1a478e36efd99 100644 --- a/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj +++ b/src/installer/tests/Assets/Projects/HelloWorld/SelfContained.csproj @@ -1,7 +1,7 @@ HelloWorld - $(TestTfm) + $(NetCoreAppCurrent) Exe true true diff --git a/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj b/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj index 3a48b01b98fe41..83ed0728c93e6e 100644 --- a/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj +++ b/src/installer/tests/Assets/Projects/HostApiInvokerApp/HostApiInvokerApp.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe WINDOWS;$(DefineConstants) true diff --git a/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj b/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj index c0dde4dd002b49..220da64fcfd772 100644 --- a/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj +++ b/src/installer/tests/Assets/Projects/LocalizedApp/LocalizedApp.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj b/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj index dc973603d04817..1497ab6b853216 100644 --- a/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj +++ b/src/installer/tests/Assets/Projects/ManagedHost/ManagedHost.csproj @@ -2,7 +2,7 @@ Exe - $(TestTfm) + $(NetCoreAppCurrent) true diff --git a/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj b/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj index 5006b751e454c7..6da1dcc13ccc1e 100644 --- a/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj +++ b/src/installer/tests/Assets/Projects/ManagedHost/RegFreeCom.csproj @@ -2,7 +2,7 @@ Exe - $(TestTfm) + $(NetCoreAppCurrent) true App.manifest diff --git a/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj b/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj index 666ec5d1bdf0f6..3347900cb283cf 100644 --- a/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj +++ b/src/installer/tests/Assets/Projects/ServicedLibrary/ServicedLibrary.csproj @@ -2,7 +2,7 @@ SharedLibrary - $(TestTfm) + $(NetCoreAppCurrent) Library diff --git a/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj b/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj index 4af67967363bfb..d1faceadaa7e4e 100644 --- a/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj +++ b/src/installer/tests/Assets/Projects/SharedLibrary/SharedLibrary.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Library diff --git a/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj b/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj index 43fb8fce09c09e..e71444bd29bbfe 100644 --- a/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj +++ b/src/installer/tests/Assets/Projects/SingleFileApiTests/SingleFileApiTests.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) Exe diff --git a/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj b/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj index 7af58ddcf31e77..77439bfe0c2fe6 100644 --- a/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj +++ b/src/installer/tests/Assets/Projects/StartupHook/StartupHook.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) diff --git a/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj b/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj index 623d9a9b3b49f2..77240eabc1c858 100644 --- a/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj +++ b/src/installer/tests/Assets/Projects/StartupHookWithAssemblyResolver/StartupHookWithAssemblyResolver.csproj @@ -1,7 +1,7 @@ - $(TestTfm) + $(NetCoreAppCurrent) @@ -14,6 +26,9 @@ 10.0 net$(NetCoreAppCurrentVersion) + + annotations + false From f11d4888b3379ecac837bec56097aa8006c390e3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Jul 2026 21:36:46 +0000 Subject: [PATCH 8/8] Derive NetCoreAppCurrentVersion from eng/Versions.props instead of hardcoding Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com> --- .../tests/Assets/Projects/Directory.Build.props | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/installer/tests/Assets/Projects/Directory.Build.props b/src/installer/tests/Assets/Projects/Directory.Build.props index caf19155b048a6..00ec8bf7777050 100644 --- a/src/installer/tests/Assets/Projects/Directory.Build.props +++ b/src/installer/tests/Assets/Projects/Directory.Build.props @@ -10,6 +10,15 @@ $([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'bin')) + + + + + + $(MajorVersion).$(MinorVersion) + net$(NetCoreAppCurrentVersion) + + $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'microsoft.netcore.app.ref')) $([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRefPackDir)', 'ref', '$(NetCoreAppCurrent)')) @@ -21,11 +30,7 @@ $([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRuntimePackRidDir)', 'native')) - - - 10.0 - net$(NetCoreAppCurrentVersion) annotations false