From 3d1ef3bc55d515dc93d16003bcbbf034aafee5db Mon Sep 17 00:00:00 2001 From: ManickaP Date: Tue, 17 Feb 2026 18:38:35 +0100 Subject: [PATCH 1/2] Re-enable GetAsync_UnicodeHostName_SuccessStatusCodeInResponse test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The external Korean Starbucks website (스타벅스코리아.com / xn--oy2b35ckwhba574atvuzkc.com) that was unreachable in 2019 is now accessible again. Remove the ActiveIssue attribute to re-enable the test, keeping the original test logic that exercises the full Unicode hostname to punycode IDN conversion path. Fixes https://github.com/dotnet/runtime/issues/29424 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Common/tests/System/Net/Http/HttpClientHandlerTest.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs index b18dd83dcbeb71..6d8f1599f66b11 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs @@ -1528,9 +1528,14 @@ await server.AcceptConnectionSendCustomResponseAndCloseAsync( [OuterLoop("Uses external servers")] [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/29424")] public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse() { + // The site doesn't support HTTP/3. + if (UseVersion == HttpVersion30) + { + return; + } + using (HttpClient client = CreateHttpClient()) { // international version of the Starbucks website From 31bc684617a3f3bdfe20b10b47242e1f03fadfd2 Mon Sep 17 00:00:00 2001 From: ManickaP Date: Mon, 23 Feb 2026 14:19:55 +0100 Subject: [PATCH 2/2] Remove GetAsync_UnicodeHostName_SuccessStatusCodeInResponse test The external Korean Starbucks website used by this test is unreliable, making it unsuitable for CI. Delete the test entirely rather than keeping it disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../System/Net/Http/HttpClientHandlerTest.cs | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs index 6d8f1599f66b11..4f944461278d6e 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs @@ -1526,27 +1526,6 @@ await server.AcceptConnectionSendCustomResponseAndCloseAsync( }); } - [OuterLoop("Uses external servers")] - [Fact] - public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse() - { - // The site doesn't support HTTP/3. - if (UseVersion == HttpVersion30) - { - return; - } - - using (HttpClient client = CreateHttpClient()) - { - // international version of the Starbucks website - // punycode: xn--oy2b35ckwhba574atvuzkc.com - string server = "http://\uc2a4\ud0c0\ubc85\uc2a4\ucf54\ub9ac\uc544.com"; - using (HttpResponseMessage response = await client.GetAsync(server)) - { - response.EnsureSuccessStatusCode(); - } - } - } #region Post Methods Tests