Skip to content

[DO NOT MERGE] Install Scripts Update Validation PR#128377

Closed
ellahathaway wants to merge 1 commit into
mainfrom
validate-install-scripts/9c8552ae
Closed

[DO NOT MERGE] Install Scripts Update Validation PR#128377
ellahathaway wants to merge 1 commit into
mainfrom
validate-install-scripts/9c8552ae

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

This PR validates install script changes from dotnet/install-scripts commit 9c8552ae791982d3674fbb4d6ad887e536e7f506.

Do not merge this PR. It will be closed once CI passes.

Install scripts commit: dotnet/install-scripts@9c8552a

Changes:

  • eng/common/tools.sh: Points to test install script
  • eng/common/tools.ps1: Points to test install script

Copilot AI review requested due to automatic review settings May 19, 2026 16:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Code Review — PR #128377

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: This is a CI validation PR for install script changes from dotnet/install-scripts. The PR description clearly states it should not be merged and will be closed once CI passes. This is a standard workflow for validating install script updates before they are promoted.

Approach: The change temporarily redirects the install script download URLs from the official builds.dotnet.microsoft.com endpoint to a raw GitHub content URL pointing at a specific commit (9c8552ae791982d3674fbb4d6ad887e536e7f506). This is the expected pattern for validation PRs.

Summary: ✅ LGTM. This is a standard install-scripts validation PR. The changes are minimal, scoped correctly, and clearly marked as DO NOT MERGE. Both tools.ps1 and tools.sh are updated consistently to the same commit hash.


Detailed Findings

✅ Consistency — Both scripts point to the same commit

Both eng/common/tools.ps1 and eng/common/tools.sh reference the same commit SHA (9c8552ae791982d3674fbb4d6ad887e536e7f506), ensuring consistent behavior across Windows and Linux CI.

✅ Scope — Changes are minimal and focused

Only the URL strings are changed (one line each in two files). No other modifications are present.

💡 Reminder — Do not merge

As stated in the PR description, this should be closed after CI validates successfully. The eng/common directory is synced from dotnet/arcade and should not carry manual modifications long-term.

Generated by Code Review for issue #128377 · ● 1.5M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants