From 045730d429824b43c1645db819f5d65d069b051d Mon Sep 17 00:00:00 2001 From: Radek Doulik Date: Thu, 11 Jun 2026 17:56:12 +0200 Subject: [PATCH 1/4] Re-enable EventSource ActivityTracking tests on browser+CoreCLR These four tests pass on browser+CoreCLR; the issue #123011 ActiveIssue was a bulk disable when bootstrapping the platform and is no longer needed. Re-enabled: - StartStopCreatesActivity - ActivityFlowsAsync - SetCurrentActivityIdBeforeEventFlowsAsync - SetCurrentActivityIdAfterEventDoesNotFlowAsync Verified with WasmTestOnChrome (5 passed, 0 failed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../tests/BasicEventSourceTest/ActivityTracking.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/ActivityTracking.cs b/src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/ActivityTracking.cs index 398f13a64be4b5..d467ed3a7e5180 100644 --- a/src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/ActivityTracking.cs +++ b/src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/ActivityTracking.cs @@ -52,7 +52,6 @@ public void IsSupported() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))] public void StartStopCreatesActivity() { @@ -69,7 +68,6 @@ public void StartStopCreatesActivity() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))] public async Task ActivityFlowsAsync() { @@ -119,7 +117,6 @@ private async Task YieldTwoActivitiesDeep(ActivityEventSource es) // the future we might decide it wasn't even desirable to begin with. // Compare with SetCurrentActivityIdAfterEventDoesNotFlowAsync below. [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))] public async Task SetCurrentActivityIdBeforeEventFlowsAsync() { @@ -146,7 +143,6 @@ public async Task SetCurrentActivityIdBeforeEventFlowsAsync() // the future we might decide it wasn't even desirable to begin with. // Compare with SetCurrentActivityIdBeforeEventFlowsAsync above. [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))] public async Task SetCurrentActivityIdAfterEventDoesNotFlowAsync() { From efe95fafc36defa27513cd46bda773fce20ecc17 Mon Sep 17 00:00:00 2001 From: Radek Doulik Date: Thu, 11 Jun 2026 17:59:31 +0200 Subject: [PATCH 2/4] Re-enable dynamic (DLR) conformance tests on browser+CoreCLR The C# 'dynamic' binder works on browser+CoreCLR. These nine pure [Fact] DynamicCSharpRunTest cases pass once the bulk issue #123011 ActiveIssue is removed. GC-gated conformance cases in the same files (ConditionalFact(IsPreciseGcSupported), which rely on finalizers) are left disabled. Verified with WasmTestOnChrome (9 passed, 0 failed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Conformance.dynamic.context.indexer.regclass.cs | 2 -- .../Conformance.dynamic.context.method.genmethod.regclass.cs | 2 -- .../Conformance.dynamic.context.operator.regclass.cs | 4 ---- ...formance.dynamic.context.property.autoproperty.regclass.cs | 1 - 4 files changed, 9 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.regclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.regclass.cs index 3ef564bf89e0f6..e5c3fd3d04a68c 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.regclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.regclass.cs @@ -1007,7 +1007,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.indexer.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -2296,7 +2295,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.indexer.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.method.genmethod.regclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.method.genmethod.regclass.cs index 43a625317651ef..dd937bf73cbdd7 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.method.genmethod.regclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.method.genmethod.regclass.cs @@ -224,7 +224,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.method.genmetho public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -976,7 +975,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.method.genmetho public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.operator.regclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.operator.regclass.cs index 17734cbb1c86a8..a318c893e266c4 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.operator.regclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.operator.regclass.cs @@ -680,7 +680,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -719,7 +718,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -1843,7 +1841,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -3497,7 +3494,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.property.autoproperty.regclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.property.autoproperty.regclass.cs index 30f0744bd0a6ad..cea956777a0531 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.property.autoproperty.regclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.property.autoproperty.regclass.cs @@ -259,7 +259,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.property.autopr public class Test { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); From e14b7b42cf2c7e0befb60e9d5c25a6bd40935725 Mon Sep 17 00:00:00 2001 From: Radek Doulik Date: Thu, 11 Jun 2026 18:00:32 +0200 Subject: [PATCH 3/4] Re-enable Environment.ProcessPath_MatchesExpectedValue on browser+CoreCLR The test already expects Environment.ProcessPath to be null on browser (PlatformDetection.IsBrowser ? null : ...), and it passes on browser+CoreCLR. Remove the bulk issue #123011 ActiveIssue. The GetFolderPath_Unix_NonEmptyFolderPaths ActiveIssue in the same file is kept: one InlineData case (CommonApplicationData/None) still returns an empty path on browser. Verified with WasmTestOnChrome (1 passed, 0 failed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../System.Runtime.Extensions.Tests/System/EnvironmentTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs index fbbcc4068d1446..7921173cee7c0e 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs @@ -94,7 +94,6 @@ public void ProcessPath_Idempotent() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android, "Throws PNSE")] public void ProcessPath_MatchesExpectedValue() { From b9ce5c6256d4fc40384f5588baa2a6b4873c66ec Mon Sep 17 00:00:00 2001 From: Radek Doulik Date: Thu, 11 Jun 2026 18:01:35 +0200 Subject: [PATCH 4/4] Re-enable supported ComVariant marshalling tests on browser+CoreCLR These pure-managed ComVariant marshalling tests pass on browser+CoreCLR: - ComVariantMarshallerTests: Null_Marshals_To_Empty, DBNull_Marshals_To_Null, Date_Marshals_To_DATE - ComVariantTests: VTVariantNotSupported, Unknown_NotSupported The two GeneratedComInterfaceType_Marshals_To_UNKNOWN variants keep their issue #123011 ActiveIssue: marshalling a source-generated COM interface object to VT_UNKNOWN needs a real IUnknown pointer, unsupported on browser. Verified with WasmTestOnChrome (152 passed, 0 failed, 2 skipped). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Runtime/InteropServices/ComVariantMarshallerTests.cs | 3 --- .../System/Runtime/InteropServices/ComVariantTests.cs | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantMarshallerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantMarshallerTests.cs index 218dab3c2497c6..d6784ce54b0235 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantMarshallerTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantMarshallerTests.cs @@ -17,7 +17,6 @@ namespace System.Runtime.InteropServices.Tests public partial class ComVariantMarshallerTests { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public void Null_Marshals_To_Empty() { Assert.Equal(VarEnum.VT_EMPTY, ComVariantMarshaller.ConvertToUnmanaged(null).VarType); @@ -25,7 +24,6 @@ public void Null_Marshals_To_Empty() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public void DBNull_Marshals_To_Null() { Assert.Equal(VarEnum.VT_NULL, ComVariantMarshaller.ConvertToUnmanaged(DBNull.Value).VarType); @@ -267,7 +265,6 @@ public void Decimal_Marshals_To_DECIMAL(decimal value) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public void Date_Marshals_To_DATE() { // OLE dates do not have time zones and do not support sub-millisecond precision. diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantTests.cs index 0ab90b463cc601..d438a121b1d348 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantTests.cs @@ -143,14 +143,12 @@ public void VariantBoolFalse() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public void VTVariantNotSupported() { Assert.Throws("vt", () => ComVariant.CreateRaw(VarEnum.VT_VARIANT, 1)); } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltInComEnabled))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public void Unknown_NotSupported() { UnknownWrapper wrapper = new(new TestObject());