From 09efb79a4ed935df6c350997d6ed581440485f1c Mon Sep 17 00:00:00 2001 From: Alexander Nikolaev Date: Fri, 5 Jun 2020 17:12:34 +0200 Subject: [PATCH 1/3] GetAsync_UnicodeHostName_SuccessStatusCodeInResponse timeout set to 200 sec --- .../Common/tests/System/Net/Http/HttpClientHandlerTest.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs index f2dd96d75d614d..5832d1e409b918 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs @@ -1629,6 +1629,7 @@ public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse() { using (HttpClient client = CreateHttpClient()) { + client.Timeout = TimeSpan.FromSeconds(200); // international version of the Starbucks website // punycode: xn--oy2b35ckwhba574atvuzkc.com string server = "http://\uc2a4\ud0c0\ubc85\uc2a4\ucf54\ub9ac\uc544.com"; From 47236c24b58bfa652e3722006475dc327c5d0773 Mon Sep 17 00:00:00 2001 From: Alexander Nikolaev Date: Mon, 8 Jun 2020 13:33:43 +0200 Subject: [PATCH 2/3] GetAsync_UnicodeHostName_SuccessStatusCodeInResponse is disabled --- .../Common/tests/System/Net/Http/HttpClientHandlerTest.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs index 5832d1e409b918..08c7064a17356e 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs @@ -1625,6 +1625,7 @@ await server.AcceptConnectionSendCustomResponseAndCloseAsync( [OuterLoop("Uses external server")] [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/29424")] public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse() { using (HttpClient client = CreateHttpClient()) From 11316e5c25a8624bfa59012dac9613ca1afac2d6 Mon Sep 17 00:00:00 2001 From: Alexander Nikolaev <55398552+alnikola@users.noreply.github.com> Date: Tue, 9 Jun 2020 13:32:36 +0200 Subject: [PATCH 3/3] Unnecessary timeout assignment removed --- .../Common/tests/System/Net/Http/HttpClientHandlerTest.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs index 08c7064a17356e..3852af097f9444 100644 --- a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs +++ b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs @@ -1630,7 +1630,6 @@ public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse() { using (HttpClient client = CreateHttpClient()) { - client.Timeout = TimeSpan.FromSeconds(200); // international version of the Starbucks website // punycode: xn--oy2b35ckwhba574atvuzkc.com string server = "http://\uc2a4\ud0c0\ubc85\uc2a4\ucf54\ub9ac\uc544.com";