From 1dd20d5c4d157ac9cb661b605017d1c354e2e3d3 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Tue, 26 Jan 2021 20:14:37 -0800 Subject: [PATCH 1/4] Improve msg for missing libicu --- .../src/System/Globalization/GlobalizationMode.Unix.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs index 7d91ed4713a1fa..7881b625be0297 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs @@ -26,7 +26,8 @@ private static bool GetGlobalizationInvariantMode() if (loaded == 0 && !OperatingSystem.IsBrowser()) { string message = "Couldn't find a valid ICU package installed on the system. " + - "Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support."; + "Please install libicu using your package manager and try again. " + + "Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support."; Environment.FailFast(message); } From c15a29c2a48d49cb75df57a083a87237b27ebe2e Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Wed, 27 Jan 2021 17:42:36 -0800 Subject: [PATCH 2/4] add comment --- .../src/System/Globalization/GlobalizationMode.Unix.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs index 7881b625be0297..016c44a3112ec9 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs @@ -25,6 +25,7 @@ private static bool GetGlobalizationInvariantMode() int loaded = Interop.Globalization.LoadICU(); if (loaded == 0 && !OperatingSystem.IsBrowser()) { + // This can't go into resources, because a resource lookup requires globalization, which requires ICU string message = "Couldn't find a valid ICU package installed on the system. " + "Please install libicu using your package manager and try again. " + "Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support."; From b6758e1f1d3ecef8ce140f8db9f2da3b06532ec6 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Wed, 27 Jan 2021 17:58:05 -0800 Subject: [PATCH 3/4] add aka.ms --- .../src/System/Globalization/GlobalizationMode.Unix.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs index 016c44a3112ec9..6d9c82bac6e830 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs @@ -28,7 +28,8 @@ private static bool GetGlobalizationInvariantMode() // This can't go into resources, because a resource lookup requires globalization, which requires ICU string message = "Couldn't find a valid ICU package installed on the system. " + "Please install libicu using your package manager and try again. " + - "Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support."; + "Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. " + + "Please see https://aka.ms/AAaz0rt for more information."; Environment.FailFast(message); } From e21338cfe55789bd7c0069a62b60e2899662fed1 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Wed, 27 Jan 2021 20:41:47 -0800 Subject: [PATCH 4/4] better link --- .../src/System/Globalization/GlobalizationMode.Unix.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs index 6d9c82bac6e830..0149463c6aa0eb 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs @@ -29,7 +29,7 @@ private static bool GetGlobalizationInvariantMode() string message = "Couldn't find a valid ICU package installed on the system. " + "Please install libicu using your package manager and try again. " + "Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. " + - "Please see https://aka.ms/AAaz0rt for more information."; + "Please see https://aka.ms/dotnet-missing-libicu for more information."; Environment.FailFast(message); }