From 77cfe4c8cbd3d672e5338a1aaa3e1d46395e94b0 Mon Sep 17 00:00:00 2001 From: Buyaa Namnan Date: Wed, 4 Aug 2021 14:02:15 -0700 Subject: [PATCH 1/2] Disable test failing in .net framework --- .../tests/System/CodeDom/Compiler/CodeCompilerTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs index bdfbbe3c4f779d..dfe968eeb8756d 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs @@ -458,6 +458,7 @@ public void FromSourceBatch_NullSources_ThrowsArgumentNullException() [InlineData(null)] [InlineData("")] [InlineData("cmdArgs")] + [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] public void GetResponseFileCmdArgs_ValidCmdArgs_ReturnsExpected(string cmdArgs) { var compiler = new Compiler(); From b7a0b799bbe89562755296ff7855078feff48593 Mon Sep 17 00:00:00 2001 From: Buyaa Namnan Date: Wed, 4 Aug 2021 17:29:50 -0700 Subject: [PATCH 2/2] Add explanation why it is being skipped --- .../tests/System/CodeDom/Compiler/CodeCompilerTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs index dfe968eeb8756d..7a53cd95b1d9eb 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs @@ -458,7 +458,7 @@ public void FromSourceBatch_NullSources_ThrowsArgumentNullException() [InlineData(null)] [InlineData("")] [InlineData("cmdArgs")] - [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] + [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Occasionally fails in .NET framework, probably caused from a very edge case bug in .NET Framework which we will not be fixing")] public void GetResponseFileCmdArgs_ValidCmdArgs_ReturnsExpected(string cmdArgs) { var compiler = new Compiler();