From c433d47ba3e23e4038c7c2247a586057626836e4 Mon Sep 17 00:00:00 2001 From: Krzysztof Wicher Date: Fri, 14 Jan 2022 19:11:32 +0100 Subject: [PATCH 1/5] Enable System.Text.Json tests on netfx --- docs/coding-guidelines/project-guidelines.md | 2 +- .../tests/Common/PropertyVisibilityTests.cs | 1 + .../ContextClasses.cs | 3 +-- .../MetadataAndSerializationContextTests.cs | 2 ++ .../MetadataContextTests.cs | 3 +++ .../MixedModeContextTests.cs | 2 ++ .../Serialization/PropertyVisibilityTests.cs | 4 ++++ .../SerializationContextTests.cs | 4 ++++ ...em.Text.Json.SourceGeneration.Tests.targets | 18 +++++++++++++++++- .../CompilationHelper.cs | 6 +++++- ...xt.Json.SourceGeneration.Unit.Tests.targets | 6 +++++- 11 files changed, 45 insertions(+), 6 deletions(-) diff --git a/docs/coding-guidelines/project-guidelines.md b/docs/coding-guidelines/project-guidelines.md index 5f27836900e25f..2e3e47dec47241 100644 --- a/docs/coding-guidelines/project-guidelines.md +++ b/docs/coding-guidelines/project-guidelines.md @@ -52,7 +52,7 @@ Pure netstandard configuration: All supported targets with unique windows/unix build for netcoreapp: ``` - $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetFrameworkCurrent) + $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetFrameworkMinimum) ``` diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs index 8c0f57b422a55d..302923a104c28e 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs @@ -1227,6 +1227,7 @@ public async Task JsonIgnoreAttribute_UnsupportedCollection() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)] public async Task JsonIgnoreAttribute_UnsupportedBigInteger() { string json = @"{""MyBigInteger"":1}"; diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/ContextClasses.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/ContextClasses.cs index c01499f7fef3e3..75ada92a87303d 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/ContextClasses.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/ContextClasses.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Collections.Generic; -using System.Reflection; using System.Text.Json.Serialization; using System.Text.Json.Serialization.Metadata; @@ -11,7 +10,7 @@ namespace System.Text.Json.SourceGeneration.Tests public interface ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode { get; } - public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; + public bool IsIncludeFieldsEnabled { get; } public JsonTypeInfo Location { get; } public JsonTypeInfo NumberTypes { get; } diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataAndSerializationContextTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataAndSerializationContextTests.cs index 57abdf04808a0c..a8eeee6f8768b8 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataAndSerializationContextTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataAndSerializationContextTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Text.Json.Serialization; +using System.Reflection; using Xunit; namespace System.Text.Json.SourceGeneration.Tests @@ -44,6 +45,7 @@ namespace System.Text.Json.SourceGeneration.Tests internal partial class MetadataAndSerializationContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Default; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } public sealed class MetadataAndSerializationContextTests : RealWorldContextTests diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataContextTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataContextTests.cs index d0c3023b41ae9f..89c5035700bead 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataContextTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MetadataContextTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Text.Json.Serialization; +using System.Reflection; using Xunit; namespace System.Text.Json.SourceGeneration.Tests @@ -43,6 +44,7 @@ namespace System.Text.Json.SourceGeneration.Tests internal partial class MetadataWithPerTypeAttributeContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Metadata; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } public sealed class MetadataWithPerTypeAttributeContextTests : RealWorldContextTests @@ -127,6 +129,7 @@ public override void EnsureFastPathGeneratedAsExpected() internal partial class MetadataContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Metadata; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } [JsonConverter(typeof(JsonStringEnumConverter))] diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MixedModeContextTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MixedModeContextTests.cs index d5475515699359..51e9e23b80d7be 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MixedModeContextTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/MixedModeContextTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Text.Json.Serialization; +using System.Reflection; using Xunit; namespace System.Text.Json.SourceGeneration.Tests @@ -44,6 +45,7 @@ namespace System.Text.Json.SourceGeneration.Tests internal partial class MixedModeContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Metadata | JsonSourceGenerationMode.Serialization; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } public sealed class MixedModeContextTests : RealWorldContextTests diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs index a698165e3f9677..68ec751b855cea 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs @@ -249,10 +249,12 @@ public override async Task HonorJsonPropertyName_PrivateSetter() [JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))] [JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))] [JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))] +#if !BUILDING_NETFX [JsonSerializable(typeof(ClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithIgnoredUnsupportedBigInteger))] +#endif [JsonSerializable(typeof(ClassWithThingsToIgnore))] [JsonSerializable(typeof(ClassWithMixedPropertyAccessors_PropertyAttributes))] [JsonSerializable(typeof(ClassWithPropertyPolicyConflictWhichThrows))] @@ -422,10 +424,12 @@ public override async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_ [JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))] [JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))] [JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))] +#if !BUILDING_NETFX [JsonSerializable(typeof(ClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithIgnoredUnsupportedBigInteger))] +#endif [JsonSerializable(typeof(ClassWithThingsToIgnore))] [JsonSerializable(typeof(ClassWithMixedPropertyAccessors_PropertyAttributes))] [JsonSerializable(typeof(ClassWithPropertyPolicyConflictWhichThrows))] diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/SerializationContextTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/SerializationContextTests.cs index b51ba070be1885..f955070f74cb50 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/SerializationContextTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/SerializationContextTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Text.Json.Serialization; +using System.Reflection; using Xunit; namespace System.Text.Json.SourceGeneration.Tests @@ -44,6 +45,7 @@ namespace System.Text.Json.SourceGeneration.Tests internal partial class SerializationContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Serialization; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } [JsonSerializable(typeof(Location), GenerationMode = JsonSourceGenerationMode.Serialization)] @@ -83,6 +85,7 @@ internal partial class SerializationContext : JsonSerializerContext, ITestContex internal partial class SerializationWithPerTypeAttributeContext : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Serialization; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } [JsonSourceGenerationOptions(PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase, IncludeFields = true)] @@ -123,6 +126,7 @@ internal partial class SerializationWithPerTypeAttributeContext : JsonSerializer internal partial class SerializationContextWithCamelCase : JsonSerializerContext, ITestContext { public JsonSourceGenerationMode JsonSourceGenerationMode => JsonSourceGenerationMode.Serialization; + public bool IsIncludeFieldsEnabled => GetType().GetCustomAttribute()?.IncludeFields ?? false; } public class SerializationContextTests : RealWorldContextTests diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets index 2f977168e80437..ba6ac6695715c6 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent);$(NetFrameworkCurrent) + $(NetCoreAppCurrent);$(NetFrameworkMinimum) true true @@ -13,6 +13,11 @@ $(DefineConstants);BUILDING_SOURCE_GENERATOR_TESTS + + + $(DefineConstants);BUILDING_NETFX + + @@ -86,6 +91,17 @@ + + + + + + + + + + + diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs index 485a79cd333cd6..4381422afb7f47 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs @@ -1,6 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. +using System.CodeDom.Compiler; using System.Collections.Generic; using System.Collections.Immutable; using System.Globalization; @@ -31,6 +32,7 @@ public static Compilation CreateCompilation( // Bypass System.Runtime error. Assembly systemRuntimeAssembly = Assembly.Load("System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"); Assembly systemCollectionsAssembly = Assembly.Load("System.Collections, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"); + // Needed on netfx string systemRuntimeAssemblyPath = systemRuntimeAssembly.Location; string systemCollectionsAssemblyPath = systemCollectionsAssembly.Location; @@ -38,9 +40,11 @@ public static Compilation CreateCompilation( MetadataReference.CreateFromFile(typeof(object).Assembly.Location), MetadataReference.CreateFromFile(typeof(Attribute).Assembly.Location), MetadataReference.CreateFromFile(typeof(Type).Assembly.Location), - MetadataReference.CreateFromFile(typeof(KeyValuePair).Assembly.Location), + MetadataReference.CreateFromFile(typeof(KeyValuePair<,>).Assembly.Location), MetadataReference.CreateFromFile(typeof(ContractNamespaceAttribute).Assembly.Location), MetadataReference.CreateFromFile(typeof(JavaScriptEncoder).Assembly.Location), + MetadataReference.CreateFromFile(typeof(GeneratedCodeAttribute).Assembly.Location), + MetadataReference.CreateFromFile(typeof(ReadOnlySpan<>).Assembly.Location), MetadataReference.CreateFromFile(systemRuntimeAssemblyPath), MetadataReference.CreateFromFile(systemCollectionsAssemblyPath), }; diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets index da4a8b8d65997b..08f362de05e7a5 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent);$(NetFrameworkCurrent) + $(NetCoreAppCurrent);$(NetFrameworkMinimum) true @@ -17,6 +17,10 @@ + + + + From 10334c9a152979934007808b515761802c25b254 Mon Sep 17 00:00:00 2001 From: Krzysztof Wicher Date: Sat, 15 Jan 2022 01:32:53 +0100 Subject: [PATCH 2/5] use NETFRAMEWORK define --- .../Serialization/PropertyVisibilityTests.cs | 4 ++-- .../System.Text.Json.SourceGeneration.Tests.targets | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs index 68ec751b855cea..1c80d9046a7c4e 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs @@ -249,7 +249,7 @@ public override async Task HonorJsonPropertyName_PrivateSetter() [JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))] [JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))] [JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))] -#if !BUILDING_NETFX +#if !NETFRAMEWORK [JsonSerializable(typeof(ClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))] @@ -424,7 +424,7 @@ public override async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_ [JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))] [JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))] [JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))] -#if !BUILDING_NETFX +#if !NETFRAMEWORK [JsonSerializable(typeof(ClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))] [JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))] diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets index ba6ac6695715c6..389c0eb3ce337f 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets @@ -13,11 +13,6 @@ $(DefineConstants);BUILDING_SOURCE_GENERATOR_TESTS - - - $(DefineConstants);BUILDING_NETFX - - From a018cc1f9438dc4c7ffc29919f3a4dfeeb869014 Mon Sep 17 00:00:00 2001 From: Krzysztof Wicher Date: Mon, 17 Jan 2022 13:03:57 +0100 Subject: [PATCH 3/5] disable another two test cases after rebase --- .../JsonSourceGeneratorTests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs index f8c0a34e57c805..f1d5b1973fd6ce 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs @@ -450,6 +450,7 @@ public void UsePrivates() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)] public void Record() { // Compile the referenced assembly first. @@ -511,6 +512,7 @@ public record AppRecord(int Id) } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)] public void RecordInExternalAssembly() { // Compile the referenced assembly first. From fe627f5f8df996964fef3571d9e995e058a463fb Mon Sep 17 00:00:00 2001 From: Krzysztof Wicher Date: Mon, 17 Jan 2022 14:10:49 +0100 Subject: [PATCH 4/5] disable last test case which repros only on CI for me --- .../JsonSerializerContextTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs index 7bc91507d9ad53..fd735e182d5fef 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs @@ -21,6 +21,7 @@ public static void VariousNestingAndVisibilityLevelsAreSupported() } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)] public static void Converters_AndTypeInfoCreator_NotRooted_WhenMetadataNotPresent() { RemoteExecutor.Invoke( From ab3e971ec87577380f40f48df514c0a57035ba29 Mon Sep 17 00:00:00 2001 From: Krzysztof Wicher Date: Tue, 18 Jan 2022 18:48:13 +0100 Subject: [PATCH 5/5] add p2p only on netfx --- .../System.Text.Json.SourceGeneration.Tests.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets index 389c0eb3ce337f..16f8d544794b8b 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets @@ -86,7 +86,7 @@ - +