From 6c8ce6e6f3d7df530cefbb0a7280c9d0dea5d448 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Sat, 5 Mar 2022 02:45:37 +0000 Subject: [PATCH] [wasm] Rename `$(EmccInitialMemory)` to `$(EmccInitialHeapSize)` .. to better represent what it is. --- src/mono/wasm/build/WasmApp.Native.targets | 6 +++--- src/mono/wasm/build/WasmApp.targets | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mono/wasm/build/WasmApp.Native.targets b/src/mono/wasm/build/WasmApp.Native.targets index 17cddce463a286..3b005902cfcb54 100644 --- a/src/mono/wasm/build/WasmApp.Native.targets +++ b/src/mono/wasm/build/WasmApp.Native.targets @@ -185,8 +185,8 @@ <_EmccCompileBitcodeRsp>$(_WasmIntermediateOutputPath)emcc-compile-bc.rsp <_EmccLinkRsp>$(_WasmIntermediateOutputPath)emcc-link.rsp - $(EmccTotalMemory) - 536870912 + $(EmccTotalMemory) + 536870912 @@ -223,7 +223,7 @@ <_EmccLDFlags Include="$(EmccLinkOptimizationFlag)" /> <_EmccLDFlags Include="@(_EmccCommonFlags)" /> <_EmccLDFlags Include="-Wl,--allow-undefined" /> - <_EmccLDSFlags Include="-s INITIAL_MEMORY=$(EmccInitialMemory)" /> + <_EmccLDSFlags Include="-s INITIAL_MEMORY=$(EmccInitialHeapSize)" /> <_EmccLDSFlags Include="-s ERROR_ON_UNDEFINED_SYMBOLS=0" Condition="'$(WasmBuildingForNestedPublish)' != 'true'" /> diff --git a/src/mono/wasm/build/WasmApp.targets b/src/mono/wasm/build/WasmApp.targets index b062cc3323fd70..969a5451b98a91 100644 --- a/src/mono/wasm/build/WasmApp.targets +++ b/src/mono/wasm/build/WasmApp.targets @@ -51,7 +51,8 @@ - $(EmccFlags) - Emcc flags used for both compiling native files, and linking - $(EmccExtraLDFlags) - Extra emcc flags for linking - $(EmccExtraCFlags) - Extra emcc flags for compiling native files - - $(EmccInitialMemory) - Initial memory specified with `emcc`. Default value: 536870912 + - $(EmccInitialHeapSize) - Initial heap size specified with `emcc`. Default value: 536870912 + Corresponds to `INITIAL_MEMORY` arg for emcc. (previously named EmccTotalMemory, which is still kept as an alias) - $(WasmBuildAppAfterThisTarget) - This target is used as `AfterTargets` for `WasmBuildApp. this