From 3aa3420feba1d41e39ab75f5dcb4c96588fed9c1 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Tue, 6 Sep 2022 14:40:34 +0200 Subject: [PATCH 1/6] Skip XmlSchemaSet test that gets stuck --- .../tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs index 1ac38f760b5239..72dd047b0a4757 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs @@ -64,6 +64,7 @@ public void v3() //----------------------------------------------------------------------------------- [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75123", TestPlatforms.Browser)] //[Variation(Desc = "v4 - ns = valid, URL = invalid")] public void v4() { From d904a5e5b5784eff1196a35dfb013c28597bc581 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Tue, 6 Sep 2022 14:41:22 +0200 Subject: [PATCH 2/6] Disable parallelization for XmlResolver tests to avoid deadlock --- .../tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs index 63579a63cf4c3c..f2c8139029d673 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs @@ -8,6 +8,9 @@ namespace System.Xml.Tests { +#if TARGET_BROWSER + [Collection(nameof(DisableParallelization))] +#endif //[TestCase(Name = "TC_SchemaSet_XmlResolver", Desc = "")] public class TC_SchemaSet_XmlResolver : TC_SchemaSetBase { From 790f2dc84ecc25fd4471aba99cd7862fe63210e9 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Tue, 6 Sep 2022 17:23:06 +0200 Subject: [PATCH 3/6] Skip failing XmlSystemPathResolverTests test --- .../tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Private.Xml/tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs b/src/libraries/System.Private.Xml/tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs index f08908a6288b6c..32c6857958eab7 100644 --- a/src/libraries/System.Private.Xml/tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs @@ -93,6 +93,7 @@ public static void TestResolveInvalidPaths() [InlineData("http://notfound.invalid.corp.microsoft.com")] [InlineData("ftp://host.invalid")] [InlineData("notsupported://host.invalid")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75129", TestPlatforms.Browser)] public static void TestResolveInvalidPath(string invalidUri) { Assert.ThrowsAny(() => XmlReader.Create(invalidUri)); From 7cf0f5877f1371f879e2b59d78e58975292aa420 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Tue, 6 Sep 2022 17:23:23 +0200 Subject: [PATCH 4/6] Skip failing XmlSchemaValidatorApi test --- .../tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs index 17119ee0c131d4..0239a99611f7b6 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs @@ -420,6 +420,7 @@ public TCValidateAfterAddInvalidSchema(ITestOutputHelper output) : base(output) [InlineData("SCHEMA", "schB1_a.xsd", 1, 3, 3)] [InlineData("SCHEMA", "schM2_a.xsd", 1, 3, 3)] [InlineData("SCHEMA", "schH2_a.xsd", 1, 3, 3)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75132", TestPlatform.Browser)] public void AddValid_Import_Include_Redefine(string testDir, string testFile, int expCount, int expCountGT, int expCountGE) { string xsd = Path.Combine(path, testDir, testFile); From 0d66d1c9c0f5710b156e19975327671c145ac45a Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Tue, 6 Sep 2022 18:49:59 +0200 Subject: [PATCH 5/6] Update src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs Co-authored-by: Larry Ewing --- .../tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs index 0239a99611f7b6..79bfff03680428 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs @@ -420,7 +420,7 @@ public TCValidateAfterAddInvalidSchema(ITestOutputHelper output) : base(output) [InlineData("SCHEMA", "schB1_a.xsd", 1, 3, 3)] [InlineData("SCHEMA", "schM2_a.xsd", 1, 3, 3)] [InlineData("SCHEMA", "schH2_a.xsd", 1, 3, 3)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/75132", TestPlatform.Browser)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75132", TestPlatforms.Browser)] public void AddValid_Import_Include_Redefine(string testDir, string testFile, int expCount, int expCountGT, int expCountGE) { string xsd = Path.Combine(path, testDir, testFile); From 250fd20b4d04b56bde79fcc201bfc39da639b4aa Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Wed, 7 Sep 2022 10:49:45 +0200 Subject: [PATCH 6/6] Disable failing tests instead of disabling parallelization --- .../tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs index f2c8139029d673..c8c7bff782eec2 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs @@ -8,9 +8,6 @@ namespace System.Xml.Tests { -#if TARGET_BROWSER - [Collection(nameof(DisableParallelization))] -#endif //[TestCase(Name = "TC_SchemaSet_XmlResolver", Desc = "")] public class TC_SchemaSet_XmlResolver : TC_SchemaSetBase { @@ -92,6 +89,7 @@ public void v3() //[Variation(Desc = "v4 - schema(Local)->schema(Local)", Priority = 1)] [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75183", TestPlatforms.Browser)] public void v4() { AppContext.SetSwitch("Switch.System.Xml.AllowDefaultResolver", true); @@ -107,6 +105,7 @@ public void v4() //[Variation(Desc = "v5 - schema(Local)->schema(Local)->schema(Local)", Priority = 1)] [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/75183", TestPlatforms.Browser)] public void v5() { AppContext.SetSwitch("Switch.System.Xml.AllowDefaultResolver", true);