Fix SoundPlayer handling of partial reads on streams#82612
Merged
Conversation
SoundPlayer assumes that a Read on a stream will return everything asked for, and that's not the case.
stephentoub
force-pushed
the
fixsoundplayerreads
branch
from
76eb4e1 to
216778b
Compare
|
Tagging subscribers to this area: @dotnet/area-microsoft-win32 Issue DetailsSoundPlayer assumes that a Read on a stream will return everything asked for, and that's not the case. Fixes #80264
|
tannergooding
approved these changes
Mar 2, 2023
carlossanlop
reviewed
Mar 2, 2023
| _stream.Read(_streamData, 0, streamLen); | ||
| #if NET7_0_OR_GREATER | ||
| _stream.ReadExactly(_streamData); | ||
| #else |
Contributor
There was a problem hiding this comment.
Should we backport this?
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SoundPlayer assumes that a Read on a stream will return everything asked for, and that's not the case.
Fixes #80264