Rewrite exception handler if retval is a pointer#82740
Merged
jtschuster merged 3 commits intoFeb 28, 2023
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #82504 We need to cast the
|
jkoritzinsky
approved these changes
Feb 27, 2023
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
One comment. The rest looks good!
jkoritzinsky
approved these changes
Feb 27, 2023
jkoritzinsky
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82504
We need to cast the
IntPtrwe assign to__retVal_nativewhen it is a pointer type. This uses thePointerNativeTypeAssignmentRewriterto do this. I left it as a nested class inNonBlittableElementsMarshalling, but let me know if it should be moved out.