Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -390,47 +390,5 @@ protected StatementSyntax GenerateContentsMarshallingStatement(

return EmptyStatement();
}

/// <summary>
/// Rewrite assignment expressions to the native identifier to cast to IntPtr.
/// This handles the case where the native type of a non-blittable managed type is a pointer,
/// which are unsupported in generic type parameters.
/// </summary>
private sealed class PointerNativeTypeAssignmentRewriter : CSharpSyntaxRewriter
{
private readonly string _nativeIdentifier;
private readonly PointerTypeSyntax _nativeType;

public PointerNativeTypeAssignmentRewriter(string nativeIdentifier, PointerTypeSyntax nativeType)
{
_nativeIdentifier = nativeIdentifier;
_nativeType = nativeType;
}

public override SyntaxNode VisitAssignmentExpression(AssignmentExpressionSyntax node)
{
if (node.Left.ToString() == _nativeIdentifier)
{
return node.WithRight(
CastExpression(MarshallerHelpers.SystemIntPtrType, node.Right));
}
if (node.Right.ToString() == _nativeIdentifier)
{
return node.WithRight(CastExpression(_nativeType, node.Right));
}

return base.VisitAssignmentExpression(node);
}

public override SyntaxNode? VisitArgument(ArgumentSyntax node)
{
if (node.Expression.ToString() == _nativeIdentifier)
{
return node.WithExpression(
CastExpression(_nativeType, node.Expression));
}
return base.VisitArgument(node);
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;

namespace Microsoft.Interop
{
/// <summary>
/// Rewrite assignment expressions to the native identifier to cast to IntPtr.
/// This handles the case where the native type of a non-blittable managed type is a pointer,
/// which are unsupported in generic type parameters.
/// </summary>
internal sealed class PointerNativeTypeAssignmentRewriter : CSharpSyntaxRewriter
{
private readonly string _nativeIdentifier;
private readonly PointerTypeSyntax _nativeType;

public PointerNativeTypeAssignmentRewriter(string nativeIdentifier, PointerTypeSyntax nativeType)
{
_nativeIdentifier = nativeIdentifier;
_nativeType = nativeType;
}

public override SyntaxNode VisitAssignmentExpression(AssignmentExpressionSyntax node)
{
if (node.Left.ToString() == _nativeIdentifier)
{
return node.WithRight(
CastExpression(MarshallerHelpers.SystemIntPtrType, node.Right));
}
if (node.Right.ToString() == _nativeIdentifier)
{
return node.WithRight(CastExpression(_nativeType, node.Right));
}

return base.VisitAssignmentExpression(node);
}

public override SyntaxNode? VisitArgument(ArgumentSyntax node)
{
if (node.Expression.ToString() == _nativeIdentifier)
{
return node.WithExpression(
CastExpression(_nativeType, node.Expression));
}
return base.VisitArgument(node);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,19 @@ public IEnumerable<StatementSyntax> GenerateMarshalStatements(TypePositionInfo i
}

// <nativeIdentifier> = <convertToUnmanaged>;
yield return ExpressionStatement(
AssignmentExpression(
var assignment = AssignmentExpression(
SyntaxKind.SimpleAssignmentExpression,
IdentifierName(nativeIdentifier),
convertToUnmanaged));
convertToUnmanaged);


if (_unmanagedType is PointerTypeInfo pointer)
{
var rewriter = new PointerNativeTypeAssignmentRewriter(assignment.Right.ToString(), (PointerTypeSyntax)pointer.Syntax);
assignment = (AssignmentExpressionSyntax)rewriter.Visit(assignment);

}
yield return ExpressionStatement(assignment);
}

public IEnumerable<StatementSyntax> GeneratePinnedMarshalStatements(TypePositionInfo info, StubCodeContext context)
Expand Down