Fix source-build oob package orchestration#84720
Merged
Merged
Conversation
Regressed with e3c3700. By replacing "net48" with `$(NetFrameworkCurrent)`, the condition became true (as both BuildTargetFramework and NetFrameworkCurrent are empty in source build) and projects were filtered out.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsRegressed with e3c3700. By replacing "net48" with Unblocks dotnet/sdk#31752
|
carlossanlop
approved these changes
Apr 12, 2023
mmitche
approved these changes
Apr 12, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed with e3c3700. By replacing "net48" with
$(NetFrameworkCurrent), the condition became true (as both BuildTargetFramework and NetFrameworkCurrent are empty in source build) and projects were filtered out.Unblocks dotnet/sdk#31752