From 9937f2de11fb085e97ac6f3a3011b3ee583f08a7 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Mon, 15 May 2023 17:02:04 -0700 Subject: [PATCH] MetricEventSource tests workaround .NET Framework double rounding Fixes #85290 Desktop .NET Framework on x86 improperly rounds double values in some circumstances. I switched the test to use a lower precision double value so that it is not impacted by the extra rounding. --- .../tests/MetricEventSourceTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs b/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs index ac8da362c8d2ca..766d33c853f6cf 100644 --- a/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs +++ b/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs @@ -594,7 +594,7 @@ public void EventSourcePublishesAllDataTypes() l.Add(123_456_789_012); dec.Add(123_456_789_012_345); f.Add(123_456.789F); - d.Add(87_654_321_987_654.4); + d.Add(5.25); i.Add(1); s.Add(1); @@ -611,7 +611,7 @@ public void EventSourcePublishesAllDataTypes() l.Add(123_456_789_012); dec.Add(123_456_789_012_345); f.Add(123_456.789F); - d.Add(87_654_321_987_654.4); + d.Add(5.25); i.Add(1); s.Add(1); @@ -632,7 +632,7 @@ public void EventSourcePublishesAllDataTypes() AssertCounterEventsPresent(events, meter.Name, l.Name, "", "", ("123456789013", "123456789013"), ("123456789013", "246913578026")); AssertCounterEventsPresent(events, meter.Name, dec.Name, "", "", ("123456789012346", "123456789012346"), ("123456789012346", "246913578024692")); AssertCounterEventsPresent(events, meter.Name, f.Name, "", "", ("123457.7890625", "123457.7890625"), ("123457.7890625", "246915.578125")); - AssertCounterEventsPresent(events, meter.Name, d.Name, "", "", ("87654321987655.4", "87654321987655.4"), ("87654321987655.4", "175308643975310.8")); + AssertCounterEventsPresent(events, meter.Name, d.Name, "", "", ("6.25", "6.25"), ("6.25", "12.5")); AssertCollectStartStopEventsPresent(events, IntervalSecs, 3); }