Logging middleware#87550
Closed
noahfalk wants to merge 27 commits into
Closed
Conversation
- Refactored to remove BufferWriter - Extracted all formatting work outside of ILogMetadata to extension methods. - Added a new CreatePropertyListVisitor as the primitive all high performance serialization can be layered over. - Removed all the virtual override based formatting logic and converged on IPropertyVisitorFactory to produce delegates. - Continued refactoring away from LogValuesFormatter towards ILogMetadata.
- Replace all usage of the formatter with ILogMetadata
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsWork in progress, taking back over from JamesNK who was previously working here. Tasks:
|
Member
|
can we close #86995 now? |
13 tasks
Member
Author
done |
Using new data classification model
Member
Author
|
Decided not to pursue this in .NET 8 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, taking back over from JamesNK who was previously working here.
Tasks:
cc @noahfalk @tarekgh