From fa0c53c54a7afa0d0bb10b4b173ca440cfce56b2 Mon Sep 17 00:00:00 2001 From: Tomas Rylek Date: Fri, 18 Aug 2023 01:00:56 +0200 Subject: [PATCH 1/2] Slightly reduce the Depth3Test that often times out on Linux This is one of the regression tests I introduced as part of implementing protection against infinite generic recursion in Crossgen2. Turns out that on the relatively slow Helix Linux VMs the test often times out due to compilation time exceeding 10 minutes. I propose slightly trimming down the test so that it uses less time in Helix. Thanks Tomas --- src/tests/readytorun/GenericCycleDetection/Depth3Test.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs b/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs index 2edaef57d2681c..565079d5d269c9 100644 --- a/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs +++ b/src/tests/readytorun/GenericCycleDetection/Depth3Test.cs @@ -23,7 +23,6 @@ public static long TypeNestedFactorial(int count) if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); - if (result < count) result = Depth1>.TypeNestedFactorial(count - 1); return count * result; } } @@ -31,7 +30,6 @@ public static long TypeNestedFactorial(int count) private struct Depth2 {} private struct Depth3 {} private struct Depth4 {} - private struct Depth5 {} [Fact] public static int DepthTest() From 571e048c0e57386d3e904a51f4f5b86377c84fdc Mon Sep 17 00:00:00 2001 From: Tomas Rylek Date: Tue, 22 Aug 2023 21:05:46 +0200 Subject: [PATCH 2/2] Remove issues.targets exclusion for the Depth3Test --- src/tests/issues.targets | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 221ed02229eb40..05b995cd0d6b04 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -72,9 +72,6 @@ https://github.com/dotnet/runtime/issues/89585 - - https://github.com/dotnet/runtime/issues/88586 -