Address review feedback.

KlausLoeffelmann · KlausLoeffelmann · commit 94de3b94b552 · 2024-08-11T14:00:45.000-07:00
diff --git a/src/System.Windows.Forms.Analyzers/src/System/Windows/Forms/Analyzers/Diagnostics/DiagnosticIDs.cs b/src/System.Windows.Forms.Analyzers/src/System/Windows/Forms/Analyzers/Diagnostics/DiagnosticIDs.cs
@@ -5,7 +5,7 @@ namespace System.Windows.Forms.Analyzers.Diagnostics;
 
 internal static class DiagnosticIDs
 {
-    public const string UrlFormat = "https://aka.ms/winforms-experimental/{0}";
+    public const string UrlFormat = "https://aka.ms/winforms-warnings/{0}";
 
     // Application Configuration, number group 0001+
     public const string UnsupportedProjectType = "WFO0001";
diff --git a/src/System.Windows.Forms/src/GlobalSuppressions.cs b/src/System.Windows.Forms/src/GlobalSuppressions.cs
@@ -260,3 +260,10 @@
 [assembly: SuppressMessage("Design", "CA1051:Do not declare visible instance fields", Justification = "Public API", Scope = "member", Target = "~F:System.Windows.Forms.BindingManagerBase.onPositionChangedHandler")]
 [assembly: SuppressMessage("Design", "CA1051:Do not declare visible instance fields", Justification = "Public API", Scope = "member", Target = "~F:System.Windows.Forms.CurrencyManager.listposition")]
 [assembly: SuppressMessage("Design", "CA1051:Do not declare visible instance fields", Justification = "Public API", Scope = "member", Target = "~F:System.Windows.Forms.CurrencyManager.finalType")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.Control.InvokeAsync``1(System.Func{``0},System.Threading.CancellationToken)~System.Threading.Tasks.Task{``0}")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.Control.InvokeAsync(System.Func{System.Threading.CancellationToken,System.Threading.Tasks.ValueTask},System.Threading.CancellationToken)~System.Threading.Tasks.Task")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.Control.InvokeAsync``1(System.Func{System.Threading.CancellationToken,System.Threading.Tasks.ValueTask{``0}},System.Threading.CancellationToken)~System.Threading.Tasks.Task{``0}")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.Control.InvokeAsync(System.Action,System.Threading.CancellationToken)~System.Threading.Tasks.Task")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.TaskDialogPage,System.Windows.Forms.TaskDialogStartupLocation)~System.Threading.Tasks.Task{System.Windows.Forms.TaskDialogButton}")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.IWin32Window,System.Windows.Forms.TaskDialogPage,System.Windows.Forms.TaskDialogStartupLocation)~System.Threading.Tasks.Task{System.Windows.Forms.TaskDialogButton}")]
+[assembly: SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Analyzer wrongly complains for new APIs - known issue.", Scope = "member", Target = "~M:System.Windows.Forms.TaskDialog.ShowDialogAsync(System.IntPtr,System.Windows.Forms.TaskDialogPage,System.Windows.Forms.TaskDialogStartupLocation)~System.Threading.Tasks.Task{System.Windows.Forms.TaskDialogButton}")]
diff --git a/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt b/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt
@@ -1,7 +1,6 @@
-static System.Windows.Forms.TaskDialog.ShowDialogAsync(nint hwndOwner, System.Windows.Forms.TaskDialogPage! page) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
-static System.Windows.Forms.TaskDialog.ShowDialogAsync(nint hwndOwner, System.Windows.Forms.TaskDialogPage! page, System.Windows.Forms.TaskDialogStartupLocation startupLocation) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
-static System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.TaskDialogPage! page) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
-static System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.TaskDialogPage! page, System.Windows.Forms.TaskDialogStartupLocation startupLocation) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
+static System.Windows.Forms.TaskDialog.ShowDialogAsync(nint hwndOwner, System.Windows.Forms.TaskDialogPage! page, System.Windows.Forms.TaskDialogStartupLocation startupLocation = System.Windows.Forms.TaskDialogStartupLocation.CenterOwner) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
+static System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.IWin32Window! owner, System.Windows.Forms.TaskDialogPage! page, System.Windows.Forms.TaskDialogStartupLocation startupLocation = System.Windows.Forms.TaskDialogStartupLocation.CenterOwner) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
+static System.Windows.Forms.TaskDialog.ShowDialogAsync(System.Windows.Forms.TaskDialogPage! page, System.Windows.Forms.TaskDialogStartupLocation startupLocation = System.Windows.Forms.TaskDialogStartupLocation.CenterScreen) -> System.Threading.Tasks.Task<System.Windows.Forms.TaskDialogButton!>!
 System.Windows.Forms.Control.InvokeAsync(System.Action! callback, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task!
 System.Windows.Forms.Control.InvokeAsync(System.Func<System.Threading.CancellationToken, System.Threading.Tasks.ValueTask>! callback, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task!
 System.Windows.Forms.Control.InvokeAsync<T>(System.Func<System.Threading.CancellationToken, System.Threading.Tasks.ValueTask<T>>! callback, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<T>!
diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/Control_InvokeAsync.cs b/src/System.Windows.Forms/src/System/Windows/Forms/Control_InvokeAsync.cs
@@ -27,9 +27,7 @@ public partial class Control
     ///   <see cref="InvokeAsync{T}(Func{CancellationToken, ValueTask{T}}, CancellationToken)"/>.
     ///  </para>
     /// </remarks>
-#pragma warning disable RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads
     public async Task InvokeAsync(Action callback, CancellationToken cancellationToken = default)
-#pragma warning restore RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads
     {
         ArgumentNullException.ThrowIfNull(callback);
 
@@ -38,12 +36,12 @@ public async Task InvokeAsync(Action callback, CancellationToken cancellationTok
             return;
         }
 
-        TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
+        TaskCompletionSource completion = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))
+        using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))
         {
             BeginInvoke(WrappedAction);
-            await tcs.Task.ConfigureAwait(false);
+            await completion.Task.ConfigureAwait(false);
         }
 
         void WrappedAction()
@@ -52,16 +50,16 @@ void WrappedAction()
             {
                 if (cancellationToken.IsCancellationRequested)
                 {
-                    tcs.SetCanceled(cancellationToken);
+                    completion.SetCanceled(cancellationToken);
                     return;
                 }
 
                 callback();
-                tcs.TrySetResult();
+                completion.TrySetResult();
             }
             catch (Exception ex)
             {
-                tcs.TrySetException(ex);
+                completion.TrySetException(ex);
             }
         }
     }
@@ -95,9 +93,7 @@ void WrappedAction()
     ///   <see cref="InvokeAsync{T}(Func{CancellationToken, ValueTask{T}}, CancellationToken)"/>.
     ///  </para>
     /// </remarks>
-#pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters
     public async Task<T> InvokeAsync<T>(Func<T> callback, CancellationToken cancellationToken = default)
-#pragma warning restore RS0026 // Do not add multiple public overloads with optional parameters
     {
         ArgumentNullException.ThrowIfNull(callback);
 
@@ -106,12 +102,12 @@ public async Task<T> InvokeAsync<T>(Func<T> callback, CancellationToken cancella
             return default!;
         }
 
-        TaskCompletionSource<T> tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
+        TaskCompletionSource<T> completion = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))
+        using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))
         {
             BeginInvoke(WrappedCallback);
-            return await tcs.Task.ConfigureAwait(false);
+            return await completion.Task.ConfigureAwait(false);
         }
 
         void WrappedCallback()
@@ -120,16 +116,16 @@ void WrappedCallback()
             {
                 if (cancellationToken.IsCancellationRequested)
                 {
-                    tcs.TrySetCanceled(cancellationToken);
+                    completion.TrySetCanceled(cancellationToken);
                     return;
                 }
 
                 T result = callback();
-                tcs.TrySetResult(result);
+                completion.TrySetResult(result);
             }
             catch (Exception ex)
             {
-                tcs.TrySetException(ex);
+                completion.TrySetException(ex);
             }
         }
     }
@@ -162,9 +158,7 @@ void WrappedCallback()
     ///   <see cref="InvokeAsync(Action, CancellationToken)"/>.
     ///  </para>
     /// </remarks>
-#pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters
     public async Task InvokeAsync(Func<CancellationToken, ValueTask> callback, CancellationToken cancellationToken = default)
-#pragma warning restore RS0026 // Do not add multiple public overloads with optional parameters
     {
         ArgumentNullException.ThrowIfNull(callback);
 
@@ -173,12 +167,12 @@ public async Task InvokeAsync(Func<CancellationToken, ValueTask> callback, Cance
             return;
         }
 
-        TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
+        TaskCompletionSource completion = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))
+        using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))
         {
             BeginInvoke(async () => await WrappedCallbackAsync().ConfigureAwait(false));
-            await tcs.Task.ConfigureAwait(false);
+            await completion.Task.ConfigureAwait(false);
         }
 
         async Task WrappedCallbackAsync()
@@ -187,16 +181,16 @@ async Task WrappedCallbackAsync()
             {
                 if (cancellationToken.IsCancellationRequested)
                 {
-                    tcs.TrySetCanceled(cancellationToken);
+                    completion.TrySetCanceled(cancellationToken);
                     return;
                 }
 
                 await callback(cancellationToken).ConfigureAwait(false);
-                tcs.TrySetResult();
+                completion.TrySetResult();
             }
             catch (Exception ex)
             {
-                tcs.TrySetException(ex);
+                completion.TrySetException(ex);
             }
         }
     }
@@ -228,9 +222,7 @@ async Task WrappedCallbackAsync()
     ///   <see cref="InvokeAsync(Action, CancellationToken)"/>.
     ///  </para>
     /// </remarks>
-#pragma warning disable RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads
     public async Task<T> InvokeAsync<T>(Func<CancellationToken, ValueTask<T>> callback, CancellationToken cancellationToken = default)
-#pragma warning restore RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads
     {
         ArgumentNullException.ThrowIfNull(callback);
 
@@ -239,24 +231,24 @@ public async Task<T> InvokeAsync<T>(Func<CancellationToken, ValueTask<T>> callba
             return default!;
         }
 
-        TaskCompletionSource<T> tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
+        TaskCompletionSource<T> completion = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))
+        using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))
         {
             BeginInvoke(async () => await WrappedCallbackAsync().ConfigureAwait(false));
-            return await tcs.Task.ConfigureAwait(false);
+            return await completion.Task.ConfigureAwait(false);
         }
 
         async Task WrappedCallbackAsync()
         {
             try
             {
                 var returnValue = await callback(cancellationToken).ConfigureAwait(false);
-                tcs.TrySetResult(returnValue);
+                completion.TrySetResult(returnValue);
             }
             catch (Exception ex)
             {
-                tcs.TrySetException(ex);
+                completion.TrySetException(ex);
             }
         }
     }
diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/Dialogs/TaskDialog/TaskDialog.cs b/src/System.Windows.Forms/src/System/Windows/Forms/Dialogs/TaskDialog/TaskDialog.cs
diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/Form.cs b/src/System.Windows.Forms/src/System/Windows/Forms/Form.cs

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ namespace System.Windows.Forms.Analyzers.Diagnostics;`
`5`	`5`
`6`	`6`	`internal static class DiagnosticIDs`
`7`	`7`	`{`
`8`		`- public const string UrlFormat = "https://aka.ms/winforms-experimental/{0}";`
	`8`	`+ public const string UrlFormat = "https://aka.ms/winforms-warnings/{0}";`
`9`	`9`
`10`	`10`	`// Application Configuration, number group 0001+`
`11`	`11`	`public const string UnsupportedProjectType = "WFO0001";`
Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,7 @@ public partial class Control`
`27`	`27`	`/// <see cref="InvokeAsync{T}(Func{CancellationToken, ValueTask{T}}, CancellationToken)"/>.`
`28`	`28`	`/// </para>`
`29`	`29`	`/// </remarks>`
`30`		`-#pragma warning disable RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads`
`31`	`30`	`public async Task InvokeAsync(Action callback, CancellationToken cancellationToken = default)`
`32`		`-#pragma warning restore RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads`
`33`	`31`	`{`
`34`	`32`	`ArgumentNullException.ThrowIfNull(callback);`
`35`	`33`
`@@ -38,12 +36,12 @@ public async Task InvokeAsync(Action callback, CancellationToken cancellationTok`
`38`	`36`	`return;`
`39`	`37`	`}`
`40`	`38`
`41`		`- TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);`
	`39`	`+ TaskCompletionSource completion = new(TaskCreationOptions.RunContinuationsAsynchronously);`
`42`	`40`
`43`		`- using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))`
	`41`	`+ using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))`
`44`	`42`	`{`
`45`	`43`	`BeginInvoke(WrappedAction);`
`46`		`- await tcs.Task.ConfigureAwait(false);`
	`44`	`+ await completion.Task.ConfigureAwait(false);`
`47`	`45`	`}`
`48`	`46`
`49`	`47`	`void WrappedAction()`
`@@ -52,16 +50,16 @@ void WrappedAction()`
`52`	`50`	`{`
`53`	`51`	`if (cancellationToken.IsCancellationRequested)`
`54`	`52`	`{`
`55`		`- tcs.SetCanceled(cancellationToken);`
	`53`	`+ completion.SetCanceled(cancellationToken);`
`56`	`54`	`return;`
`57`	`55`	`}`
`58`	`56`
`59`	`57`	`callback();`
`60`		`- tcs.TrySetResult();`
	`58`	`+ completion.TrySetResult();`
`61`	`59`	`}`
`62`	`60`	`catch (Exception ex)`
`63`	`61`	`{`
`64`		`- tcs.TrySetException(ex);`
	`62`	`+ completion.TrySetException(ex);`
`65`	`63`	`}`
`66`	`64`	`}`
`67`	`65`	`}`
`@@ -95,9 +93,7 @@ void WrappedAction()`
`95`	`93`	`/// <see cref="InvokeAsync{T}(Func{CancellationToken, ValueTask{T}}, CancellationToken)"/>.`
`96`	`94`	`/// </para>`
`97`	`95`	`/// </remarks>`
`98`		`-#pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters`
`99`	`96`	`public async Task<T> InvokeAsync<T>(Func<T> callback, CancellationToken cancellationToken = default)`
`100`		`-#pragma warning restore RS0026 // Do not add multiple public overloads with optional parameters`
`101`	`97`	`{`
`102`	`98`	`ArgumentNullException.ThrowIfNull(callback);`
`103`	`99`
`@@ -106,12 +102,12 @@ public async Task<T> InvokeAsync<T>(Func<T> callback, CancellationToken cancella`
`106`	`102`	`return default!;`
`107`	`103`	`}`
`108`	`104`
`109`		`- TaskCompletionSource<T> tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);`
	`105`	`+ TaskCompletionSource<T> completion = new(TaskCreationOptions.RunContinuationsAsynchronously);`
`110`	`106`
`111`		`- using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))`
	`107`	`+ using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))`
`112`	`108`	`{`
`113`	`109`	`BeginInvoke(WrappedCallback);`
`114`		`- return await tcs.Task.ConfigureAwait(false);`
	`110`	`+ return await completion.Task.ConfigureAwait(false);`
`115`	`111`	`}`
`116`	`112`
`117`	`113`	`void WrappedCallback()`
`@@ -120,16 +116,16 @@ void WrappedCallback()`
`120`	`116`	`{`
`121`	`117`	`if (cancellationToken.IsCancellationRequested)`
`122`	`118`	`{`
`123`		`- tcs.TrySetCanceled(cancellationToken);`
	`119`	`+ completion.TrySetCanceled(cancellationToken);`
`124`	`120`	`return;`
`125`	`121`	`}`
`126`	`122`
`127`	`123`	`T result = callback();`
`128`		`- tcs.TrySetResult(result);`
	`124`	`+ completion.TrySetResult(result);`
`129`	`125`	`}`
`130`	`126`	`catch (Exception ex)`
`131`	`127`	`{`
`132`		`- tcs.TrySetException(ex);`
	`128`	`+ completion.TrySetException(ex);`
`133`	`129`	`}`
`134`	`130`	`}`
`135`	`131`	`}`
`@@ -162,9 +158,7 @@ void WrappedCallback()`
`162`	`158`	`/// <see cref="InvokeAsync(Action, CancellationToken)"/>.`
`163`	`159`	`/// </para>`
`164`	`160`	`/// </remarks>`
`165`		`-#pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters`
`166`	`161`	`public async Task InvokeAsync(Func<CancellationToken, ValueTask> callback, CancellationToken cancellationToken = default)`
`167`		`-#pragma warning restore RS0026 // Do not add multiple public overloads with optional parameters`
`168`	`162`	`{`
`169`	`163`	`ArgumentNullException.ThrowIfNull(callback);`
`170`	`164`
`@@ -173,12 +167,12 @@ public async Task InvokeAsync(Func<CancellationToken, ValueTask> callback, Cance`
`173`	`167`	`return;`
`174`	`168`	`}`
`175`	`169`
`176`		`- TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);`
	`170`	`+ TaskCompletionSource completion = new(TaskCreationOptions.RunContinuationsAsynchronously);`
`177`	`171`
`178`		`- using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))`
	`172`	`+ using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))`
`179`	`173`	`{`
`180`	`174`	`BeginInvoke(async () => await WrappedCallbackAsync().ConfigureAwait(false));`
`181`		`- await tcs.Task.ConfigureAwait(false);`
	`175`	`+ await completion.Task.ConfigureAwait(false);`
`182`	`176`	`}`
`183`	`177`
`184`	`178`	`async Task WrappedCallbackAsync()`
`@@ -187,16 +181,16 @@ async Task WrappedCallbackAsync()`
`187`	`181`	`{`
`188`	`182`	`if (cancellationToken.IsCancellationRequested)`
`189`	`183`	`{`
`190`		`- tcs.TrySetCanceled(cancellationToken);`
	`184`	`+ completion.TrySetCanceled(cancellationToken);`
`191`	`185`	`return;`
`192`	`186`	`}`
`193`	`187`
`194`	`188`	`await callback(cancellationToken).ConfigureAwait(false);`
`195`		`- tcs.TrySetResult();`
	`189`	`+ completion.TrySetResult();`
`196`	`190`	`}`
`197`	`191`	`catch (Exception ex)`
`198`	`192`	`{`
`199`		`- tcs.TrySetException(ex);`
	`193`	`+ completion.TrySetException(ex);`
`200`	`194`	`}`
`201`	`195`	`}`
`202`	`196`	`}`
`@@ -228,9 +222,7 @@ async Task WrappedCallbackAsync()`
`228`	`222`	`/// <see cref="InvokeAsync(Action, CancellationToken)"/>.`
`229`	`223`	`/// </para>`
`230`	`224`	`/// </remarks>`
`231`		`-#pragma warning disable RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads`
`232`	`225`	`public async Task<T> InvokeAsync<T>(Func<CancellationToken, ValueTask<T>> callback, CancellationToken cancellationToken = default)`
`233`		`-#pragma warning restore RS0026 // API with optional parameter(s) should have the most parameters amongst its public overloads`
`234`	`226`	`{`
`235`	`227`	`ArgumentNullException.ThrowIfNull(callback);`
`236`	`228`
`@@ -239,24 +231,24 @@ public async Task<T> InvokeAsync<T>(Func<CancellationToken, ValueTask<T>> callba`
`239`	`231`	`return default!;`
`240`	`232`	`}`
`241`	`233`
`242`		`- TaskCompletionSource<T> tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);`
	`234`	`+ TaskCompletionSource<T> completion = new(TaskCreationOptions.RunContinuationsAsynchronously);`
`243`	`235`
`244`		`- using (cancellationToken.Register(() => tcs.SetCanceled(), useSynchronizationContext: false))`
	`236`	`+ using (cancellationToken.Register(() => completion.SetCanceled(), useSynchronizationContext: false))`
`245`	`237`	`{`
`246`	`238`	`BeginInvoke(async () => await WrappedCallbackAsync().ConfigureAwait(false));`
`247`		`- return await tcs.Task.ConfigureAwait(false);`
	`239`	`+ return await completion.Task.ConfigureAwait(false);`
`248`	`240`	`}`
`249`	`241`
`250`	`242`	`async Task WrappedCallbackAsync()`
`251`	`243`	`{`
`252`	`244`	`try`
`253`	`245`	`{`
`254`	`246`	`var returnValue = await callback(cancellationToken).ConfigureAwait(false);`
`255`		`- tcs.TrySetResult(returnValue);`
	`247`	`+ completion.TrySetResult(returnValue);`
`256`	`248`	`}`
`257`	`249`	`catch (Exception ex)`
`258`	`250`	`{`
`259`		`- tcs.TrySetException(ex);`
	`251`	`+ completion.TrySetException(ex);`
`260`	`252`	`}`
`261`	`253`	`}`
`262`	`254`	`}`