Fix Control COM interface serialization#8597
Merged
Merged
Conversation
`PropertyBagStream` wasn't converting it's values correctly to/from string/object. Also reinstate `BinaryFormatter` property handling which I removed under the misunderstanding that `BinaryFormatter` would be completely removed. Add tests.
Adds additional conversions and fallback for `VARIANT.FromObject()`.
lonitra
reviewed
Feb 9, 2023
ghost
locked as resolved and limited conversation to collaborators
JeremyKuhne
added
the
area-Serialization-BinaryFormatter-FeatureWork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyBagStreamwasn't converting it's values correctly to/from string/object.Also reinstate
BinaryFormatterproperty handling which I removed under the misunderstanding thatBinaryFormatterwould be completely removed.Add tests.
Microsoft Reviewers: Open in CodeFlow