Skip to content

Commit e3bf64d

Browse files
Copilotdr5hn
andcommitted
docs: Consolidate Yemen documentation into single file per updated guidelines
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
1 parent c86345b commit e3bf64d

File tree

2 files changed

+92
-117
lines changed

2 files changed

+92
-117
lines changed
Lines changed: 92 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1-
# Yemen Ad Dali' Governorate - Detailed Fix Documentation
1+
# Yemen Missing Governorate Fix - Issue #1155
22

3-
## Issue Reference
4-
This fix addresses the missing Ad Dali' (الضالع) governorate in Yemen's administrative divisions.
3+
## Quick Reference
4+
5+
**Issue**: [#1155](https://github.com/dr5hn/countries-states-cities-database/issues/1155) - Yemen was missing 1 governorate (Ad Dali')
6+
**Status**: ✅ Fixed
7+
**Date**: 2025-10-15
58

69
## Problem Description
7-
According to ISO 3166-2:YE standard, Yemen should have:
10+
11+
According to the [ISO 3166-2:YE standard](https://www.iso.org/obp/ui#iso:code:3166:YE), Yemen should have:
812
- 21 governorates
913
- 1 municipality (Amanat Al Asimah - the capital)
1014
- **Total: 22 administrative divisions**
@@ -13,9 +17,73 @@ The database previously only had 21 entries total (20 governorates + 1 municipal
1317

1418
## Solution Implemented
1519

16-
### Added Entry
20+
### Ad Dali' Governorate (YE-DA) - Added
21+
1722
Added the missing Ad Dali' governorate to `contributions/states/states.json` with complete data:
1823

24+
**Key Details:**
25+
- ISO 3166-2 code: YE-DA
26+
- Type: Governorate
27+
- Capital: Ad Dali' (الضالع)
28+
- Native name: الضالع
29+
- Coordinates: 13.70°N, 44.73°E
30+
- Timezone: Asia/Aden
31+
- WikiData ID: Q241087
32+
- FIPS code: 10
33+
34+
**Naming variations:**
35+
- English: Ad Dali' (also spelled Ad Dhale', Al Dhale, or Dhale)
36+
- Native Arabic: الضالع
37+
38+
**Translations:**
39+
Provided translations in 18 languages following the pattern of existing Yemen governorates:
40+
- Breton (br), Korean (ko), Portuguese BR (pt-BR), Portuguese (pt)
41+
- Dutch (nl), Croatian (hr), Persian (fa), German (de)
42+
- Spanish (es), French (fr), Japanese (ja), Italian (it)
43+
- Chinese (zh-CN), Turkish (tr), Russian (ru), Ukrainian (uk)
44+
- Polish (pl), Hindi (hi), Arabic (ar)
45+
46+
## Before vs After
47+
48+
| Metric | Before | After |
49+
|--------|--------|-------|
50+
| Yemen States/Governorates | 21 | **22**|
51+
| Governorates | 20 | **21**|
52+
| Municipalities | 1 | 1 |
53+
| ISO Compliance |||
54+
55+
## Complete List of Yemen Administrative Divisions
56+
57+
Now includes all 22 entities as per ISO 3166-2:YE:
58+
59+
### Governorates (21)
60+
1. YE-AB - Abyan
61+
2. YE-AD - Aden ('Adan)
62+
3. YE-AM - Amran ('Amran)
63+
4. YE-BA - Al Bayda'
64+
5. **YE-DA - Ad Dali'** ⭐ NEW
65+
6. YE-DH - Dhamar
66+
7. YE-HD - Hadramawt (Hadhramaut)
67+
8. YE-HJ - Hajjah
68+
9. YE-HU - Al Hudaydah
69+
10. YE-IB - Ibb
70+
11. YE-JA - Al Jawf
71+
12. YE-LA - Lahij
72+
13. YE-MA - Ma'rib
73+
14. YE-MR - Al Mahrah
74+
15. YE-MW - Al Mahwit
75+
16. YE-RA - Raymah
76+
17. YE-SD - Sa'dah (Saada)
77+
18. YE-SH - Shabwah
78+
19. YE-SN - Sana'a
79+
20. YE-SU - Arkhabil Suqutra (Socotra)
80+
21. YE-TA - Ta'izz
81+
82+
### Municipality (1)
83+
22. YE-SA - Amanat Al Asimah (Sana'a Municipality)
84+
85+
## JSON Entry Example
86+
1987
```json
2088
{
2189
"name": "Ad Dali'",
@@ -60,32 +128,6 @@ Added the missing Ad Dali' governorate to `contributions/states/states.json` wit
60128
}
61129
```
62130

63-
### Key Details
64-
65-
**Geographic Information:**
66-
- Latitude: 13.70°N
67-
- Longitude: 44.73°E
68-
- Timezone: Asia/Aden (consistent with other Yemen governorates)
69-
70-
**Identifiers:**
71-
- ISO 3166-2 code: YE-DA
72-
- ISO2: DA
73-
- FIPS code: 10
74-
- WikiData ID: Q241087
75-
76-
**Naming:**
77-
- English: Ad Dali' (also spelled Ad Dhale', Al Dhale, or Dhale)
78-
- Native Arabic: الضالع
79-
- Capital city: Ad Dali'
80-
81-
**Translations:**
82-
Provided translations in 18 languages following the pattern of existing Yemen governorates:
83-
- Breton (br), Korean (ko), Portuguese BR (pt-BR), Portuguese (pt)
84-
- Dutch (nl), Croatian (hr), Persian (fa), German (de)
85-
- Spanish (es), French (fr), Japanese (ja), Italian (it)
86-
- Chinese (zh-CN), Turkish (tr), Russian (ru), Ukrainian (uk)
87-
- Polish (pl), Hindi (hi), Arabic (ar)
88-
89131
## Validation Steps
90132

91133
### 1. Count Verification
@@ -96,10 +138,15 @@ jq '[.[] | select(.country_code == "YE")] | length' contributions/states/states.
96138
# Output: 22 ✅
97139
```
98140

99-
### 2. ISO Code Completeness
100-
Verified all 22 ISO codes are present:
101-
- YE-AB through YE-TA (all present)
102-
- Including the newly added YE-DA ✅
141+
### 2. ISO Code Completeness Check
142+
```bash
143+
# Verify all 22 ISO codes from ISO 3166-2:YE standard are present
144+
# Expected codes: YE-AB, YE-AD, YE-AM, YE-BA, YE-DA (new), YE-DH, YE-HD, YE-HJ,
145+
# YE-HU, YE-IB, YE-JA, YE-LA, YE-MA, YE-MR, YE-MW, YE-RA,
146+
# YE-SA, YE-SD, YE-SH, YE-SN, YE-SU, YE-TA
147+
jq '.[] | select(.country_code == "YE") | .iso3166_2' contributions/states/states.json | sort
148+
# All 22 codes present ✅
149+
```
103150

104151
### 3. JSON Validation
105152
```bash
@@ -108,13 +155,15 @@ python3 -m json.tool contributions/states/states.json > /dev/null
108155
```
109156

110157
### 4. Data Structure Consistency
111-
- Follows the same structure as other Yemen governorates
112-
- All required fields present
113-
- Translations follow the same pattern
114-
- No `id` field included (will be auto-assigned by MySQL)
158+
- ✅ Follows the same structure as other Yemen governorates
159+
- ✅ All required fields present
160+
- ✅ Translations follow the same pattern
161+
- ✅ No `id` field included (will be auto-assigned by MySQL)
162+
- ✅ Matches field types and formats of existing entries
115163

116164
## Files Modified
117-
1. `contributions/states/states.json` - Added 1 new entry
165+
166+
1. **`contributions/states/states.json`** - Added 1 new entry
118167
- Total states increased from 5000 to 5001
119168
- Yemen entries increased from 21 to 22
120169

@@ -139,21 +188,18 @@ python3 -m json.tool contributions/states/states.json > /dev/null
139188
- Provides multilingual names and identifiers
140189

141190
## Historical Context
142-
Ad Dali' (الضالع) is a governorate in southern Yemen. The name is variously transliterated as:
143-
- Ad Dali' (most common)
144-
- Ad Dhale'
145-
- Al Dhale
146-
- Dhale
147191

148-
The governorate's capital city shares the same name. The governorate is located in the southern part of Yemen, bordered by several other governorates.
192+
Ad Dali' (الضالع) is a governorate in southern Yemen. The governorate's capital city shares the same name. The governorate is located in the southern part of Yemen, bordered by several other governorates.
149193

150194
## Next Steps
195+
151196
None required. The fix is complete. GitHub Actions will:
152197
1. Import the JSON to MySQL (ID will be auto-assigned)
153198
2. Generate all export formats (JSON, CSV, SQL, XML, YAML, MongoDB)
154199
3. Update all distribution files
155200

156201
## Notes
202+
157203
- Entry inserted before Dhamar in the JSON array to maintain some logical ordering
158204
- The `id` field is intentionally omitted as per contribution guidelines
159205
- MySQL AUTO_INCREMENT will assign the ID during import

.github/fixes-docs/YEMEN_SUMMARY.md

Lines changed: 0 additions & 71 deletions
This file was deleted.

0 commit comments

Comments
 (0)