Skip to content

Conversation

@yuxiang-he
Copy link
Contributor

@yuxiang-he yuxiang-he commented Nov 17, 2020

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

Changes

  • Specs are regenerated using Stone 3.2.0
  • Fix relative import issues with the breaking change introduced in Stone 2.0.0
  • [breaking change] dropbox.dropbox is now renamed to dropbox.dropbox_client
  • test/requirements.txt now needs Stone as well

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #291 (c6c46a5) into main (50f1d99) will increase coverage by 16.61%.
The diff coverage is 74.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #291       +/-   ##
===========================================
+ Coverage   46.96%   63.58%   +16.61%     
===========================================
  Files          30       30               
  Lines       78958    48223    -30735     
  Branches     6514     3537     -2977     
===========================================
- Hits        37086    30662     -6424     
+ Misses      41821    17533    -24288     
+ Partials       51       28       -23     
Flag Coverage Δ
unit 63.58% <74.25%> (+16.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dropbox/files.py 66.58% <ø> (+19.15%) ⬆️
dropbox/paper.py 70.76% <ø> (+21.03%) ⬆️
dropbox/sharing.py 65.81% <ø> (+19.68%) ⬆️
dropbox/stone_base.py 0.00% <0.00%> (-47.62%) ⬇️
dropbox/stone_serializers.py 0.00% <0.00%> (-18.13%) ⬇️
dropbox/stone_validators.py 0.00% <0.00%> (-45.79%) ⬇️
dropbox/team.py 66.02% <ø> (+19.87%) ⬆️
dropbox/team_log.py 62.82% <ø> (+15.53%) ⬆️
dropbox/file_properties.py 68.92% <69.34%> (+19.94%) ⬆️
dropbox/users.py 62.93% <69.91%> (+21.10%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f1d99...c6c46a5. Read the comment docs.

@yuxiang-he yuxiang-he changed the title Regenerate client using Stone 3.2.0 [WIP] Regenerate client using Stone 3.2.0 Nov 17, 2020
@yuxiang-he
Copy link
Contributor Author

I think we can just skip generating stone_base.py stone_validators.py and stone_serializers.py, but that would most likely be another breaking change in tone

@yuxiang-he yuxiang-he changed the title [WIP] Regenerate client using Stone 3.2.0 Regenerate client using Stone 3.2.0 Nov 17, 2020
Copy link
Contributor

@rogebrd rogebrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is breaking, can you create an UPGRADING.md file similar to UPGRADING.md in order to make sure people know how to upgrade to the new SDK?

Side Note: Glad to see all the removed code

@yuxiang-he yuxiang-he force-pushed the UpdateStoneRequirement branch from 2df27cb to 0f3f47d Compare November 17, 2020 23:18
Copy link
Contributor

@rogebrd rogebrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just need to update the link in UPGRADING.md

@yuxiang-he yuxiang-he merged commit 0f1ad58 into main Nov 18, 2020
@yuxiang-he yuxiang-he deleted the UpdateStoneRequirement branch November 18, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants