-
Notifications
You must be signed in to change notification settings - Fork 328
Regenerate client using Stone 3.2.0 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
===========================================
+ Coverage 46.96% 63.58% +16.61%
===========================================
Files 30 30
Lines 78958 48223 -30735
Branches 6514 3537 -2977
===========================================
- Hits 37086 30662 -6424
+ Misses 41821 17533 -24288
+ Partials 51 28 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think we can just skip generating |
rogebrd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is breaking, can you create an UPGRADING.md file similar to UPGRADING.md in order to make sure people know how to upgrade to the new SDK?
Side Note: Glad to see all the removed code
2df27cb to
0f3f47d
Compare
rogebrd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just need to update the link in UPGRADING.md
Checklist
General Contributing
Is This a Code Change?
Validation
toxpass?Changes
dropbox.dropboxis now renamed todropbox.dropbox_clienttest/requirements.txtnow needs Stone as well