Add FLATCC_ENFORCE_ALIGNED_EMPTY_VECTORS#289
Merged
mikkelfj merged 5 commits intodvidelabs:masterfrom Aug 19, 2024
Merged
Conversation
mikkelfj
reviewed
Aug 16, 2024
Contributor
mikkelfj
left a comment
mikkelfj
left a comment
There was a problem hiding this comment.
That was fast. I don't entirely agree with updating the reader as per my comments inline, but I'm impressed you were able to dig that deep into the code so fast.
I think we should focus on getting the verifier online. We could also do a code review to understand the implications of unligned vectors for the actual code.
Maybe we should rename the flat FLATCC_VERIFIER_TOLERATE_... to indicate that this is then verfier specific.
mikkelfj
reviewed
Aug 18, 2024
Contributor
mikkelfj
left a comment
mikkelfj
left a comment
There was a problem hiding this comment.
I think this looks good, a part from a few minor comments:
Contributor
|
Yeah, I think that is good, aside from the PR title. When you are ready I'll squash and merge. |
bkietz
changed the title
bkietz
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Aug 27, 2024
After dvidelabs/flatcc#289 flatcc will not enforce alignment on empty vectors. This will let us unskip the null_trivial case in the integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An option is added which, if enabled, causes verifier to only require empty vectors be aligned to 4 bytes.
discussion at #287