turns out Google Maps can have more than one listener on an event, so keep track of all of them instead of removing earlier listeners

Author: hxu

src/controllers/angulargmMapController.js

@@ -168,7 +168,9 @@
 
     this._destroy = function() {
       angular.forEach(this._listeners, function(listener) {
-        google.maps.event.removeListener(listener);
+        angular.forEach(listener, function(l) {
+          google.maps.event.removeListener(l);
+        });
       });
       this._listeners = {};
 
@@ -191,10 +193,11 @@
     this.addMapListener = function(event, handler) {
       var listener = google.maps.event.addListener(this._map, event, handler);
 
-      if (this._listeners[event] !== undefined) {
-        google.maps.event.removeListener(this._listeners[event])
+      if (this._listeners[event] === undefined) {
+        this._listeners[event] = [];
       }
-      this._listeners[event] = listener;
+
+      this._listeners[event].push(listener);
     };
 
 

test/unit/controllers/angulargmMapController.js

@@ -121,6 +121,9 @@ describe('angulargmMapController', function() {
     mapCtrl.addMapListenerOnce('center_changed', function() {
       callCount++;
     });
+    // Does not get added to the listeners hash
+    expect(mapCtrl._listeners.center_changed).not.toBeDefined();
+
     google.maps.event.trigger(mapCntr.getMap(scope.gmMapId()), 'center_changed');
     google.maps.event.trigger(mapCntr.getMap(scope.gmMapId()), 'center_changed');
 
@@ -138,20 +141,17 @@ describe('angulargmMapController', function() {
     expect(listeners.center_changed).not.toBeUndefined();
   });
 
-  it('removes listeners if they are overwritten', function() {
-    spyOn(google.maps.event, 'removeListener').andCallThrough();
-
+  it('keeps multiple listeners on an event', function() {
     var aFunc = function() {};
     var anotherFunc = function() {};
 
     mapCtrl.addMapListener('click', aFunc);
     var listener = mapCtrl._listeners.click;
-
     mapCtrl.addMapListener('click', anotherFunc);
-    expect(google.maps.event.removeListener).toHaveBeenCalledWith(listener);
-    expect(mapCtrl._listeners.click).toBeDefined();
-  });
 
+    expect(angular.isArray(mapCtrl._listeners.click)).toBeTruthy();
+    expect(mapCtrl._listeners.click.length).toEqual(2);
+  });
 
   it('adds generic listeners', function() {
     var called = false;