fix #8230: ensure that user tasks model is created before opening it

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

Author: akosyakov

packages/task/src/browser/task-configuration-manager.ts

@@ -185,17 +185,14 @@ export class TaskConfigurationManager {
     protected async doCreate(model: TaskConfigurationModel): Promise<URI | undefined> {
         const content = await this.getInitialConfigurationContent();
         if (content) {
-            await this.folderPreferences.setPreference('tasks', {}, model.getWorkspaceFolder()); // create dummy tasks.json in the correct place
-            const { configUri } = this.folderPreferences.resolve('tasks', model.getWorkspaceFolder()); // get uri to write content to it
-
-            let uri: URI;
-            if (configUri && configUri.path.base === 'tasks.json') {
-                uri = configUri;
-            } else { // fallback
-                uri = new URI(model.getWorkspaceFolder()).resolve(`${this.preferenceConfigurations.getPaths()[0]}/tasks.json`);
+            await model.preferences.setPreference('tasks', {}, model.getWorkspaceFolder()); // create dummy tasks.json in the correct place
+            const { configUri } = model.preferences.resolve('tasks', model.getWorkspaceFolder()); // get uri to write content to it
+
+            if (!configUri || configUri.path.base !== 'tasks.json') {
+                return undefined;
             }
-            await this.fileService.write(uri, content);
-            return uri;
+            await this.fileService.write(configUri, content);
+            return configUri;
         }
     }
 

packages/task/src/browser/task-configuration-model.ts

@@ -36,8 +36,8 @@ export class TaskConfigurationModel implements Disposable {
     );
 
     constructor(
-        public readonly scope: TaskConfigurationScope,
-        protected readonly preferences: PreferenceProvider
+        readonly scope: TaskConfigurationScope,
+        readonly preferences: PreferenceProvider
     ) {
         this.reconcile();
         this.toDispose.push(this.preferences.onDidPreferencesChanged((e: PreferenceProviderDataChanges) => {

packages/task/src/browser/task-configurations.ts

@@ -31,8 +31,6 @@ import { TaskSourceResolver } from './task-source-resolver';
 import { Disposable, DisposableCollection } from '@theia/core/lib/common';
 import { FileChangeType } from '@theia/filesystem/lib/common/filesystem-watcher-protocol';
 import { WorkspaceService } from '@theia/workspace/lib/browser';
-import { OpenerService } from '@theia/core/lib/browser';
-import { UserStorageUri } from '@theia/userstorage/lib/browser/user-storage-uri';
 
 export interface TaskConfigurationClient {
     /**
@@ -42,8 +40,6 @@ export interface TaskConfigurationClient {
     taskConfigurationChanged: (event: string[]) => void;
 }
 
-export const USER_TASKS_URI = UserStorageUri.resolve('tasks.json');
-
 /**
  * Watches a tasks.json configuration file and provides a parsed version of the contained task configurations
  */
@@ -71,9 +67,6 @@ export class TaskConfigurations implements Disposable {
     @inject(WorkspaceService)
     protected readonly workspaceService: WorkspaceService;
 
-    @inject(OpenerService)
-    protected readonly openerService: OpenerService;
-
     @inject(TaskDefinitionRegistry)
     protected readonly taskDefinitionRegistry: TaskDefinitionRegistry;
 
@@ -303,7 +296,7 @@ export class TaskConfigurations implements Disposable {
     }
 
     async openUserTasks(): Promise<void> {
-        await this.openerService.getOpener(USER_TASKS_URI).then(opener => opener.open(USER_TASKS_URI));
+        await this.taskConfigurationManager.openConfiguration(TaskScope.Global);
     }
 
     /** Adds given task to a config file and opens the file to provide ability to edit task configuration. */

packages/task/src/browser/task-schema-updater.ts

@@ -31,7 +31,7 @@ import URI from '@theia/core/lib/common/uri';
 import { ProblemMatcherRegistry } from './task-problem-matcher-registry';
 import { TaskDefinitionRegistry } from './task-definition-registry';
 import { TaskServer } from '../common';
-import { USER_TASKS_URI } from './task-configurations';
+import { UserStorageUri } from '@theia/userstorage/lib/browser';
 
 export const taskSchemaId = 'vscode://schemas/tasks';
 
@@ -62,7 +62,7 @@ export class TaskSchemaUpdater implements JsonSchemaContribution {
             });
         }
         context.registerSchema({
-            fileMatch: ['tasks.json', USER_TASKS_URI.toString()],
+            fileMatch: ['tasks.json', UserStorageUri.resolve('tasks.json').toString()],
             url: taskSchemaUri.toString()
         });