Skip to content

Commit b5bc517

Browse files
repo: add js-debug builtins (#12835)
Due to an issue when publishing the builtin extension-pack for `1.79.0` we need to manually add the `js-debug` and `js-debug-companion` plugins for JavaScript debugging support. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
1 parent f84e7d6 commit b5bc517

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

doc/Migration.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,21 @@ Please see the latest version (`master`) for the most up-to-date information. Pl
99

1010
### General
1111

12+
_Builtin Extension Pack_:
13+
14+
If you are using the [`eclipse-theia.builtin-extension-pack@1.79.0`](https://open-vsx.org/extension/eclipse-theia/builtin-extension-pack) extension pack you may need to include the [`ms-vscode.js-debug`](https://open-vsx.org/extension/ms-vscode/js-debug) and [`ms-vscode.js-debug-companion`](https://open-vsx.org/extension/ms-vscode/js-debug-companion) plugins for JavaScript debug support.
15+
There was an issue when the publishing of the pack which excluded these necessary builtins.
16+
17+
For example, in your application's `package.json`:
18+
19+
```json
20+
"theiaPlugins": {
21+
"eclipse-theia.builtin-extension-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.79.0/file/eclipse-theia.builtin-extension-pack-1.79.0.vsix",
22+
"ms-vscode.js-debug": "https://open-vsx.org/api/ms-vscode/js-debug/1.78.0/file/ms-vscode.js-debug-1.78.0.vsix",
23+
"ms-vscode.js-debug-companion": "https://open-vsx.org/api/ms-vscode/js-debug-companion/1.1.2/file/ms-vscode.js-debug-companion-1.1.2.vsix"
24+
}
25+
```
26+
1227
_msgpackr_:
1328

1429
If you're experiencing [`maximum callstack exceeded`](https://github.com/eclipse-theia/theia/issues/12499) errors you may need to downgrade the version of `msgpackr` pulled using a [yarn resolution](https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/).
@@ -72,15 +87,15 @@ For 2., `@postConstruct` methods can be refactored into a sync and an async meth
7287
```diff
7388
-@postConstruct()
7489
-protected async init(): Promise<void> {
75-
- await longRunningOperation();
90+
- await longRunningOperation();
7691
-}
7792
+@postConstruct()
7893
+protected init(): void {
79-
+ this.doInit();
94+
+ this.doInit();
8095
+}
8196
+
8297
+protected async doInit(): Promise<void> {
83-
+ await longRunningOperation();
98+
+ await longRunningOperation();
8499
+}
85100
```
86101

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@
102102
"theiaPlugins": {
103103
"eclipse-theia.builtin-extension-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.79.0/file/eclipse-theia.builtin-extension-pack-1.79.0.vsix",
104104
"EditorConfig.EditorConfig": "https://open-vsx.org/api/EditorConfig/EditorConfig/0.16.6/file/EditorConfig.EditorConfig-0.16.6.vsix",
105-
"dbaeumer.vscode-eslint": "https://open-vsx.org/api/dbaeumer/vscode-eslint/2.4.2/file/dbaeumer.vscode-eslint-2.4.2.vsix"
105+
"dbaeumer.vscode-eslint": "https://open-vsx.org/api/dbaeumer/vscode-eslint/2.4.2/file/dbaeumer.vscode-eslint-2.4.2.vsix",
106+
"ms-vscode.js-debug": "https://open-vsx.org/api/ms-vscode/js-debug/1.78.0/file/ms-vscode.js-debug-1.78.0.vsix",
107+
"ms-vscode.js-debug-companion": "https://open-vsx.org/api/ms-vscode/js-debug-companion/1.1.2/file/ms-vscode.js-debug-companion-1.1.2.vsix"
106108
},
107109
"theiaPluginsExcludeIds": [
108110
"ms-vscode.js-debug-companion",

0 commit comments

Comments
 (0)