Skip to content

Commit d18b57e

Browse files
committed
fix #8346: don't swallow failed plugin activation error
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
1 parent 6feb470 commit d18b57e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/plugin-ext/src/plugin/plugin-manager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,9 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager {
301301
if (this.pluginActivationPromises.has(plugin.model.id)) {
302302
this.pluginActivationPromises.get(plugin.model.id)!.reject(err);
303303
}
304-
const message = `Activating extension '${plugin.model.displayName || plugin.model.name}' failed: ${err.message}`;
305-
this.messageRegistryProxy.$showMessage(MainMessageType.Error, message, {}, []);
306-
console.error(message);
304+
const message = `Activating extension '${plugin.model.displayName || plugin.model.name}' failed:`;
305+
this.messageRegistryProxy.$showMessage(MainMessageType.Error, message + ' ' + err.message, {}, []);
306+
console.error(message, err);
307307
return false;
308308
} finally {
309309
this.notificationMain.$stopProgress(progressId);

0 commit comments

Comments
 (0)