Fix existence check when contributing monaco menu items (#15746)

tsmaeder · web-flow · commit db383e5326c9 · 2025-06-05T17:24:23.000+02:00
Fixes #15691 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
diff --git a/packages/monaco/src/browser/monaco-menu.ts b/packages/monaco/src/browser/monaco-menu.ts
@@ -49,7 +49,7 @@ export class MonacoEditorMenuContribution implements MenuContribution {
             if (commandId) {
                 const nodeId = MonacoCommands.COMMON_ACTIONS.get(commandId) || commandId;
                 const menuPath = item.group ? [...EDITOR_CONTEXT_MENU, item.group] : EDITOR_CONTEXT_MENU;
-                if (registry.getMenuNode([...menuPath, nodeId])) {
+                if (!registry.getMenuNode([...menuPath, nodeId])) {
                     // Don't add additional actions if the item is already registered.
                     registry.registerMenuAction(menuPath, this.buildMenuAction(commandId, item));
                 }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export class MonacoEditorMenuContribution implements MenuContribution {`
`49`	`49`	`if (commandId) {`
`50`	`50`	`const nodeId = MonacoCommands.COMMON_ACTIONS.get(commandId) \|\| commandId;`
`51`	`51`	`const menuPath = item.group ? [...EDITOR_CONTEXT_MENU, item.group] : EDITOR_CONTEXT_MENU;`
`52`		`- if (registry.getMenuNode([...menuPath, nodeId])) {`
	`52`	`+ if (!registry.getMenuNode([...menuPath, nodeId])) {`
`53`	`53`	`// Don't add additional actions if the item is already registered.`
`54`	`54`	`registry.registerMenuAction(menuPath, this.buildMenuAction(commandId, item));`
`55`	`55`	`}`