From ce1ead4f9b68ff9d86ead93fb066b8677fb703f6 Mon Sep 17 00:00:00 2001 From: Cristhian Garcia <33465240+Ian2012@users.noreply.github.com> Date: Fri, 3 Jun 2022 10:46:46 -0500 Subject: [PATCH 1/3] fix: dynamically generated unverified cert data (#30365) --- lms/djangoapps/courseware/views/views.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lms/djangoapps/courseware/views/views.py b/lms/djangoapps/courseware/views/views.py index 74517f91e2..d412aa302f 100644 --- a/lms/djangoapps/courseware/views/views.py +++ b/lms/djangoapps/courseware/views/views.py @@ -1295,15 +1295,12 @@ def _certificate_message(student, course, enrollment_mode): # lint-amnesty, pyl if cert_downloadable_status['is_generating']: return GENERATING_CERT_DATA - if cert_downloadable_status['is_unverified']: + if cert_downloadable_status['is_unverified'] or _missing_required_verification(student, enrollment_mode): return _unverified_cert_data() if cert_downloadable_status['is_downloadable']: return _downloadable_certificate_message(course, cert_downloadable_status) - if _missing_required_verification(student, enrollment_mode): - return _unverified_cert_data() - return REQUESTING_CERT_DATA From e8c12e8f28c71e6bbefe62c766c2669e302da55c Mon Sep 17 00:00:00 2001 From: Maria Fernanda Magallanes Zubillaga Date: Thu, 22 Dec 2022 15:51:12 -0400 Subject: [PATCH 2/3] fix: allow downloadable condition before missing required verification --- lms/djangoapps/courseware/views/views.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lms/djangoapps/courseware/views/views.py b/lms/djangoapps/courseware/views/views.py index d412aa302f..74517f91e2 100644 --- a/lms/djangoapps/courseware/views/views.py +++ b/lms/djangoapps/courseware/views/views.py @@ -1295,12 +1295,15 @@ def _certificate_message(student, course, enrollment_mode): # lint-amnesty, pyl if cert_downloadable_status['is_generating']: return GENERATING_CERT_DATA - if cert_downloadable_status['is_unverified'] or _missing_required_verification(student, enrollment_mode): + if cert_downloadable_status['is_unverified']: return _unverified_cert_data() if cert_downloadable_status['is_downloadable']: return _downloadable_certificate_message(course, cert_downloadable_status) + if _missing_required_verification(student, enrollment_mode): + return _unverified_cert_data() + return REQUESTING_CERT_DATA From 9da150a7df20ffc51c9d2be44f5a2fe45f8630ee Mon Sep 17 00:00:00 2001 From: henrrypg Date: Mon, 26 Dec 2022 11:52:04 -0500 Subject: [PATCH 3/3] fix: tab typo in get custom context --- openedx/core/djangoapps/user_api/accounts/settings_views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openedx/core/djangoapps/user_api/accounts/settings_views.py b/openedx/core/djangoapps/user_api/accounts/settings_views.py index a1e65e5677..1ba4ead4a7 100644 --- a/openedx/core/djangoapps/user_api/accounts/settings_views.py +++ b/openedx/core/djangoapps/user_api/accounts/settings_views.py @@ -111,7 +111,7 @@ def _get_custom_context(self, extended_profile_fields): if options: field_options[field_name] = options - return field_options, field_labels + return field_options, field_labels class AccountSettingsRenderStarted(OpenEdxPublicFilter):