From 9bf71e93848d716fe64137786a8b14d8f3bf3935 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Tue, 16 Dec 2025 16:29:25 -0800 Subject: [PATCH 1/2] fix(template): add `private: true` --- packages/template/base/tmpl/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/template/base/tmpl/package.json b/packages/template/base/tmpl/package.json index ec4b7f596b..25b32b1ff2 100644 --- a/packages/template/base/tmpl/package.json +++ b/packages/template/base/tmpl/package.json @@ -4,6 +4,7 @@ "version": "1.0.0", "description": "My Electron application description", "main": "src/index.js", + "private": true, "scripts": { "start": "electron-forge start", "package": "electron-forge package", From a866ddc94aacb62b4fd909e0047692e7d9ceb08e Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Wed, 17 Dec 2025 15:26:02 -0800 Subject: [PATCH 2/2] add regression tests --- packages/api/core/spec/slow/api.slow.spec.ts | 9 +++++++++ .../spec/ViteTypeScriptTemplate.slow.spec.ts | 9 +++++++++ .../spec/WebpackTypeScript.slow.spec.ts | 9 +++++++++ 3 files changed, 27 insertions(+) diff --git a/packages/api/core/spec/slow/api.slow.spec.ts b/packages/api/core/spec/slow/api.slow.spec.ts index 352882e436..be7a356d69 100644 --- a/packages/api/core/spec/slow/api.slow.spec.ts +++ b/packages/api/core/spec/slow/api.slow.spec.ts @@ -217,6 +217,15 @@ describe.each([ expect(fs.existsSync(path.join(dir, 'forge.config.js'))).toEqual(true); }); + it('should contain `private:true` in package.json', async () => { + const packageJSONString = await fs.promises.readFile( + path.join(dir, 'package.json'), + 'utf-8', + ); + const packageJSON = JSON.parse(packageJSONString); + expect(packageJSON).toHaveProperty('private', true); + }); + describe('lint', () => { it('should initially pass the linting process', () => expectLintToPass(dir)); diff --git a/packages/template/vite-typescript/spec/ViteTypeScriptTemplate.slow.spec.ts b/packages/template/vite-typescript/spec/ViteTypeScriptTemplate.slow.spec.ts index 79a3e228b5..992cf89ce5 100644 --- a/packages/template/vite-typescript/spec/ViteTypeScriptTemplate.slow.spec.ts +++ b/packages/template/vite-typescript/spec/ViteTypeScriptTemplate.slow.spec.ts @@ -59,6 +59,15 @@ describe('ViteTypeScriptTemplate', () => { const jsFiles = await glob(path.join(dir, 'src', '**', '*.js')); expect(jsFiles.length).toEqual(0); }); + + it('should contain `private:true` in package.json', async () => { + const packageJSONString = await fs.promises.readFile( + path.join(dir, 'package.json'), + 'utf-8', + ); + const packageJSON = JSON.parse(packageJSONString); + expect(packageJSON).toHaveProperty('private', true); + }); }); describe('lint', () => { diff --git a/packages/template/webpack-typescript/spec/WebpackTypeScript.slow.spec.ts b/packages/template/webpack-typescript/spec/WebpackTypeScript.slow.spec.ts index 700e0ce03a..ccfeffb309 100644 --- a/packages/template/webpack-typescript/spec/WebpackTypeScript.slow.spec.ts +++ b/packages/template/webpack-typescript/spec/WebpackTypeScript.slow.spec.ts @@ -51,6 +51,15 @@ describe('WebpackTypeScriptTemplate', () => { expect(jsFiles.length).toEqual(0); }); + it('should contain `private:true` in package.json', async () => { + const packageJSONString = await fs.promises.readFile( + path.join(dir, 'package.json'), + 'utf-8', + ); + const packageJSON = JSON.parse(packageJSONString); + expect(packageJSON).toHaveProperty('private', true); + }); + describe('lint', () => { it('should initially pass the linting process', async () => { delete process.env.TS_NODE_PROJECT;