fix: build and copy to bin/platform directory

Author: aminya

.github/workflows/CI.yml

@@ -35,9 +35,7 @@ jobs:
       - name: Upload artifacts
         uses: actions/upload-artifact@v2
         with:
-          path: |
-            ./build
-            ./deps
+          path: ./bin
 
   Skip:
     if: contains(github.event.head_commit.message, '[skip ci]')

.gitignore

@@ -2,3 +2,4 @@
 /build
 *.swp
 npm-debug.log
+bin

build.js

@@ -2,20 +2,19 @@ const fs = require('fs')
 const path = require('path')
 const childProcess = require('child_process')
 
-// exe paths
 const exe = process.platform === 'win32' ? '.exe' : ''
-const minidumpStackwalk = path.resolve(__dirname, 'build', 'src', 'processor', 'minidump_stackwalk') + exe
-const minidumpDump = path.resolve(__dirname, 'build', 'src', 'processor', 'minidump_dump') + exe
-const dumpSyms = (() => {
-  if (process.platform === 'darwin') {
-    return path.resolve(__dirname, 'deps', 'breakpad', 'src', 'tools', 'mac', 'dump_syms', 'build', 'Release', 'dump_syms')
-  } else if (process.platform === 'linux') {
-    return path.resolve(__dirname, 'build', 'src', 'tools', 'linux', 'dump_syms', 'dump_syms')
-  }
-})()
+const binDir = path.join(__dirname, 'bin', process.platform)
+
+const minidumpStackwalkDest = path.join(binDir, 'minidump_stackwalk') + exe
+const minidumpDumpDest = path.join(binDir, 'minidump_dump') + exe
+const dumpSymsDest = path.join(binDir, 'dump_syms') + exe
 
 // do not build if executables already exist
-if (fs.existsSync(minidumpStackwalk) && fs.existsSync(minidumpDump) && fs.existsSync(dumpSyms)) {
+if (
+  fs.existsSync(minidumpStackwalkDest) &&
+  fs.existsSync(minidumpDumpDest) &&
+  fs.existsSync(dumpSymsDest)
+) {
   process.exit(0)
 }
 
@@ -53,3 +52,23 @@ if (process.platform === 'darwin') {
     stdio: 'inherit'
   })
 }
+
+// copy to bin folder
+if (!fs.existsSync(binDir)) {
+  fs.mkdirSync(binDir, { recursive: true })
+}
+
+const minidumpStackwalk = path.resolve(__dirname, 'build', 'src', 'processor', 'minidump_stackwalk') + exe
+fs.copyFileSync(minidumpStackwalk, minidumpStackwalkDest)
+
+const minidumpDump = path.resolve(__dirname, 'build', 'src', 'processor', 'minidump_dump') + exe
+fs.copyFileSync(minidumpDump, minidumpDumpDest)
+
+const dumpSyms = (() => {
+  if (process.platform === 'darwin') {
+    return path.resolve(__dirname, 'deps', 'breakpad', 'src', 'tools', 'mac', 'dump_syms', 'build', 'Release', 'dump_syms')
+  } else if (process.platform === 'linux') {
+    return path.resolve(__dirname, 'build', 'src', 'tools', 'linux', 'dump_syms', 'dump_syms')
+  }
+})()
+fs.copyFileSync(dumpSyms, dumpSymsDest)

lib/minidump.js

@@ -4,16 +4,12 @@ const spawn = require('child_process').spawn
 const format = require('./format')
 
 const exe = process.platform === 'win32' ? '.exe' : ''
+const binDir = path.join(__dirname, 'bin', process.platform)
+
 const commands = {
-  minidump_stackwalk: path.resolve(__dirname, '..', 'build', 'src', 'processor', 'minidump_stackwalk') + exe,
-  minidump_dump: path.resolve(__dirname, '..', 'build', 'src', 'processor', 'minidump_dump') + exe,
-  dump_syms: (() => {
-    if (process.platform === 'darwin') {
-      return path.resolve(__dirname, '..', 'deps', 'breakpad', 'src', 'tools', 'mac', 'dump_syms', 'build', 'Release', 'dump_syms')
-    } else if (process.platform === 'linux') {
-      return path.resolve(__dirname, '..', 'build', 'src', 'tools', 'linux', 'dump_syms', 'dump_syms')
-    }
-  })()
+  minidump_stackwalk: path.join(binDir, 'minidump_stackwalk') + exe,
+  minidump_dump: path.join(binDir, 'minidump_dump') + exe,
+  dump_syms: path.join(binDir, 'dump_syms') + exe
 }
 
 function execute (command, args, callback) {

package.json

@@ -35,10 +35,6 @@
     "index.d.ts",
     "build.js",
     "deps",
-    "./build/src/processor/minidump_stackwalk",
-    "./build/src/processor/minidump_stackwalk.exe",
-    "./build/src/processor/minidump_dump",
-    "./build/src/processor/minidump_dump.exe",
-    "./build/src/tools/linux/dump_syms/dump_syms"
+    "bin"
   ]
 }