Skip to content

Commit 1500733

Browse files
Replace usage of deprecated assertEquals with assertEqual (#19345)
1 parent cd252db commit 1500733

File tree

6 files changed

+16
-15
lines changed

6 files changed

+16
-15
lines changed

changelog.d/19345.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Replace usage of deprecated `assertEquals` with `assertEqual` in unit test code.

tests/handlers/test_oauth_delegation.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -889,11 +889,11 @@ def test_simple_introspection(self) -> None:
889889
)
890890
)
891891

892-
self.assertEquals(requester.user.to_string(), USER_ID)
893-
self.assertEquals(requester.device_id, DEVICE)
892+
self.assertEqual(requester.user.to_string(), USER_ID)
893+
self.assertEqual(requester.device_id, DEVICE)
894894
self.assertFalse(self.get_success(self._auth.is_server_admin(requester)))
895895

896-
self.assertEquals(
896+
self.assertEqual(
897897
self.server.last_token_seen,
898898
"some_token",
899899
)
@@ -912,11 +912,11 @@ def test_unexpiring_token(self) -> None:
912912
)
913913
)
914914

915-
self.assertEquals(requester.user.to_string(), USER_ID)
916-
self.assertEquals(requester.device_id, DEVICE)
915+
self.assertEqual(requester.user.to_string(), USER_ID)
916+
self.assertEqual(requester.device_id, DEVICE)
917917
self.assertFalse(self.get_success(self._auth.is_server_admin(requester)))
918918

919-
self.assertEquals(
919+
self.assertEqual(
920920
self.server.last_token_seen,
921921
"some_token",
922922
)

tests/rest/admin/test_room.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3362,7 +3362,7 @@ def test_v12_room(self) -> None:
33623362
pl = self.helper.get_state(
33633363
room_id, EventTypes.PowerLevels, tok=self.creator_tok
33643364
)
3365-
self.assertEquals(pl["users"][self.admin_user], 100)
3365+
self.assertEqual(pl["users"][self.admin_user], 100)
33663366

33673367
def test_v12_room_with_many_user_pls(self) -> None:
33683368
"""Test that you can be promoted to the admin user's PL in v12 rooms that contain a range of user PLs."""
@@ -3395,7 +3395,7 @@ def test_v12_room_with_many_user_pls(self) -> None:
33953395
pl = self.helper.get_state(
33963396
room_id, EventTypes.PowerLevels, tok=self.creator_tok
33973397
)
3398-
self.assertEquals(pl["users"][self.admin_user], 100)
3398+
self.assertEqual(pl["users"][self.admin_user], 100)
33993399

34003400

34013401
class BlockRoomTestCase(unittest.HomeserverTestCase):

tests/state/test_v21.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ def resolve_and_check() -> None:
447447
)
448448
)
449449
# no matter how many events are persisted, the overall diff should always be the same.
450-
self.assertEquals(got_auth_diff, got_auth_diff2)
450+
self.assertEqual(got_auth_diff, got_auth_diff2)
451451

452452
# now we will drip feed in `events` one-by-one, persisting them then resolving with the
453453
# rest. This ensures we correctly handle mixed persisted/unpersisted events. We will finish

tests/storage/test_event_federation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ def run_test(txn: LoggingTransaction, test_case: TestCase) -> None:
909909
test_case.conflicted,
910910
test_case.additional_backwards_reachable,
911911
)
912-
self.assertEquals(
912+
self.assertEqual(
913913
result.conflicted_subgraph,
914914
test_case.want_conflicted_subgraph,
915915
f"{test_case.name} : conflicted subgraph mismatch",

tests/types/test_init.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ class RoomIDTestCase(TestCase):
88
def test_can_create_msc4291_room_ids(self) -> None:
99
valid_msc4291_room_id = "!31hneApxJ_1o-63DmFrpeqnkFfWppnzWso1JvH3ogLM"
1010
room_id = RoomID.from_string(valid_msc4291_room_id)
11-
self.assertEquals(RoomID.is_valid(valid_msc4291_room_id), True)
12-
self.assertEquals(
11+
self.assertEqual(RoomID.is_valid(valid_msc4291_room_id), True)
12+
self.assertEqual(
1313
room_id.to_string(),
1414
valid_msc4291_room_id,
1515
)
16-
self.assertEquals(room_id.id, "!31hneApxJ_1o-63DmFrpeqnkFfWppnzWso1JvH3ogLM")
17-
self.assertEquals(room_id.get_domain(), None)
16+
self.assertEqual(room_id.id, "!31hneApxJ_1o-63DmFrpeqnkFfWppnzWso1JvH3ogLM")
17+
self.assertEqual(room_id.get_domain(), None)
1818

1919
def test_cannot_create_invalid_msc4291_room_ids(self) -> None:
2020
invalid_room_ids = [
@@ -47,5 +47,5 @@ def test_can_create_valid_legacy_room_ids(self) -> None:
4747
]
4848
for room_id_str in valid_room_ids:
4949
room_id = RoomID.from_string(room_id_str)
50-
self.assertEquals(RoomID.is_valid(room_id_str), True)
50+
self.assertEqual(RoomID.is_valid(room_id_str), True)
5151
self.assertIsNotNone(room_id.get_domain())

0 commit comments

Comments
 (0)