stm32: remove internal-only _allow-disable-rtc.

Author: Dirbaio

embassy-stm32/Cargo.toml

@@ -348,7 +348,6 @@ gpio-init-analog = []
 
 ## internal use only
 _split-pins-enabled = []
-_allow-disable-rtc = []
 
 ## internal use only
 _dual-core = []

embassy-stm32/src/rtc/mod.rs

@@ -176,21 +176,13 @@ pub struct RtcConfig {
     ///
     /// A high counter frequency may impact stop power consumption
     pub frequency: Hertz,
-
-    #[cfg(feature = "_allow-disable-rtc")]
-    /// Allow disabling the rtc, even when stop is configured
-    pub _disable_rtc: bool,
 }
 
 impl Default for RtcConfig {
     /// LSI with prescalers assuming 32.768 kHz.
     /// Raw sub-seconds in 1/256.
     fn default() -> Self {
-        RtcConfig {
-            frequency: Hertz(256),
-            #[cfg(feature = "_allow-disable-rtc")]
-            _disable_rtc: false,
-        }
+        RtcConfig { frequency: Hertz(256) }
     }
 }
 
@@ -451,11 +443,6 @@ trait SealedInstance {
 pub(crate) fn init_rtc(cs: CriticalSection, config: RtcConfig, min_stop_pause: embassy_time::Duration) {
     use crate::time_driver::{LPTimeDriver, get_driver};
 
-    #[cfg(feature = "_allow-disable-rtc")]
-    if config._disable_rtc {
-        return;
-    }
-
     get_driver().set_rtc(cs, Rtc::new_inner(config));
     get_driver().set_min_stop_pause(cs, min_stop_pause);
 

tests/stm32/Cargo.toml

@@ -77,7 +77,7 @@ teleprobe-meta = "1"
 embassy-sync = { version = "0.8.0", path = "../../embassy-sync", features = ["defmt"] }
 embassy-executor = { version = "0.10.0", path = "../../embassy-executor", features = ["defmt"] }
 embassy-time = { version = "0.5.1", path = "../../embassy-time", features = ["defmt", "tick-hz-131_072", "defmt-timestamp-uptime"] }
-embassy-stm32 = { version = "0.6.0", path = "../../embassy-stm32", features = [ "defmt", "unstable-pac", "memory-x", "time-driver-any", "_allow-disable-rtc"]  }
+embassy-stm32 = { version = "0.6.0", path = "../../embassy-stm32", features = [ "defmt", "unstable-pac", "memory-x", "time-driver-any"]  }
 embassy-futures = { version = "0.1.2", path = "../../embassy-futures" }
 embassy-stm32-wpan = { version = "0.1.0", path = "../../embassy-stm32-wpan", optional = true, features = ["defmt", "stm32wb55rg", "wb55_ble"] }
 embassy-net = { version = "0.9.0", path = "../../embassy-net", features = ["defmt",  "tcp", "udp", "dhcpv4", "medium-ethernet"] }

tests/stm32/src/bin/rtc.rs

@@ -23,10 +23,6 @@ use embassy_time::Timer;
 async fn main(_spawner: Spawner) {
     let mut config = config();
     config.rcc.ls = LsConfig::default_lse();
-    #[cfg(feature = "stop")]
-    {
-        config.rtc._disable_rtc = false;
-    }
 
     let p = init_with_config(config);
     info!("Hello World!");

tests/stm32/src/bin/stop.rs

@@ -51,7 +51,6 @@ async fn async_main(spawner: Spawner) {
 
     let mut config = Config::default();
     config.rcc.ls = LsConfig::default_lse();
-    config.rtc._disable_rtc = false;
 
     // System Clock seems cannot be greater than 16 MHz
     #[cfg(any(feature = "stm32h563zi", feature = "stm32h503rb"))]

tests/stm32/src/bin/timer.rs

@@ -19,10 +19,6 @@ async fn main(_spawner: Spawner) {
     let _p = init();
     info!("Hello World!");
 
-    // TODO: investigate. Test fails with low-power executor.
-    #[cfg(all(feature = "stop", feature = "stm32h563zi"))]
-    let _guard = embassy_stm32::rcc::WakeGuard::new(embassy_stm32::rcc::StopMode::Stop1);
-
     let start = Instant::now();
     Timer::after_millis(100).await;
     let end = Instant::now();

tests/stm32/src/common.rs

@@ -623,8 +623,6 @@ pub fn config() -> Config {
         config.rcc.apb3_pre = APBPrescaler::DIV1;
         config.rcc.sys = Sysclk::PLL1_P;
         config.rcc.voltage_scale = VoltageScale::Scale0;
-
-        config.rtc._disable_rtc = true;
     }
 
     #[cfg(feature = "stm32h503rb")]