move onerror-per-visit test to scenario-tester

Author: mansona

packages/fastboot/test/fastboot-test.js

@@ -337,125 +337,6 @@ describe('FastBoot', function() {
     });
   });
 
-  it('errors can be properly attributed with buildSandboxPerVisit=true', async function() {
-    this.timeout(3000);
-
-    var fastboot = new FastBoot({
-      distPath: fixture('onerror-per-visit'),
-    });
-
-    let first = fastboot.visit('/slow/100/reject', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/100/reject', headers: {} },
-    });
-
-    let second = fastboot.visit('/slow/50/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/50/resolve', headers: {} },
-    });
-
-    let third = fastboot.visit('/slow/25/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/25/resolve', headers: {} },
-    });
-
-    await Promise.all([second, third]);
-
-    await first.then(
-      () => {
-        throw new Error('Visit should not resolve!');
-      },
-      error => {
-        expect(error.code).to.equal('from-slow');
-        expect(error.fastbootRequestPath).to.equal('/slow/100/reject');
-      }
-    );
-  });
-
-  it('it eagerly builds sandbox when queue is empty', async function() {
-    this.timeout(3000);
-
-    var fastboot = new FastBoot({
-      distPath: fixture('onerror-per-visit'),
-      maxSandboxQueueSize: 2,
-    });
-
-    let first = fastboot.visit('/slow/50/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/50/resolve', headers: {} },
-    });
-
-    let second = fastboot.visit('/slow/50/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/50/resolve', headers: {} },
-    });
-
-    let third = fastboot.visit('/slow/25/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/25/resolve', headers: {} },
-    });
-
-    let result = await first;
-    let analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: true,
-    });
-
-    result = await second;
-    analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: true,
-    });
-
-    result = await third;
-    analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: false,
-    });
-  });
-
-  it('it leverages sandbox from queue when present', async function() {
-    this.timeout(3000);
-
-    var fastboot = new FastBoot({
-      distPath: fixture('onerror-per-visit'),
-      maxSandboxQueueSize: 3,
-    });
-
-    let first = fastboot.visit('/slow/50/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/50/resolve', headers: {} },
-    });
-
-    let second = fastboot.visit('/slow/50/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/50/resolve', headers: {} },
-    });
-
-    let third = fastboot.visit('/slow/25/resolve', {
-      buildSandboxPerVisit: true,
-      request: { url: '/slow/25/resolve', headers: {} },
-    });
-
-    let result = await first;
-    let analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: true,
-    });
-
-    result = await second;
-    analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: true,
-    });
-
-    result = await third;
-    analytics = result.analytics;
-    expect(analytics).to.be.deep.equals({
-      usedPrebuiltSandbox: true,
-    });
-  });
-
   it('htmlEntrypoint works', function() {
     var fastboot = new FastBoot({
       distPath: fixture('html-entrypoint'),