Skip to content

Extract CI Jobs to a reusable workflow + refactor to put all publish jobs in one file #20989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kategengler merged 2 commits into from
Sep 29, 2025
Merged

Extract CI Jobs to a reusable workflow + refactor to put all publish jobs in one file #20989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f6172
Extract CI Jobs to a reusable workflow
kategengler Sep 29, 2025
1c56cfb
Refactor workflows so that only one pushes to npm because OIDC is
kategengler Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 10 additions & 47 deletions .github/workflows/alpha-releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,21 @@ on:
workflow_dispatch:

jobs:
test:
name: Basic Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
run: pnpm vite build --mode=development
- name: test
run: pnpm test
tests:
uses: ./.github/workflows/ci-jobs.yml

release:
permissions:
contents: write # to push tag
id-token: write
contents: read # PAT used for push

name: Tag + Release
name: Tag + Push
runs-on: ubuntu-latest
needs: [test]
needs: [ tests ]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: '20'
- name: Update npm
run: npm install -g npm@latest # npm >= 11.5.1 is needed
persist-credentials: false
- uses: ./.github/actions/setup
- name: setup git
run: |
git config --local user.email 'tomster@emberjs.com'
Expand All @@ -44,33 +33,7 @@ jobs:
- name: bump version
run: npm version ${{env.NEXT_ALPHA}} --allow-same-version --no-git-tag-version
- name: create tag
run: git tag v${{env.NEXT_ALPHA}}-ember-source
- name: build for publish
env:
BUILD_TYPE: alpha
OVERRIDE_FEATURES: ''
run: node bin/build-for-publishing.js
- name: publish to npm
run: npm publish
run: git tag v${{env.NEXT_ALPHA}}-ember-source
- name: push tag
# Push in a way that will NOT trigger other workflows
run: git push origin v${{env.NEXT_ALPHA}}-ember-source

notify:
name: Notify Discord
runs-on: ubuntu-latest
needs:
[
test,
release,
]
if: failure()
steps:
- uses: sarisia/actions-status-discord@v1
with:
webhook: ${{ secrets.FRAMEWORK_WEBHOOK }}
status: 'Failure'
title: 'Ember.js Alpha Release'
color: 0xcc0000
url: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}'
username: GitHub Actions
# Push in a way that WILL trigger other workflows
run: git push https://${GITHUB_ACTOR}:${{ secrets.PERSONAL_TOKEN }}@github.com/${GITHUB_REPOSITORY} v${{env.NEXT_ALPHA}}-ember-source
186 changes: 186 additions & 0 deletions .github/workflows/ci-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
name: Reusable CI Jobs

on:
workflow_call:

permissions:
contents: read

jobs:
lint:
name: Linting
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: linting
run: pnpm lint
- id: set-matrix
working-directory: smoke-tests/scenarios
run: |
matrix_json=$(pnpm scenario-tester list --require @swc-node/register --files "*-test.ts" --matrix "pnpm run test --filter %s" )
echo "matrix=$matrix_json" >> $GITHUB_OUTPUT

types:
name: Type Checking (current version)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build types
run: pnpm build:types
- name: Check published and internal types
run: pnpm type-check

types-range:
name: Type Checking (other supported versions)
runs-on: ubuntu-latest
needs: [ 'types' ]
strategy:
matrix:
ts-version: [ '5.2', '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9' ]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build stable type definitions
run: pnpm build:types
- name: install TS@${{matrix.ts-version}}
run: pnpm add --save-dev --workspace-root typescript@${{ matrix.ts-version }}
- name: Check published and internal types with TS@${{matrix.ts-version}}
run: pnpm type-check

basic-test:
name: Basic Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
run: pnpm vite build --mode=development
- name: test
run: pnpm test

variant-tests:
name: ${{ matrix.name }}
runs-on: ubuntu-latest
needs: [ basic-test, lint, types ]
strategy:
matrix:
include:
- name: "All deprecations enabled"
ALL_DEPRECATIONS_ENABLED: "true"
- name: "All deprecations enabled, with optional features"
ALL_DEPRECATIONS_ENABLED: "true"
ENABLE_OPTIONAL_FEATURES: "true"
- name: "Deprecations as errors"
OVERRIDE_DEPRECATION_VERSION: "15.0.0"
- name: "Deprecations as errors, with optional features"
OVERRIDE_DEPRECATION_VERSION: "15.0.0"
ENABLE_OPTIONAL_FEATURES: "true"
- name: "Production build"
BUILD: "production"
- name: "Production build, with optional features"
BUILD: "production"
ENABLE_OPTIONAL_FEATURES: "true"

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
run: pnpm vite build --mode=${{ matrix.BUILD || 'development' }}
- name: test
env:
ALL_DEPRECATIONS_ENABLED: ${{ matrix.ALL_DEPRECATIONS_ENABLED }}
OVERRIDE_DEPRECATION_VERSION: ${{ matrix.OVERRIDE_DEPRECATION_VERSION }}
ENABLE_OPTIONAL_FEATURES: ${{ matrix.ENABLE_OPTIONAL_FEATURES }}
RAISE_ON_DEPRECATION: ${{ matrix.RAISE_ON_DEPRECATION }}

run: pnpm test

browserstack-test:
name: Browserstack Tests (Safari, Edge)
runs-on: ubuntu-latest
needs: [ basic-test, lint, types ]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
env:
ALL_SUPPORTED_BROWSERS: true
run: pnpm vite build --mode=development

- name: Set BrowserStack Local Identifier
if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-ember-source')
run: |
BROWSERSTACK_LOCAL_IDENTIFIER="$GITHUB_RUN_ID-$GITHUB_RUN_ATTEMPT"
echo "BROWSERSTACK_LOCAL_IDENTIFIER=$BROWSERSTACK_LOCAL_IDENTIFIER" >> $GITHUB_ENV

- name: test:browserstack
env:
BROWSERSTACK_USERNAME: emberjscoreteam1
# This is in plaintext on purpose. It has no privileged access to anything (this is a free
# account) and it allows us to run browserstack tests against PRs.
BROWSERSTACK_ACCESS_KEY: o5LNEdygq1SP4L9kst4s
run: pnpm test:browserstack

smoke-test:
name: Smoke tests (Full Ember Apps)
runs-on: ubuntu-latest
needs: [basic-test, lint, types]
strategy:
fail-fast: false
matrix: ${{fromJson(needs.lint.outputs.matrix)}}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
use_lockfile: "false"
- name: build
run: pnpm build
- name: test
working-directory: smoke-tests/scenarios
run: |
${{ matrix.command }}

node-test:
name: Node.js Tests
runs-on: ubuntu-latest
needs: [basic-test, lint, types]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
env:
SHOULD_TRANSPILE_FOR_NODE: true
run: pnpm build
- name: test
run: pnpm test:node

blueprint-test:
name: Blueprint Tests
runs-on: ubuntu-latest
needs: [lint]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: test
run: pnpm test:blueprints

browser-test:
name: Browser Tests (Firefox)
runs-on: ubuntu-22.04 # Firefox is not installing on Ubuntu 24 on GitHub Actions https://github.com/browser-actions/setup-firefox/issues/622
needs: [basic-test, lint, types]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: build
run: pnpm vite build --mode=development
- name: Setup firefox
uses: browser-actions/setup-firefox@latest
with:
firefox-version: 115.9.1esr
- run: firefox --version
- name: test
run: pnpm ember test --path dist -c testem.ci-browsers.js
Loading
Loading