From 1f1684d5f74a2f452845bbe183daf3e26a690bc7 Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Mon, 6 Jul 2026 10:14:56 -0700 Subject: [PATCH 1/2] Temporarily skip tests to allow Binaryen roll https://github.com/WebAssembly/binaryen/pull/8880 updated Binaryen to no longer escape function names stored in the IR. This means that directly printed function names are no longer escaped. An error message was also tweaked to improve readability. These changes break Emscripten tests, so temporarily skip those tests to allow the Binaryen roll to proceed. A follow-on change after the roll will update and re-enable the tests. --- test/test_other.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test_other.py b/test/test_other.py index 4e7cd200f1541..f1b0dffd52475 100644 --- a/test/test_other.py +++ b/test/test_other.py @@ -10610,6 +10610,7 @@ def test_asyncify_escaping(self): self.assertContained('Try using a response file', proc.stderr) def test_asyncify_response_file(self): + self.skipTest('Expected error message needs updating after the Binaryen roll') create_file('a.txt', r'''[ "DOS_ReadFile(unsigned short, unsigned char*, unsigned short*, bool)" ] @@ -15525,6 +15526,7 @@ def test_create_preloaded_file(self): @crossplatform def test_empath_split(self): + self.skipTest('Needs updates after Binaryen roll changes function name escaping') create_file('main.cpp', r''' #include void foo(); From 354bb8d935aabac1d5ead21bae66a161c6c624bf Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Mon, 6 Jul 2026 10:30:22 -0700 Subject: [PATCH 2/2] use @disabled --- test/test_other.py | 4 ++-- test/third_party/googletest | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_other.py b/test/test_other.py index f1b0dffd52475..ba2679a753110 100644 --- a/test/test_other.py +++ b/test/test_other.py @@ -10609,8 +10609,8 @@ def test_asyncify_escaping(self): self.assertContained(' DOS_ReadFile(unsigned short', proc.stderr) self.assertContained('Try using a response file', proc.stderr) + @disabled('Expected error message needs updating after the Binaryen roll') def test_asyncify_response_file(self): - self.skipTest('Expected error message needs updating after the Binaryen roll') create_file('a.txt', r'''[ "DOS_ReadFile(unsigned short, unsigned char*, unsigned short*, bool)" ] @@ -15525,8 +15525,8 @@ def test_create_preloaded_file(self): self.do_runf('main.c', 'done\n', cflags=['-sFORCE_FILESYSTEM', '--post-js=post.js']) @crossplatform + @disabled('Needs updates after Binaryen roll changes function name escaping') def test_empath_split(self): - self.skipTest('Needs updates after Binaryen roll changes function name escaping') create_file('main.cpp', r''' #include void foo(); diff --git a/test/third_party/googletest b/test/third_party/googletest index 52eb8108c5bde..b514bdc898e29 160000 --- a/test/third_party/googletest +++ b/test/third_party/googletest @@ -1 +1 @@ -Subproject commit 52eb8108c5bdec04579160ae17225d66034bd723 +Subproject commit b514bdc898e2951020cbdca1304b75f5950d1f59