From 69817d29a8849194a49e9bc0a22315c19b0f22a7 Mon Sep 17 00:00:00 2001 From: Eric Mandel Date: Mon, 3 Jun 2019 15:00:25 -0400 Subject: [PATCH] explanatory comment for HAS_NODE --- src/shell.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell.js b/src/shell.js index b10ba3c9c9a39..1e5c92f9bc49c 100644 --- a/src/shell.js +++ b/src/shell.js @@ -68,6 +68,9 @@ var ENVIRONMENT_HAS_NODE = false; var ENVIRONMENT_IS_SHELL = false; ENVIRONMENT_IS_WEB = typeof window === 'object'; ENVIRONMENT_IS_WORKER = typeof importScripts === 'function'; +// A web environment like Electron.js can have Node enabled, so we must +// distinguish between Node-enabled environments and Node environments per se. +// This will allow the former to do things like mount NODEFS. ENVIRONMENT_HAS_NODE = typeof process === 'object' && typeof require === 'function'; ENVIRONMENT_IS_NODE = ENVIRONMENT_HAS_NODE && !ENVIRONMENT_IS_WEB && !ENVIRONMENT_IS_WORKER; ENVIRONMENT_IS_SHELL = !ENVIRONMENT_IS_WEB && !ENVIRONMENT_IS_NODE && !ENVIRONMENT_IS_WORKER;