[IMP] hr_holidays: set time off default employee when created from allocation smart button

In hr_holidays, each allocation granted to an employee has a smart button to see the linked
time off for this employee.
The create button on the tree view that shows these time off opens the form
with self.env.user.employee_id as default employee.

This commit changes the default employee of the time off to be the one of the original allocation

task-2844554

closes odoo#90739

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Author: Philippe Wauthy

addons/hr_holidays/models/hr_leave.py

@@ -457,12 +457,20 @@ def _compute_from_employee_ids(self):
 
     @api.depends('holiday_type')
     def _compute_from_holiday_type(self):
+        allocation_from_domain = self.env['hr.leave.allocation']
+        if (self._context.get('active_model') == 'hr.leave.allocation' and
+           self._context.get('active_id')):
+            allocation_from_domain = allocation_from_domain.browse(self._context['active_id'])
         for holiday in self:
             if holiday.holiday_type == 'employee':
                 if not holiday.employee_ids:
-                    # This handles the case where a request is made with only the employee_id
-                    # but does not need to be recomputed on employee_id changes
-                    holiday.employee_ids = holiday.employee_id or self.env.user.employee_id
+                    if allocation_from_domain:
+                        holiday.employee_ids = allocation_from_domain.employee_id
+                        holiday.holiday_status_id = allocation_from_domain.holiday_status_id
+                    else:
+                        # This handles the case where a request is made with only the employee_id
+                        # but does not need to be recomputed on employee_id changes
+                        holiday.employee_ids = holiday.employee_id or self.env.user.employee_id
                 holiday.mode_company_id = False
                 holiday.category_id = False
             elif holiday.holiday_type == 'company':

addons/hr_holidays/models/hr_leave_type.py

@@ -397,7 +397,8 @@ def _compute_accrual_count(self):
     @api.depends('employee_requests')
     def _compute_allocation_validation_type(self):
         for leave_type in self:
-            leave_type.allocation_validation_type = 'no' if leave_type.employee_requests == 'no' else 'officer'
+            if leave_type.employee_requests == 'no':
+                leave_type.allocation_validation_type = 'officer'
 
     def requested_name_get(self):
         return self._context.get('holiday_status_name_get', True) and self._context.get('employee_id')