implemented WTreeView/WTableView events outside items

Author: Koen Deforche

ReleaseNotes.html

@@ -295,6 +295,19 @@ <h3>C) Non-backwards compatible changes</h3>
     WTreeNode::labelArea() is no longer returning a WTableCell but
     instead a WContainerWidget.
   </dd>
+
+  <dt>
+    <a href="classWt_1_1WTreeView.html">WTreeView</a>,
+    <a href="classWt_1_1WTableView.html">WTableView</a>
+  </dt>
+  <dd>
+    Event handling (clicked(), doubleClicked(), ... ) has been
+    generalized: events that are not generated on an item (but for
+    example in empty space below the items) will now also
+    generate these events, but then with an invalid model index.
+    You may thus need to adapt current code to check whether the model
+    index that is returned is valid.
+  </dd>
 </dl>
 <hr>
 

examples/simplechat/PopupChatWidget.C

@@ -49,7 +49,6 @@ PopupChatWidget::PopupChatWidget(SimpleChatServer& server,
   updateUsers();
 
   connect();
-
 }
 
 void PopupChatWidget::setName(const Wt::WString& name)

examples/widgetgallery/approot/text.xml

@@ -967,15 +967,15 @@
           ${doc-link WCssTheme} class as it is the default theme.
         </dd>
         <dt>polished</dt>
-        <dd>This class is also part of the ${doc-link WCssTheme} class. You can
-          change to this CSS theme with the method <tt>setCssTheme()</tt>
-          from the class ${doc-link WApplication} and passing the parameter
-          "polished".
+        <dd>This theme is also implemented by the ${doc-link WCssTheme} class.
+	  You can change to this CSS theme with <tt>setCssTheme("polished")</tt>
+          in your ${doc-link WApplication}.
         </dd>
         <dt>bootstrap</dt>
         <dd>
-          This class is also part of the ${doc-link WBootstrapTheme} class. Use
-          <tt>setCssTheme("bootstrap")</tt> to apply this theme.
+          This theme is implemented by the ${doc-link WBootstrapTheme}
+          class, and relies on Twitter's Bootstrap CSS framework. Use
+          <tt>setTheme(new WBootstrapTheme())</tt> to use this theme.
         </dd>
       </dl>
     </p>

examples/widgetgallery/examples/Flash.cpp

@@ -9,7 +9,7 @@ std::string poster = "pics/sintel_trailer.jpg";
 Wt::WContainerWidget *container = new Wt::WContainerWidget();
 
 Wt::WFlashObject *flash =
-    new Wt::WFlashObject("www.youtube.com/watch?v=HOfdboHvshg", container);
+    new Wt::WFlashObject("http://www.youtube.com/v/HOfdboHvshg", container);
 flash->setFlashParameter("allowFullScreen", "true");
 flash->setAlternativeContent(new Wt::WImage(poster));
 flash->resize(640, 360);

examples/wt-homepage/WtHome.C

@@ -35,7 +35,7 @@ WtHome::WtHome(const WEnvironment& env)
   if (wtExamplePath)
     wtExamplePath_ = wtExamplePath;
   else
-    wtExamplePath_ = "../";
+    wtExamplePath_ = "..";
 
   init();
 }

examples/wt-homepage/jwt-home.xml

@@ -630,9 +630,8 @@ the <a href="https://github.com/kdeforche/jwt">github
 repository</a>.</p>
 
 <p>
-Alternatively checkout the repository from:
 <div class="fragment">
-  <pre class="fragment">$ git clone http://www.webtoolkit.eu/git/jwt.git</pre>
+  <pre class="fragment">$ git clone git://github.com/kdeforche/jwt.git</pre>
 </div>
 </p>
   </message>

examples/wt-homepage/wt-home.xml

@@ -357,9 +357,8 @@ tutorial</a>) has the following features:
   <li>Use a single connection or share connection pools between
     multiple sessions from which connections are used only during an
     active transaction.</li>
-  <li>Comes with Sqlite3, Firebird, and PostgreSQL backends, and a <a
-    href="http://wtdbomysql.sourceforge.net/">MySQL backend (GPL
-    only)</a> is maintained by the community (Paul Harisson).</li>
+  <li>Comes with Sqlite3, Firebird, MariaDB/MySQL and PostgreSQL
+    backends, and an Oracle backend is also available on request.</li>
 </ul>
 
 <h4>Testing</h4>
@@ -989,7 +988,7 @@ Download the package
 (<a href="http://www.webtoolkit.eu/packages/winst-0.4.tar.gz">winst-0.4.tar.gz</a>)
 or get the latest git version:
 <div class="fragment">
-  <pre class="fragment">$ git clone http://www.webtoolkit.eu/git/winst.git</pre>
+  <pre class="fragment">$ git clone git://github.com/kdeforche/wt.git</pre>
 </div>
 </p>
 
@@ -1031,7 +1030,7 @@ features in Wt:
     <a href="http://www.webtoolkit.eu/wt/doc/reference/html/classWt_1_1WPdfImage.html">WPdfImage</a>
     paint device will be included, which provides rendering support for PDF
     documents. For more complete support for TrueType fonts and Unicode, you'll
-    want <a href="https://github.com/kdeforche/libharu">a patched libharu</a>
+    want <a href="https://github.com/libharu/libharu">the latest git version</a>
     and probably also libpango (see further) for accurate font/glyph
     selection.
   </li>
@@ -1112,7 +1111,7 @@ repository</a>.</p>
 <p>
 Alternatively checkout the repository using:
 <div class="fragment">
-  <pre class="fragment">$ git clone http://www.webtoolkit.eu/git/wt.git</pre>
+  <pre class="fragment">$ git clone git://github.com/kdeforche/wt.git</pre>
 </div>
 </p>
   </message>

src/Wt/WAbstractItemView

@@ -691,25 +691,37 @@ public:
 
   bool isEditing() const;
 
-  /*! \brief %Signal emitted when an item is clicked.
+  /*! \brief %Signal emitted when clicked.
    *
+   * When the event happened over an item, the first argument
+   * indicates the item that was clicked on.
+
    * \sa doubleClicked()
    */
   Signal<WModelIndex, WMouseEvent>& clicked() { return clicked_; }
 
-  /*! \brief %Signal emitted when an item is double clicked.
+  /*! \brief %Signal emitted when double clicked.
+   *
+   * When the event happened over an item, the first argument
+   * indicates the item that was double clicked on.
    *
    * \sa clicked()
    */
   Signal<WModelIndex, WMouseEvent>& doubleClicked() { return doubleClicked_; }
 
   /*! \brief %Signal emitted when a mouse button is pressed down.
+   *
+   * When the event happened over an item, the first argument
+   * indicates the item where the mouse went down.
    *
    * \sa mouseWentUp()
    */
   Signal<WModelIndex, WMouseEvent>& mouseWentDown() { return mouseWentDown_; }
 
   /*! \brief %Signal emitted when the mouse button is released.
+   *
+   * When the event happened over an item, the first argument
+   * indicates the item where the mouse went up.
    *
    * \sa mouseWentDown()
    */

src/Wt/WAbstractItemView.C

@@ -1230,10 +1230,12 @@ void WAbstractItemView::expandColumn(int columnid)
 void WAbstractItemView::handleClick(const WModelIndex& index,
 				    const WMouseEvent& event)
 {
-  bool doEdit = ((editTriggers() & SelectedClicked) && isSelected(index))
-    || (editTriggers() & SingleClicked);
+  bool doEdit = index.isValid() && 
+    (((editTriggers() & SelectedClicked) && isSelected(index)) ||
+     (editTriggers() & SingleClicked));
 
-  selectionHandleClick(index, event.modifiers());
+  if (index.isValid())
+    selectionHandleClick(index, event.modifiers());
 
   if (doEdit)
     edit(index);
@@ -1244,7 +1246,7 @@ void WAbstractItemView::handleClick(const WModelIndex& index,
 void WAbstractItemView::handleDoubleClick(const WModelIndex& index,
 					  const WMouseEvent& event)
 {
-  bool doEdit = editTriggers() & DoubleClicked;
+  bool doEdit = index.isValid() && (editTriggers() & DoubleClicked);
   if (doEdit)
     edit(index);
 

src/Wt/WLocale

@@ -105,6 +105,12 @@ public:
    */
   std::string name() const { return name_; }
 
+  /*! \brief Casts to the locale string (for pre-3.3.0 compatibility).
+   *
+   * \deprecated Use name() instead. 
+   */
+  operator std::string() const { return name(); }
+
   /*! \brief Returns the current (user) locale.
    *
    * This returns WApplication::instance()->locale() if the