Several changes:

    - make single click selection the default for a calendar, and un-deprecate WCalendar::setSingleClickSelect() (#2655)
    - wt-homepage: update google analytics API
    - themes: fix RTL regressions (#2648)
    - Wt::Auth: fix processEnvironment() in progressive bootstrap mode not showing the dialogs
    - Wt::Chart::WAxis: fix setLabelInterval() not working properly for range 30-120s
    - Wt::Dbo: isTransient() now also true for ptr's that were removed from DB
    - WDialog: fix #2646: footer() lazy-creates the footer
    - WStackedWidget: Fix #2645, patch from Bruce Toll, animation glitches
    - Revert firefox layout manager regression (in e.g. bootstrap 2 dialogs)
    - WAppcliation: restore confirm dialog when quited (#2603, Bruce Tool)
    - WPushButton: added a warning as per #1802
    - WAbstractItemView: fix #2284, ctrl-select unselects in single selection mode too
    - WPopupWidget: implemented #2396: automatic deletion on close
    - WPushBtton: fix resolveUrl when updating button icon, and fix redundant set of icon (#2599)
    - WTableView, WTreeView: fix scrollTo() being done before geometry modifications (#2525)
    - Wt::Render: more robust detection of a thead for repeating headers
    - Wt::Dbo::mysql backend: Doing mysql_library_init once, without locking and fixed race condition: mysql_init is not threadsafe
    - Wt::Dbo: restore query<bool> functionality (#2543)

Author: Koen Deforche

examples/chart3D/CategoryExample.C

@@ -128,6 +128,9 @@ CategoryExample::~CategoryExample()
   delete planeModel_;
   delete isotopeModel_;
 
+  std::vector<WAbstractDataSeries3D*> onChart = chart_->dataSeries();
+  for (unsigned i=0; i < onChart.size(); i++)
+    chart_->removeDataSeries(onChart[i]);
   for (unsigned i=0; i < series_.size(); i++)
     delete series_[i];
 }

examples/chart3D/NumericalExample.C

@@ -164,6 +164,9 @@ NumericalExample::~NumericalExample()
   delete para1Model_;
   delete para2Model_;
 
+  std::vector<WAbstractDataSeries3D*> onChart = chart_->dataSeries();
+  for (unsigned i=0; i < onChart.size(); i++)
+    chart_->removeDataSeries(onChart[i]);
   for (unsigned i=0; i < series_.size(); i++)
     delete series_[i];
 }

examples/widgetgallery/approot/text.xml

@@ -917,13 +917,26 @@
         </dd>
         <dt>bootstrap</dt>
         <dd>
-          This theme is implemented by the ${doc-link WBootstrapTheme}
-          class, and relies on Twitter's Bootstrap CSS framework. Use
-          <tt>setTheme(new WBootstrapTheme())</tt> to use this theme.
-          We support Bootstrap 2 and Bootstrap 3, so you may choose your
-          favorite Bootstrap version with WTheme::setVersion function. The
-          widget gallery is using Bootstrap 3.
-          <a href="http://getbootstrap.com/">Bootstrap documentation</a>
+	  <p>
+	    This theme is implemented by the ${doc-link WBootstrapTheme}
+	    class, and relies on <a
+	    href="http://getbootstrap.com/">Twitter's Bootstrap CSS
+	    framework</a>. Use <tt>setTheme(new WBootstrapTheme())</tt>
+	    to use this theme.
+	  </p>
+	  <p>
+	    As of version 3.3.2, Bootstrap 2 and Bootstrap 3 versions
+	    are supported. The widget gallery has been restyled to use
+	    Bootstrap 3. While the theme makes sure that Wt's widgets
+	    are rendered with the markup expected by bootstrap, there
+	    are many features that are particular to the layout system
+	    of bootstrap (and chaned from version 2 to version
+	    3). Thus you need to know how bootstrap expects you to
+	    layout widgets in order to effectivily use this theme, for
+	    which we refer to the <a
+	    href="http://getbootstrap.com/">Bootstrap
+	    documentation</a>.
+	  </p>
         </dd>
       </dl>
     </p>

examples/widgetgallery/examples/CalendarSimple.cpp

@@ -13,7 +13,8 @@ out->addStyleClass("help-block");
 c1->selectionChanged().connect(std::bind([=] () {
     std::set<Wt::WDate> selection = c1->selection();
     if (selection.size() != 0) {
-        Wt::WDate d = *selection.begin();
+        Wt::WDate d;
+	d = (*selection.begin());
 	Wt::WDate toDate(d.year() + 1, 1, 1);
 	int days = d.daysTo(toDate);
 	out->setText(Wt::WString("<p>That's {1} days until New Year's Day!</p>")

examples/widgetgallery/examples/CategoryCharts3D.cpp

@@ -1,7 +1,9 @@
+#include <Wt/WApplication>
 #include <Wt/WContainerWidget>
 #include <Wt/WStandardItemModel>
 #include <Wt/WCssDecorationStyle>
 #include <Wt/WBorder>
+#include <Wt/WImage>
 #include <Wt/Chart/WCartesian3DChart>
 #include <Wt/Chart/WGridData>
 
@@ -44,6 +46,6 @@ isotopes->setType(Wt::Chart::BarSeries3D);
 // add the dataseries to the chart
 chart->addDataSeries(isotopes);
 
-chart->setAlternativeContent(new Wt::WImage("pics/categoricalChartScreenshot.png", container));
+chart->setAlternativeContent(new Wt::WImage(Wt::WLink("pics/categoricalChartScreenshot.png"), container));
 
 SAMPLE_END(return container)

examples/widgetgallery/examples/NumericalCharts3D.cpp

@@ -3,6 +3,7 @@
 #include <Wt/WCssDecorationStyle>
 #include <Wt/WBorder>
 #include <Wt/WContainerWidget>
+#include <Wt/WImage>
 #include <Wt/Chart/WCartesian3DChart>
 #include <Wt/Chart/WGridData>
 #include <Wt/Chart/WEquidistantGridData>
@@ -70,6 +71,6 @@ chart->addDataSeries(dataset1);
 chart->addDataSeries(dataset2);
 chart->addDataSeries(dataset3);
 
-chart->setAlternativeContent(new Wt::WImage("pics/numericalChartScreenshot.png", container));
+chart->setAlternativeContent(new Wt::WImage(Wt::WLink("pics/numericalChartScreenshot.png"), container));
 
 SAMPLE_END(return container)

examples/widgetgallery/examples/PieChart.cpp

@@ -53,14 +53,12 @@ table->setModel(model);
 table->setColumnWidth(1, 100);
 table->setRowHeight(28);
 table->setHeaderHeight(28);
+table->setWidth(150 + 100 + 14 + 2);
 
-if (Wt::WApplication::instance()->environment().ajax()) {
-    table->resize(150 + 100 + 14, 7 * 28);
+if (Wt::WApplication::instance()->environment().ajax())
     table->setEditTriggers(Wt::WAbstractItemView::SingleClicked);
-} else {
-    table->resize(150 + 100 + 14, Wt::WLength::Auto);
+else
     table->setEditTriggers(Wt::WAbstractItemView::NoEditTrigger);
-}
 
 /*
  * Create the pie chart.

examples/widgetgallery/examples/ScatterPlotData.cpp

@@ -42,10 +42,10 @@ table->setColumnAlignment(0, Wt::AlignCenter);
 table->setHeaderAlignment(0, Wt::AlignCenter);
 table->setRowHeight(28);
 table->setHeaderHeight(28);
-table->resize(800, 200);
 table->setColumnWidth(0, 80);
 for (int column = 1; column < model->columnCount(); ++column)
     table->setColumnWidth(column, 90);
+table->resize(780, 200);
 
 /*
  * Use a delegate for the numeric data which rounds values sensibly.

examples/widgetgallery/main.C

@@ -24,18 +24,23 @@ Wt::WApplication *createApplication(const Wt::WEnvironment& env)
 	      << "!!!!!!!!!!" << std::endl;
   }
 
+  // Choice of theme: defaults to bootstrap3 but can be overridden using
+  // a theme parameter (for testing)
   const std::string *themePtr = env.getParameter("theme");
   std::string theme;
   if (!themePtr)
     theme = "bootstrap3";
   else
     theme = *themePtr;
 
-  if (theme == "bootstrap3"){
+  if (theme == "bootstrap3") {
     Wt::WBootstrapTheme *bootstrapTheme = new Wt::WBootstrapTheme(app);
     bootstrapTheme->setVersion(Wt::WBootstrapTheme::Version3);
     app->setTheme(bootstrapTheme);
-  } else if (theme == "bootstrap2"){
+
+    // load the default bootstrap3 (sub-)theme
+    app->useStyleSheet("resources/themes/bootstrap/3/bootstrap-theme.min.css");
+  } else if (theme == "bootstrap2") {
     Wt::WBootstrapTheme *bootstrapTheme = new Wt::WBootstrapTheme(app);
     app->setTheme(bootstrapTheme);
   } else

examples/wt-homepage/Home.C

@@ -419,16 +419,7 @@ WString Home::tr(const char *key)
 
 void Home::googleAnalyticsLogger()
 {
-  std::string googleCmd = 
-    "if (window.pageTracker) {"
-    """try {"
-    ""  "setTimeout(function() {"
-    ""  "window.pageTracker._trackPageview(\""
-    + environment().deploymentPath() + internalPath() + "\");"
-    ""  "}, 1000);"
-    """} catch (e) { }"
-    "}";
-
-  doJavaScript(googleCmd);
+  doJavaScript("ga('send','pageview','"
+	       + environment().deploymentPath() + internalPath() + "');");
 }